[INFO] fetching crate wotbreplay-parser 0.4.2... [INFO] checking wotbreplay-parser-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wotbreplay-parser 0.4.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate wotbreplay-parser 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config [INFO] started tweaking crates.io crate wotbreplay-parser 0.4.2 [INFO] finished tweaking crates.io crate wotbreplay-parser 0.4.2 [INFO] tweaked toml for crates.io crate wotbreplay-parser 0.4.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding iter-read v0.3.1 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding prost v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding serde_with v2.3.3 (latest: v3.9.0) [INFO] [stderr] Adding serde_with_macros v2.3.3 (latest: v3.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b5d5014d5dafce60c4e29f5d532ba5da009ac92bcf949c66bd3f197f1a9178f [INFO] running `Command { std: "docker" "start" "-a" "1b5d5014d5dafce60c4e29f5d532ba5da009ac92bcf949c66bd3f197f1a9178f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b5d5014d5dafce60c4e29f5d532ba5da009ac92bcf949c66bd3f197f1a9178f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b5d5014d5dafce60c4e29f5d532ba5da009ac92bcf949c66bd3f197f1a9178f", kill_on_drop: false }` [INFO] [stdout] 1b5d5014d5dafce60c4e29f5d532ba5da009ac92bcf949c66bd3f197f1a9178f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15df7579d5e9f1d1096f9578d87c7e2484a75fc6a1239eae328e7d1ed90a5339 [INFO] running `Command { std: "docker" "start" "-a" "15df7579d5e9f1d1096f9578d87c7e2484a75fc6a1239eae328e7d1ed90a5339", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking iter-read v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Compiling prost-derive v0.11.9 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking prost v0.11.9 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde-pickle v1.1.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking wotbreplay-parser v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/data.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn from_reader(mut reader: impl Read) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let mut packets = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { client_version, packets }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/data/packet.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 44 | let payload = Payload::new(type_, &raw_payload).map_err(|source| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let this = Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Some(this)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/data/packet.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 44 | let payload = Payload::new(type_, &raw_payload).map_err(|source| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Error::PacketPayloadParsingError { [INFO] [stdout] 46 | source: Box::new(source), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replay.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn open(reader: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self(ZipArchive::new(reader)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wotbreplay-parser` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "15df7579d5e9f1d1096f9578d87c7e2484a75fc6a1239eae328e7d1ed90a5339", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15df7579d5e9f1d1096f9578d87c7e2484a75fc6a1239eae328e7d1ed90a5339", kill_on_drop: false }` [INFO] [stdout] 15df7579d5e9f1d1096f9578d87c7e2484a75fc6a1239eae328e7d1ed90a5339