[INFO] fetching crate wot_game_reader 0.1.0... [INFO] checking wot_game_reader-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wot_game_reader 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate wot_game_reader 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wot_game_reader 0.1.0 [INFO] finished tweaking crates.io crate wot_game_reader 0.1.0 [INFO] tweaked toml for crates.io crate wot_game_reader 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 91 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.20.2 (latest: v0.21.0) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eca70c3e1b1cc117a5174a55939983168425f8bd7884fe3fc7f6d93c41564709 [INFO] running `Command { std: "docker" "start" "-a" "eca70c3e1b1cc117a5174a55939983168425f8bd7884fe3fc7f6d93c41564709", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eca70c3e1b1cc117a5174a55939983168425f8bd7884fe3fc7f6d93c41564709", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eca70c3e1b1cc117a5174a55939983168425f8bd7884fe3fc7f6d93c41564709", kill_on_drop: false }` [INFO] [stdout] eca70c3e1b1cc117a5174a55939983168425f8bd7884fe3fc7f6d93c41564709 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9da1dc9c742391c7871196da1203d2de086b092f44ec3b264a521693489f06d [INFO] running `Command { std: "docker" "start" "-a" "e9da1dc9c742391c7871196da1203d2de086b092f44ec3b264a521693489f06d", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling merge_derive-hashmap v0.1.1 [INFO] [stderr] Checking merge-hashmap v0.1.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking lalrpop-util v0.20.2 [INFO] [stderr] Checking locale_config v0.3.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Checking serde_variant v0.1.3 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Compiling poreader v1.1.2 [INFO] [stderr] Checking wot_game_reader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/map/arena.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | for (_, mut gameplay) in &mut map_def.gameplay_types { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/localization/mod.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 69 | let file = catalog.get(&self.game_reader)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let parser = PoParser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let mut reader = parser.parse(file)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | found.ok_or(GameReadError::LocalizationKeyNotFound) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/map/arena.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | for (_, mut gameplay) in &mut map_def.gameplay_types { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wot_game_reader` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/localization/mod.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 69 | let file = catalog.get(&self.game_reader)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let parser = PoParser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let mut reader = parser.parse(file)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | found.ok_or(GameReadError::LocalizationKeyNotFound) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wot_game_reader` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e9da1dc9c742391c7871196da1203d2de086b092f44ec3b264a521693489f06d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9da1dc9c742391c7871196da1203d2de086b092f44ec3b264a521693489f06d", kill_on_drop: false }` [INFO] [stdout] e9da1dc9c742391c7871196da1203d2de086b092f44ec3b264a521693489f06d