[INFO] fetching crate wof 0.2.0... [INFO] checking wof-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wof 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate wof 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wof 0.2.0 [INFO] finished tweaking crates.io crate wof 0.2.0 [INFO] tweaked toml for crates.io crate wof 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate wof 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f9bb985459caafc38237e433145c2fc0be3533ee9ea3df772ecf3faf0312524 [INFO] running `Command { std: "docker" "start" "-a" "8f9bb985459caafc38237e433145c2fc0be3533ee9ea3df772ecf3faf0312524", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f9bb985459caafc38237e433145c2fc0be3533ee9ea3df772ecf3faf0312524", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f9bb985459caafc38237e433145c2fc0be3533ee9ea3df772ecf3faf0312524", kill_on_drop: false }` [INFO] [stdout] 8f9bb985459caafc38237e433145c2fc0be3533ee9ea3df772ecf3faf0312524 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2681ecd76859227337cb39acaf1e371f8a7d30dd013b12577681cc427397cf7 [INFO] running `Command { std: "docker" "start" "-a" "a2681ecd76859227337cb39acaf1e371f8a7d30dd013b12577681cc427397cf7", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking aho-corasick v0.7.7 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking json v0.12.2 [INFO] [stderr] Checking dbase v0.0.4 [INFO] [stderr] Checking shapefile v0.1.1 [INFO] [stderr] Compiling libsqlite3-sys v0.17.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking rusqlite v0.21.0 [INFO] [stderr] Checking wof v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/wof.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | (self.get_min_lat() + ((self.get_max_lat() - self.get_min_lat()) / 2.0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 263 - (self.get_min_lat() + ((self.get_max_lat() - self.get_min_lat()) / 2.0)) [INFO] [stdout] 263 + self.get_min_lat() + ((self.get_max_lat() - self.get_min_lat()) / 2.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/wof.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | (self.get_min_lon() + ((self.get_max_lon() - self.get_min_lon()) / 2.0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - (self.get_min_lon() + ((self.get_max_lon() - self.get_min_lon()) / 2.0)) [INFO] [stdout] 271 + self.get_min_lon() + ((self.get_max_lon() - self.get_min_lon()) / 2.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/wof.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | (self.get_min_lat() + ((self.get_max_lat() - self.get_min_lat()) / 2.0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 263 - (self.get_min_lat() + ((self.get_max_lat() - self.get_min_lat()) / 2.0)) [INFO] [stdout] 263 + self.get_min_lat() + ((self.get_max_lat() - self.get_min_lat()) / 2.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/wof.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | (self.get_min_lon() + ((self.get_max_lon() - self.get_min_lon()) / 2.0)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - (self.get_min_lon() + ((self.get_max_lon() - self.get_min_lon()) / 2.0)) [INFO] [stdout] 271 + self.get_min_lon() + ((self.get_max_lon() - self.get_min_lon()) / 2.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn parse_file_to_json>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let buffer = read_file_to_string(path)?; [INFO] [stdout] 27 | match json::parse(&buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite/mod.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new>(path: P, opts: SQLiteOpts) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(SQLite { [INFO] [stdout] | ________^ [INFO] [stdout] 38 | | conn: Connection::open(path).stringify_err("connection to database")?, [INFO] [stdout] 39 | | opts: opts, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/walk.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new>(directory: P, with_alt: bool, with_deprecated: bool) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Walk { [INFO] [stdout] 19 | walker: WalkDir::new(directory).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/walk.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new>(directory: P, with_alt: bool, with_deprecated: bool) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | geojson_regex: Regex::new(r"\.geojson$").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/walk.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new>(directory: P, with_alt: bool, with_deprecated: bool) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | alt_regex: Regex::new(r"^\d+-alt.*\.geojson$").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapefile/mod.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new>(path: P, opts: ShapefileOpts) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 37 | | writer: Writer::from_path(path).stringify_err("Can't create the shapefile")?, [INFO] [stdout] 38 | | opts: opts, [INFO] [stdout] 39 | | polygons: vec![], [INFO] [stdout] 40 | | points: vec![], [INFO] [stdout] 41 | | polylines: vec![], [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wof` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn parse_file_to_json>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let buffer = read_file_to_string(path)?; [INFO] [stdout] 27 | match json::parse(&buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite/mod.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new>(path: P, opts: SQLiteOpts) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(SQLite { [INFO] [stdout] | ________^ [INFO] [stdout] 38 | | conn: Connection::open(path).stringify_err("connection to database")?, [INFO] [stdout] 39 | | opts: opts, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/walk.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new>(directory: P, with_alt: bool, with_deprecated: bool) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Walk { [INFO] [stdout] 19 | walker: WalkDir::new(directory).into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/walk.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new>(directory: P, with_alt: bool, with_deprecated: bool) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | geojson_regex: Regex::new(r"\.geojson$").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/walk.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new>(directory: P, with_alt: bool, with_deprecated: bool) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | alt_regex: Regex::new(r"^\d+-alt.*\.geojson$").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shapefile/mod.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new>(path: P, opts: ShapefileOpts) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 37 | | writer: Writer::from_path(path).stringify_err("Can't create the shapefile")?, [INFO] [stdout] 38 | | opts: opts, [INFO] [stdout] 39 | | polygons: vec![], [INFO] [stdout] 40 | | points: vec![], [INFO] [stdout] 41 | | polylines: vec![], [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wof` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a2681ecd76859227337cb39acaf1e371f8a7d30dd013b12577681cc427397cf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2681ecd76859227337cb39acaf1e371f8a7d30dd013b12577681cc427397cf7", kill_on_drop: false }` [INFO] [stdout] a2681ecd76859227337cb39acaf1e371f8a7d30dd013b12577681cc427397cf7