[INFO] fetching crate wmark 0.1.4... [INFO] checking wmark-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wmark 0.1.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate wmark 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wmark 0.1.4 [INFO] finished tweaking crates.io crate wmark 0.1.4 [INFO] tweaked toml for crates.io crate wmark 0.1.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 149 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-channel v0.3.29 (latest: v0.3.30) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding futures-macro v0.3.29 (latest: v0.3.30) [INFO] [stderr] Adding futures-util v0.3.29 (latest: v0.3.30) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding send_wrapper v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dedfc94509531a04cc0b821efe10552bbef59104108c1bbfeca615997dedab4e [INFO] running `Command { std: "docker" "start" "-a" "dedfc94509531a04cc0b821efe10552bbef59104108c1bbfeca615997dedab4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dedfc94509531a04cc0b821efe10552bbef59104108c1bbfeca615997dedab4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dedfc94509531a04cc0b821efe10552bbef59104108c1bbfeca615997dedab4e", kill_on_drop: false }` [INFO] [stdout] dedfc94509531a04cc0b821efe10552bbef59104108c1bbfeca615997dedab4e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8491e9bc3202d148608f8e6f6457cf45a0e2dd37ef4b4d289d8947b99ab1fdcf [INFO] running `Command { std: "docker" "start" "-a" "8491e9bc3202d148608f8e6f6457cf45a0e2dd37ef4b4d289d8947b99ab1fdcf", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking atomic_refcell v0.1.13 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec-wrapper v0.1.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking wg v0.9.1 [INFO] [stderr] Checking wmark v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/closer/std_.rs:49:7 [INFO] [stdout] | [INFO] [stdout] 47 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ( [INFO] [stdout] 49 | Self { rx }, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wmark` (lib) due to 10 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/closer/std_.rs:50:7 [INFO] [stdout] | [INFO] [stdout] 47 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / Canceler { [INFO] [stdout] 51 | | tx: AtomicPtr::new(Box::into_raw(Box::new(tx)) as _), [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/closer/std_.rs:83:11 [INFO] [stdout] | [INFO] [stdout] 81 | let (ctx, cancel) = CancelContext::new(); [INFO] [stdout] | --- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Self { [INFO] [stdout] 83 | wg: WaitGroup::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/closer/std_.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 91 | let (ctx, cancel) = CancelContext::new(); [INFO] [stdout] | --- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Self { [INFO] [stdout] 93 | wg: WaitGroup::from(initial), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watermark/std_.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 171 | let (mark_tx, mark_rx) = bounded(100); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Self { [INFO] [stdout] 173 | inner: Arc::new(Inner { [INFO] [stdout] | ______________^ [INFO] [stdout] 174 | | done_until: CachePadded::new(AtomicU64::new(0)), [INFO] [stdout] 175 | | last_index: CachePadded::new(AtomicU64::new(0)), [INFO] [stdout] 176 | | name, [INFO] [stdout] 177 | | mark_tx, [INFO] [stdout] 178 | | mark_rx, [INFO] [stdout] 179 | | }), [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watermark/std_.rs:228:22 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn begin_many(&self, indices: MediumVec) -> Result<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | self.check().map(|_| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 229 | | let last_index = *indices.last().unwrap(); [INFO] [stdout] 230 | | self.inner.last_index.store(last_index, Ordering::SeqCst); [INFO] [stdout] 231 | | self [INFO] [stdout] ... | [INFO] [stdout] 239 | | .unwrap() [INFO] [stdout] 240 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watermark/std_.rs:231:7 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn begin_many(&self, indices: MediumVec) -> Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | / self [INFO] [stdout] 232 | | .inner [INFO] [stdout] 233 | | .mark_tx [INFO] [stdout] 234 | | .send(Mark { [INFO] [stdout] ... | [INFO] [stdout] 237 | | done: false, [INFO] [stdout] 238 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watermark/std_.rs:266:22 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn done_many(&self, indices: MediumVec) -> Result<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | self.check().map(|_| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 267 | | self [INFO] [stdout] 268 | | .inner [INFO] [stdout] 269 | | .mark_tx [INFO] [stdout] ... | [INFO] [stdout] 275 | | .unwrap() // unwrap is safe because self also holds a receiver [INFO] [stdout] 276 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watermark/std_.rs:267:7 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn done_many(&self, indices: MediumVec) -> Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | / self [INFO] [stdout] 268 | | .inner [INFO] [stdout] 269 | | .mark_tx [INFO] [stdout] 270 | | .send(Mark { [INFO] [stdout] ... | [INFO] [stdout] 273 | | done: true, [INFO] [stdout] 274 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8491e9bc3202d148608f8e6f6457cf45a0e2dd37ef4b4d289d8947b99ab1fdcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8491e9bc3202d148608f8e6f6457cf45a0e2dd37ef4b4d289d8947b99ab1fdcf", kill_on_drop: false }` [INFO] [stdout] 8491e9bc3202d148608f8e6f6457cf45a0e2dd37ef4b4d289d8947b99ab1fdcf