[INFO] fetching crate witx-overview-docgen 0.1.2... [INFO] checking witx-overview-docgen-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate witx-overview-docgen 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate witx-overview-docgen 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate witx-overview-docgen 0.1.2 [INFO] finished tweaking crates.io crate witx-overview-docgen 0.1.2 [INFO] tweaked toml for crates.io crate witx-overview-docgen 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate witx-overview-docgen 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b6cd4f2bcb25675b5801a92ca8f5a00163647e4d630381a478cb48dbcfcc555 [INFO] running `Command { std: "docker" "start" "-a" "0b6cd4f2bcb25675b5801a92ca8f5a00163647e4d630381a478cb48dbcfcc555", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b6cd4f2bcb25675b5801a92ca8f5a00163647e4d630381a478cb48dbcfcc555", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b6cd4f2bcb25675b5801a92ca8f5a00163647e4d630381a478cb48dbcfcc555", kill_on_drop: false }` [INFO] [stdout] 0b6cd4f2bcb25675b5801a92ca8f5a00163647e4d630381a478cb48dbcfcc555 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2dd845f6704026756588261269afa18001ec1649cec173912578fdbf60b133f7 [INFO] running `Command { std: "docker" "start" "-a" "2dd845f6704026756588261269afa18001ec1649cec173912578fdbf60b133f7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling syn v1.0.44 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking leb128 v0.2.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking wast v22.0.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling thiserror-impl v1.0.21 [INFO] [stderr] Checking thiserror v1.0.21 [INFO] [stderr] Checking witx v0.8.7 [INFO] [stderr] Checking witx-overview-docgen v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/generator.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 292 | return Ok(()); [INFO] [stdout] | ------------- any code following this expression is unreachable [INFO] [stdout] 293 | / if docs.is_empty() { [INFO] [stdout] 294 | | return Ok(()); [INFO] [stdout] 295 | | } [INFO] [stdout] | |_________^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `as_type` [INFO] [stdout] --> src/generator.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | as_type: &ASType, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_as_type` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/generator.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 292 | return Ok(()); [INFO] [stdout] | ------------- any code following this expression is unreachable [INFO] [stdout] 293 | / if docs.is_empty() { [INFO] [stdout] 294 | | return Ok(()); [INFO] [stdout] 295 | | } [INFO] [stdout] | |_________^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `module_name` [INFO] [stdout] --> src/generator.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | let module_name = match self.module_name.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_module_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/generator.rs:291:29 [INFO] [stdout] | [INFO] [stdout] 291 | fn write_docs(w: &mut PrettyWriter, docs: &str) -> Result<(), Error> { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `docs` [INFO] [stdout] --> src/generator.rs:291:54 [INFO] [stdout] | [INFO] [stdout] 291 | fn write_docs(w: &mut PrettyWriter, docs: &str) -> Result<(), Error> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_nullable` is never used [INFO] [stdout] --> src/astype.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl ASType { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] 61 | pub fn is_nullable(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/error.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | Witx(WitxError), [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 6 | Witx(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/error.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 7 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `continuation_bytes` is never read [INFO] [stdout] --> src/pretty_writer.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PrettyWriter { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | continuation_bytes: &'static str, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `continuation` is never used [INFO] [stdout] --> src/pretty_writer.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl PrettyWriter { [INFO] [stdout] | ------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 106 | pub fn continuation(&mut self) -> Result<&mut Self, Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_writer.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new_with_indent(writer: W, indent: u32, indent_bytes: &'static str) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | PrettyWriter { [INFO] [stdout] 31 | writer: Rc::new(RefCell::new(writer)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_writer.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 64 | fn _write_all>(writer: &mut W, buf: T) -> Result<(), Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let buf = buf.as_ref(); [INFO] [stdout] 66 | writer.write_all(buf).map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `as_type` [INFO] [stdout] --> src/generator.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | as_type: &ASType, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_as_type` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witx-overview-docgen` (bin "witx-overview-docgen") due to 3 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `module_name` [INFO] [stdout] --> src/generator.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | let module_name = match self.module_name.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_module_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/generator.rs:291:29 [INFO] [stdout] | [INFO] [stdout] 291 | fn write_docs(w: &mut PrettyWriter, docs: &str) -> Result<(), Error> { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `docs` [INFO] [stdout] --> src/generator.rs:291:54 [INFO] [stdout] | [INFO] [stdout] 291 | fn write_docs(w: &mut PrettyWriter, docs: &str) -> Result<(), Error> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_nullable` is never used [INFO] [stdout] --> src/astype.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl ASType { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] 61 | pub fn is_nullable(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/error.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | Witx(WitxError), [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 6 | Witx(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/error.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | Io(std::io::Error), [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 7 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `continuation_bytes` is never read [INFO] [stdout] --> src/pretty_writer.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PrettyWriter { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | continuation_bytes: &'static str, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `continuation` is never used [INFO] [stdout] --> src/pretty_writer.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl PrettyWriter { [INFO] [stdout] | ------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 106 | pub fn continuation(&mut self) -> Result<&mut Self, Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_writer.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new_with_indent(writer: W, indent: u32, indent_bytes: &'static str) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | PrettyWriter { [INFO] [stdout] 31 | writer: Rc::new(RefCell::new(writer)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_writer.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 64 | fn _write_all>(writer: &mut W, buf: T) -> Result<(), Error> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let buf = buf.as_ref(); [INFO] [stdout] 66 | writer.write_all(buf).map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witx-overview-docgen` (bin "witx-overview-docgen" test) due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2dd845f6704026756588261269afa18001ec1649cec173912578fdbf60b133f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dd845f6704026756588261269afa18001ec1649cec173912578fdbf60b133f7", kill_on_drop: false }` [INFO] [stdout] 2dd845f6704026756588261269afa18001ec1649cec173912578fdbf60b133f7