[INFO] fetching crate witness 0.3.0... [INFO] checking witness-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate witness 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate witness 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate witness 0.3.0 [INFO] finished tweaking crates.io crate witness 0.3.0 [INFO] tweaked toml for crates.io crate witness 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate witness 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0a2b91b57948084aada4c6df98a4612199deeb5dcc975ea78820d7026cb19dc [INFO] running `Command { std: "docker" "start" "-a" "a0a2b91b57948084aada4c6df98a4612199deeb5dcc975ea78820d7026cb19dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0a2b91b57948084aada4c6df98a4612199deeb5dcc975ea78820d7026cb19dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0a2b91b57948084aada4c6df98a4612199deeb5dcc975ea78820d7026cb19dc", kill_on_drop: false }` [INFO] [stdout] a0a2b91b57948084aada4c6df98a4612199deeb5dcc975ea78820d7026cb19dc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d038a888f4a9dab35aa1d499c20fdcc5feab9122330a954f3d7d22444a4f8018 [INFO] running `Command { std: "docker" "start" "-a" "d038a888f4a9dab35aa1d499c20fdcc5feab9122330a954f3d7d22444a4f8018", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking tracing-core v0.1.24 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.11 [INFO] [stderr] Checking clap v3.1.8 [INFO] [stderr] Checking witness v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / if args.network.trigger { [INFO] [stdout] 23 | | run_trigger(&args.network).await [INFO] [stdout] 24 | | } else { [INFO] [stdout] | | ____________- [INFO] [stdout] 25 | || run_watch(&args).await [INFO] [stdout] 26 | || } [INFO] [stdout] | ||_____^ [INFO] [stdout] | |_____| [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 73 | #[clap(parse(try_from_str = parse::duration_from_str))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 23 | let (sender, receiver) = tokio::sync::mpsc::channel(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let files = files::FileWatcher::new(&args.files, sender.clone()) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let network = network::NetworkWatcher::new(&args.network, sender) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Watcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | files: Some(files), [INFO] [stdout] 33 | | network: Some(network), [INFO] [stdout] 34 | | receiver, [INFO] [stdout] 35 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher/files.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 23 | triggers: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let (sender, receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut watcher = notify::raw_watcher(sender)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(FileWatcher { watcher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher/network.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 30 | triggers: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> anyhow::Result { [INFO] [stdout] 32 | let (stop_sender, _) = broadcast_channel(1); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let key = Arc::::from(network.key.as_str()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut handles = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(NetworkWatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | stop_signal: stop_sender, [INFO] [stdout] 70 | | handles, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher/network.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 124 | let (mut stream, addr) = incoming.context("failed to accept incoming client")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let key = key.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let triggers = triggers.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | match timeout(duration, stream.read_exact(&mut buffer)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witness` (bin "witness") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / if args.network.trigger { [INFO] [stdout] 23 | | run_trigger(&args.network).await [INFO] [stdout] 24 | | } else { [INFO] [stdout] | | ____________- [INFO] [stdout] 25 | || run_watch(&args).await [INFO] [stdout] 26 | || } [INFO] [stdout] | ||_____^ [INFO] [stdout] | |_____| [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 73 | #[clap(parse(try_from_str = parse::duration_from_str))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 23 | let (sender, receiver) = tokio::sync::mpsc::channel(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let files = files::FileWatcher::new(&args.files, sender.clone()) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let network = network::NetworkWatcher::new(&args.network, sender) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Watcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | files: Some(files), [INFO] [stdout] 33 | | network: Some(network), [INFO] [stdout] 34 | | receiver, [INFO] [stdout] 35 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher/files.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 23 | triggers: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let (sender, receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut watcher = notify::raw_watcher(sender)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(FileWatcher { watcher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher/network.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 30 | triggers: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> anyhow::Result { [INFO] [stdout] 32 | let (stop_sender, _) = broadcast_channel(1); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let key = Arc::::from(network.key.as_str()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut handles = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(NetworkWatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | stop_signal: stop_sender, [INFO] [stdout] 70 | | handles, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher/network.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 124 | let (mut stream, addr) = incoming.context("failed to accept incoming client")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let key = key.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let triggers = triggers.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | match timeout(duration, stream.read_exact(&mut buffer)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witness` (bin "witness" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "d038a888f4a9dab35aa1d499c20fdcc5feab9122330a954f3d7d22444a4f8018", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d038a888f4a9dab35aa1d499c20fdcc5feab9122330a954f3d7d22444a4f8018", kill_on_drop: false }` [INFO] [stdout] d038a888f4a9dab35aa1d499c20fdcc5feab9122330a954f3d7d22444a4f8018