[INFO] fetching crate with_dir 0.1.4... [INFO] checking with_dir-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate with_dir 0.1.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate with_dir 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate with_dir 0.1.4 [INFO] finished tweaking crates.io crate with_dir 0.1.4 [INFO] tweaked toml for crates.io crate with_dir 0.1.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c4970df7c231fbeb831d1bc9a386e91ef974f1b5eb0ecb401bb51152544900c [INFO] running `Command { std: "docker" "start" "-a" "2c4970df7c231fbeb831d1bc9a386e91ef974f1b5eb0ecb401bb51152544900c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c4970df7c231fbeb831d1bc9a386e91ef974f1b5eb0ecb401bb51152544900c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c4970df7c231fbeb831d1bc9a386e91ef974f1b5eb0ecb401bb51152544900c", kill_on_drop: false }` [INFO] [stdout] 2c4970df7c231fbeb831d1bc9a386e91ef974f1b5eb0ecb401bb51152544900c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60c5f8f8faa78cbe4b096a1e46adb0168fbdbe0c3509db47b099d00c69bb8f4a [INFO] running `Command { std: "docker" "start" "-a" "60c5f8f8faa78cbe4b096a1e46adb0168fbdbe0c3509db47b099d00c69bb8f4a", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking with_dir v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(path: impl AsRef) -> Result, std::io::Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | original_dir, [INFO] [stdout] 67 | | cwd: Cwd::NotTemp(path.as_ref().to_owned()), [INFO] [stdout] 68 | | mutex: Some(m), [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let original_dir = current_dir()?; [INFO] [stdout] 78 | let temp_dir = TempDir::new()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | set_current_dir(temp_dir.path())?; [INFO] [stdout] 80 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | original_dir, [INFO] [stdout] 82 | | cwd: Cwd::Temp(temp_dir), [INFO] [stdout] 83 | | mutex: Some(m), [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn create(path: impl AsRef) -> Result, std::io::Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | original_dir, [INFO] [stdout] 97 | | cwd: Cwd::NotTemp(path.as_ref().to_path_buf()), [INFO] [stdout] 98 | | mutex: Some(m), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn create_all(path: impl AsRef) -> Result, std::io::Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | original_dir, [INFO] [stdout] 110 | | cwd: Cwd::NotTemp(path.as_ref().to_path_buf()), [INFO] [stdout] 111 | | mutex: Some(m), [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(path: impl AsRef) -> Result, std::io::Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | original_dir, [INFO] [stdout] 67 | | cwd: Cwd::NotTemp(path.as_ref().to_owned()), [INFO] [stdout] 68 | | mutex: Some(m), [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 76 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let original_dir = current_dir()?; [INFO] [stdout] 78 | let temp_dir = TempDir::new()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | set_current_dir(temp_dir.path())?; [INFO] [stdout] 80 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | original_dir, [INFO] [stdout] 82 | | cwd: Cwd::Temp(temp_dir), [INFO] [stdout] 83 | | mutex: Some(m), [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn create(path: impl AsRef) -> Result, std::io::Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | original_dir, [INFO] [stdout] 97 | | cwd: Cwd::NotTemp(path.as_ref().to_path_buf()), [INFO] [stdout] 98 | | mutex: Some(m), [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `with_dir` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn create_all(path: impl AsRef) -> Result, std::io::Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let m = DIR_MUTEX.lock(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(WithDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | original_dir, [INFO] [stdout] 110 | | cwd: Cwd::NotTemp(path.as_ref().to_path_buf()), [INFO] [stdout] 111 | | mutex: Some(m), [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `with_dir` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "60c5f8f8faa78cbe4b096a1e46adb0168fbdbe0c3509db47b099d00c69bb8f4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60c5f8f8faa78cbe4b096a1e46adb0168fbdbe0c3509db47b099d00c69bb8f4a", kill_on_drop: false }` [INFO] [stdout] 60c5f8f8faa78cbe4b096a1e46adb0168fbdbe0c3509db47b099d00c69bb8f4a