[INFO] fetching crate witgen_macro_helper 0.15.0... [INFO] checking witgen_macro_helper-0.15.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate witgen_macro_helper 0.15.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate witgen_macro_helper 0.15.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate witgen_macro_helper 0.15.0 [INFO] finished tweaking crates.io crate witgen_macro_helper 0.15.0 [INFO] tweaked toml for crates.io crate witgen_macro_helper 0.15.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitmaps v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding pulldown-cmark v0.8.0 (latest: v0.12.0) [INFO] [stderr] Adding sized-chunks v0.6.5 (latest: v0.7.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding syn-file-expand v0.2.0 (latest: v0.3.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff5e5aab857c44ea358f2eab3ade26bd195853f74109fa97535853a912b81917 [INFO] running `Command { std: "docker" "start" "-a" "ff5e5aab857c44ea358f2eab3ade26bd195853f74109fa97535853a912b81917", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff5e5aab857c44ea358f2eab3ade26bd195853f74109fa97535853a912b81917", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff5e5aab857c44ea358f2eab3ade26bd195853f74109fa97535853a912b81917", kill_on_drop: false }` [INFO] [stdout] ff5e5aab857c44ea358f2eab3ade26bd195853f74109fa97535853a912b81917 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a0306d6deb8e336261046525027b92ff39e9da42f5f346766b17bbf8ffc95c4 [INFO] running `Command { std: "docker" "start" "-a" "1a0306d6deb8e336261046525027b92ff39e9da42f5f346766b17bbf8ffc95c4", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pulldown-cmark v0.8.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking unicode-xid v0.2.5 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking id-arena v2.2.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling im-rc v15.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking aha-wit-parser v0.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking syn-file-expand v0.2.0 [INFO] [stderr] Checking witgen_macro_helper v0.15.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub(crate) fn from_items(items: Vec) -> Vec { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | / items [INFO] [stdout] 33 | | .into_iter() [INFO] [stdout] 34 | | .filter_map(|item| item.try_into().ok()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | .filter_map(|item| item.try_into().ok()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 82 | fn from(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Wit::Mod(Wit::from_items(file.items), vec![]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 90 | fn try_from(item: Item) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | / match item { [INFO] [stdout] 92 | | Item::Enum(item) => Wit::Variant(item), [INFO] [stdout] 93 | | Item::Fn(item) => Wit::Function(item), [INFO] [stdout] 94 | | Item::Struct(item) => Wit::Record(item), [INFO] [stdout] ... | [INFO] [stdout] 104 | | _ => bail!("cannot prase item"), [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 113 | fn try_from(item: proc_macro2::TokenStream) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | / if let Ok(file) = parse::(item.clone()) { [INFO] [stdout] 115 | | Ok(file.into()) [INFO] [stdout] 116 | | } else if let Ok(item) = parse::(item.clone()) { [INFO] [stdout] 117 | | Wit::try_from(item) [INFO] [stdout] ... | [INFO] [stdout] 122 | | ) [INFO] [stdout] 123 | | }? [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:18:36 [INFO] [stdout] | [INFO] [stdout] 18 | .for_each(|attr| match attr.parse_meta() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witgen_macro_helper` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub(crate) fn from_items(items: Vec) -> Vec { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | / items [INFO] [stdout] 33 | | .into_iter() [INFO] [stdout] 34 | | .filter_map(|item| item.try_into().ok()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | .filter_map(|item| item.try_into().ok()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 82 | fn from(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Wit::Mod(Wit::from_items(file.items), vec![]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 90 | fn try_from(item: Item) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | / match item { [INFO] [stdout] 92 | | Item::Enum(item) => Wit::Variant(item), [INFO] [stdout] 93 | | Item::Fn(item) => Wit::Function(item), [INFO] [stdout] 94 | | Item::Struct(item) => Wit::Record(item), [INFO] [stdout] ... | [INFO] [stdout] 104 | | _ => bail!("cannot prase item"), [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wit.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 113 | fn try_from(item: proc_macro2::TokenStream) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | / if let Ok(file) = parse::(item.clone()) { [INFO] [stdout] 115 | | Ok(file.into()) [INFO] [stdout] 116 | | } else if let Ok(item) = parse::(item.clone()) { [INFO] [stdout] 117 | | Wit::try_from(item) [INFO] [stdout] ... | [INFO] [stdout] 122 | | ) [INFO] [stdout] 123 | | }? [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:18:36 [INFO] [stdout] | [INFO] [stdout] 18 | .for_each(|attr| match attr.parse_meta() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `witgen_macro_helper` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1a0306d6deb8e336261046525027b92ff39e9da42f5f346766b17bbf8ffc95c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a0306d6deb8e336261046525027b92ff39e9da42f5f346766b17bbf8ffc95c4", kill_on_drop: false }` [INFO] [stdout] 1a0306d6deb8e336261046525027b92ff39e9da42f5f346766b17bbf8ffc95c4