[INFO] fetching crate wishbone-bridge 1.1.0... [INFO] checking wishbone-bridge-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wishbone-bridge 1.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate wishbone-bridge 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wishbone-bridge 1.1.0 [INFO] finished tweaking crates.io crate wishbone-bridge 1.1.0 [INFO] tweaked toml for crates.io crate wishbone-bridge 1.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.4.0 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.4.4 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding mach v0.1.2 (latest: v0.3.2) [INFO] [stderr] Adding mach v0.2.3 (latest: v0.3.2) [INFO] [stderr] Adding nix v0.14.1 (latest: v0.29.0) [INFO] [stderr] Adding rppal v0.11.3 (latest: v0.19.0) [INFO] [stderr] Adding serialport v3.3.0 (latest: v4.5.0) [INFO] [stderr] Adding spin_sleep v0.3.7 (latest: v1.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16bb2f88a245800dbb91230c23aee789dee1e96a5aaca2ce35e334d8e27e2fa4 [INFO] running `Command { std: "docker" "start" "-a" "16bb2f88a245800dbb91230c23aee789dee1e96a5aaca2ce35e334d8e27e2fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16bb2f88a245800dbb91230c23aee789dee1e96a5aaca2ce35e334d8e27e2fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16bb2f88a245800dbb91230c23aee789dee1e96a5aaca2ce35e334d8e27e2fa4", kill_on_drop: false }` [INFO] [stdout] 16bb2f88a245800dbb91230c23aee789dee1e96a5aaca2ce35e334d8e27e2fa4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 448c4b3cbe683efb9bb6a7cf59fa1d7d999bfd2100db08869a3a75432e9b81f0 [INFO] running `Command { std: "docker" "start" "-a" "448c4b3cbe683efb9bb6a7cf59fa1d7d999bfd2100db08869a3a75432e9b81f0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking bit-vec v0.4.4 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling libusb-sys-wishbone-tool v0.2.6 [INFO] [stderr] Checking bit-set v0.4.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking libusb-wishbone-tool v0.3.1 [INFO] [stderr] Checking serialport v3.3.0 [INFO] [stderr] Checking wishbone-bridge v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/ethernet.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 135 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let thr_cfg = cfg.clone(); [INFO] [stdout] 140 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(EthernetBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | cfg: cfg.clone(), [INFO] [stdout] 146 | | main_tx, [INFO] [stdout] 147 | | main_rx: cv, [INFO] [stdout] 148 | | mutex: Arc::new(Mutex::new(())), [INFO] [stdout] 149 | | poll_thread, [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/ethernet.rs:401:15 [INFO] [stdout] | [INFO] [stdout] 393 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/ethernet.rs:420:15 [INFO] [stdout] | [INFO] [stdout] 412 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/pcie.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 108 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let thr_path = path.clone(); [INFO] [stdout] 115 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(PCIeBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | path, [INFO] [stdout] 121 | | main_tx, [INFO] [stdout] 122 | | main_rx: cv, [INFO] [stdout] 123 | | mutex: Arc::new(Mutex::new(())), [INFO] [stdout] 124 | | poll_thread, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/pcie.rs:270:15 [INFO] [stdout] | [INFO] [stdout] 262 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/pcie.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 281 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/uart.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 85 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let thr_path = path.clone(); [INFO] [stdout] 93 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(UartBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | path, [INFO] [stdout] 99 | | baudrate, [INFO] [stdout] 100 | | main_tx, [INFO] [stdout] ... | [INFO] [stdout] 103 | | poll_thread, [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/uart.rs:305:15 [INFO] [stdout] | [INFO] [stdout] 297 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/uart.rs:324:15 [INFO] [stdout] | [INFO] [stdout] 316 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 119 | let usb_ctx = libusb_wishbone_tool::Context::new()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(UsbBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | usb_pid: cfg.pid, [INFO] [stdout] 131 | | usb_vid: cfg.vid, [INFO] [stdout] 132 | | main_tx, [INFO] [stdout] ... | [INFO] [stdout] 135 | | poll_thread, [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:530:15 [INFO] [stdout] | [INFO] [stdout] 522 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:549:15 [INFO] [stdout] | [INFO] [stdout] 541 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 549 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:568:15 [INFO] [stdout] | [INFO] [stdout] 560 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:588:15 [INFO] [stdout] | [INFO] [stdout] 579 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wishbone-bridge` (lib test) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/ethernet.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 135 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let thr_cfg = cfg.clone(); [INFO] [stdout] 140 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(EthernetBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | cfg: cfg.clone(), [INFO] [stdout] 146 | | main_tx, [INFO] [stdout] 147 | | main_rx: cv, [INFO] [stdout] 148 | | mutex: Arc::new(Mutex::new(())), [INFO] [stdout] 149 | | poll_thread, [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/ethernet.rs:401:15 [INFO] [stdout] | [INFO] [stdout] 393 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/ethernet.rs:420:15 [INFO] [stdout] | [INFO] [stdout] 412 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/pcie.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 108 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let thr_path = path.clone(); [INFO] [stdout] 115 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(PCIeBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | path, [INFO] [stdout] 121 | | main_tx, [INFO] [stdout] 122 | | main_rx: cv, [INFO] [stdout] 123 | | mutex: Arc::new(Mutex::new(())), [INFO] [stdout] 124 | | poll_thread, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/pcie.rs:270:15 [INFO] [stdout] | [INFO] [stdout] 262 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/pcie.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 281 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/uart.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 85 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let thr_path = path.clone(); [INFO] [stdout] 93 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(UartBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | path, [INFO] [stdout] 99 | | baudrate, [INFO] [stdout] 100 | | main_tx, [INFO] [stdout] ... | [INFO] [stdout] 103 | | poll_thread, [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/uart.rs:305:15 [INFO] [stdout] | [INFO] [stdout] 297 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/uart.rs:324:15 [INFO] [stdout] | [INFO] [stdout] 316 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 119 | let usb_ctx = libusb_wishbone_tool::Context::new()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let (main_tx, thread_rx) = channel(); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let cv = Arc::new((Mutex::new(None), Condvar::new())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let thr_cv = cv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let poll_thread = Some(thread::spawn(move || { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(UsbBridgeInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | usb_pid: cfg.pid, [INFO] [stdout] 131 | | usb_vid: cfg.vid, [INFO] [stdout] 132 | | main_tx, [INFO] [stdout] ... | [INFO] [stdout] 135 | | poll_thread, [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:530:15 [INFO] [stdout] | [INFO] [stdout] 522 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:549:15 [INFO] [stdout] | [INFO] [stdout] 541 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 549 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:568:15 [INFO] [stdout] | [INFO] [stdout] 560 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bridges/usb.rs:588:15 [INFO] [stdout] | [INFO] [stdout] 579 | let mut _mtx = lock.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | match _mtx.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wishbone-bridge` (lib) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "448c4b3cbe683efb9bb6a7cf59fa1d7d999bfd2100db08869a3a75432e9b81f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "448c4b3cbe683efb9bb6a7cf59fa1d7d999bfd2100db08869a3a75432e9b81f0", kill_on_drop: false }` [INFO] [stdout] 448c4b3cbe683efb9bb6a7cf59fa1d7d999bfd2100db08869a3a75432e9b81f0