[INFO] fetching crate wiresmith 0.4.3... [INFO] checking wiresmith-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wiresmith 0.4.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate wiresmith 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wiresmith 0.4.3 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate wiresmith 0.4.3 [INFO] tweaked toml for crates.io crate wiresmith 0.4.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate wiresmith 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28cfda8d3d8e245131c3bf6312ef796b7520db9f0fb4716fd98f6c6c3a4a03d2 [INFO] running `Command { std: "docker" "start" "-a" "28cfda8d3d8e245131c3bf6312ef796b7520db9f0fb4716fd98f6c6c3a4a03d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28cfda8d3d8e245131c3bf6312ef796b7520db9f0fb4716fd98f6c6c3a4a03d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28cfda8d3d8e245131c3bf6312ef796b7520db9f0fb4716fd98f6c6c3a4a03d2", kill_on_drop: false }` [INFO] [stdout] 28cfda8d3d8e245131c3bf6312ef796b7520db9f0fb4716fd98f6c6c3a4a03d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ba90a4d205a6d905c79c9d41a5a70bd1799b3a9dc383c1994a22a767ce643a3 [INFO] running `Command { std: "docker" "start" "-a" "6ba90a4d205a6d905c79c9d41a5a70bd1799b3a9dc383c1994a22a767ce643a3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling indexmap v2.3.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking pnet_base v0.35.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Compiling pnet v0.35.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking pnet_macros_support v0.35.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking roff v0.2.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking configparser v3.1.0 [INFO] [stderr] Checking port_check v0.2.1 [INFO] [stderr] Compiling rstest_macros v0.22.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking pnet_sys v0.35.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking rust-ini v0.21.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking file-owner v0.1.2 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking curve25519-dalek-fiat v0.1.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling pnet_macros v0.35.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking x25519-dalek-fiat v0.1.0 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking assert_fs v1.1.2 [INFO] [stderr] Checking pnet_packet v0.35.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking clap_complete v4.5.14 [INFO] [stderr] Checking clap_mangen v0.2.23 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.205 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.22.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking serde_json v1.0.122 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking wireguard-keys v0.1.1 [INFO] [stderr] Checking pnet_transport v0.35.0 [INFO] [stderr] Checking pnet_datalink v0.35.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking wiresmith v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consul.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(join_handle: JoinHandle<()>, token: CancellationToken) -> Self { [INFO] [stdout] | --------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self { [INFO] [stdout] 32 | join_handle: Some(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consul.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 150 | let client_builder = reqwest::Client::builder(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let client_builder = if let Some(secret_token) = consul_token { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let client = client_builder.build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | [INFO] [stdout] 164 | Ok(ConsulClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | http_client: client, [INFO] [stdout] 166 | | api_base_url: consul_address, [INFO] [stdout] 167 | | kv_api_base_url, [INFO] [stdout] 168 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consul.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 298 | client: ConsulClient, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | session_token: CancellationToken, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | parent_token: CancellationToken, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | Ok(async move { [INFO] [stdout] | ________^ [INFO] [stdout] 319 | | // Renew the session at 2 times the TTL. [INFO] [stdout] 320 | | let mut interval = interval(CONSUL_TTL / 2); [INFO] [stdout] 321 | | interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip); [INFO] [stdout] ... | [INFO] [stdout] 356 | | } [INFO] [stdout] 357 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wiresmith` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consul.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(join_handle: JoinHandle<()>, token: CancellationToken) -> Self { [INFO] [stdout] | --------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self { [INFO] [stdout] 32 | join_handle: Some(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consul.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 150 | let client_builder = reqwest::Client::builder(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let client_builder = if let Some(secret_token) = consul_token { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let client = client_builder.build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | [INFO] [stdout] 164 | Ok(ConsulClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | http_client: client, [INFO] [stdout] 166 | | api_base_url: consul_address, [INFO] [stdout] 167 | | kv_api_base_url, [INFO] [stdout] 168 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/consul.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 298 | client: ConsulClient, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | session_token: CancellationToken, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | parent_token: CancellationToken, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | Ok(async move { [INFO] [stdout] | ________^ [INFO] [stdout] 319 | | // Renew the session at 2 times the TTL. [INFO] [stdout] 320 | | let mut interval = interval(CONSUL_TTL / 2); [INFO] [stdout] 321 | | interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip); [INFO] [stdout] ... | [INFO] [stdout] 356 | | } [INFO] [stdout] 357 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wiresmith` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "6ba90a4d205a6d905c79c9d41a5a70bd1799b3a9dc383c1994a22a767ce643a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ba90a4d205a6d905c79c9d41a5a70bd1799b3a9dc383c1994a22a767ce643a3", kill_on_drop: false }` [INFO] [stdout] 6ba90a4d205a6d905c79c9d41a5a70bd1799b3a9dc383c1994a22a767ce643a3