[INFO] fetching crate wion 0.1.0... [INFO] checking wion-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wion 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate wion 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wion 0.1.0 [INFO] finished tweaking crates.io crate wion 0.1.0 [INFO] tweaked toml for crates.io crate wion 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be683d1782acc8999bdabd7d252b6e36846c946e31a5b2141bf26181730ba0c4 [INFO] running `Command { std: "docker" "start" "-a" "be683d1782acc8999bdabd7d252b6e36846c946e31a5b2141bf26181730ba0c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be683d1782acc8999bdabd7d252b6e36846c946e31a5b2141bf26181730ba0c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be683d1782acc8999bdabd7d252b6e36846c946e31a5b2141bf26181730ba0c4", kill_on_drop: false }` [INFO] [stdout] be683d1782acc8999bdabd7d252b6e36846c946e31a5b2141bf26181730ba0c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] befa71ab809c375bf1031599ffa2b4f0bb0d251696cae54f791d4aa9dded23b4 [INFO] running `Command { std: "docker" "start" "-a" "befa71ab809c375bf1031599ffa2b4f0bb0d251696cae54f791d4aa9dded23b4", kill_on_drop: false }` [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking wion v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Display` [INFO] [stdout] --> src/objects/flags/mod.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | fmt::{Debug, Display}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Display` [INFO] [stdout] --> src/objects/flags/mod.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | fmt::{Debug, Display}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/parser/mod.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | fn from_str(s: &str) -> Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser/mod.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn parse(text: &str) -> Result> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_text` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/values/display.rs:89:40 [INFO] [stdout] | [INFO] [stdout] 89 | fn indent_display(&self, f: &mut IndentFormatter<'_, W>) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `indent_text` and `level` are never read [INFO] [stdout] --> src/helpers/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) struct IndentFormatter<'a, W> { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 8 | pub writer: W, [INFO] [stdout] 9 | pub indent_text: &'a str, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 10 | pub level: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `indent`, `dedent`, and `newline` are never used [INFO] [stdout] --> src/helpers/mod.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl<'a, W: Write> IndentFormatter<'a, W> { [INFO] [stdout] | ----------------------------------------- methods in this implementation [INFO] [stdout] 27 | pub fn indent(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn dedent(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub fn newline(&mut self) -> std::fmt::Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `WasiPair` is never constructed [INFO] [stdout] --> src/values/mod.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct WasiPair { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WasiPair` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values/mod.rs:88:22 [INFO] [stdout] | [INFO] [stdout] 87 | fn from(value: WasiObject) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Self::Object(Arc::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values/mod.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn variant(name: N, values: I) -> Self [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Self { kind: WasiObjectKind::Variant { typing: name.into() }, terms: values.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values/mod.rs:106:78 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn variant(name: N, values: I) -> Self [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Self { kind: WasiObjectKind::Variant { typing: name.into() }, terms: values.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/parser/mod.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | fn from_str(s: &str) -> Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser/mod.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn parse(text: &str) -> Result> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_text` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/values/display.rs:89:40 [INFO] [stdout] | [INFO] [stdout] 89 | fn indent_display(&self, f: &mut IndentFormatter<'_, W>) -> std::fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wion` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `indent_text` and `level` are never read [INFO] [stdout] --> src/helpers/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) struct IndentFormatter<'a, W> { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 8 | pub writer: W, [INFO] [stdout] 9 | pub indent_text: &'a str, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 10 | pub level: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `indent`, `dedent`, and `newline` are never used [INFO] [stdout] --> src/helpers/mod.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl<'a, W: Write> IndentFormatter<'a, W> { [INFO] [stdout] | ----------------------------------------- methods in this implementation [INFO] [stdout] 27 | pub fn indent(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn dedent(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub fn newline(&mut self) -> std::fmt::Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `WasiPair` is never constructed [INFO] [stdout] --> src/values/mod.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct WasiPair { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WasiPair` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a variant [INFO] [stdout] --> src/errors/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | UnknownError, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | #![warn(missing_docs, rustdoc::missing_crate_level_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct field [INFO] [stdout] --> src/objects/flags/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub flags: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct field [INFO] [stdout] --> src/objects/flags/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub flags: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/parser/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn parse(text: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values/mod.rs:88:22 [INFO] [stdout] | [INFO] [stdout] 87 | fn from(value: WasiObject) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Self::Object(Arc::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values/mod.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn variant(name: N, values: I) -> Self [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Self { kind: WasiObjectKind::Variant { typing: name.into() }, terms: values.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values/mod.rs:106:78 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn variant(name: N, values: I) -> Self [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Self { kind: WasiObjectKind::Variant { typing: name.into() }, terms: values.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wion` (lib) due to 4 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "befa71ab809c375bf1031599ffa2b4f0bb0d251696cae54f791d4aa9dded23b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "befa71ab809c375bf1031599ffa2b4f0bb0d251696cae54f791d4aa9dded23b4", kill_on_drop: false }` [INFO] [stdout] befa71ab809c375bf1031599ffa2b4f0bb0d251696cae54f791d4aa9dded23b4