[INFO] fetching crate winmsg-executor 0.1.1... [INFO] checking winmsg-executor-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate winmsg-executor 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate winmsg-executor 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate winmsg-executor 0.1.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate winmsg-executor 0.1.1 [INFO] tweaked toml for crates.io crate winmsg-executor 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate winmsg-executor 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8dc0c233fd1242d5aacd744b6aeccfea9c3021479e35fccbaed7121ffd93be97 [INFO] running `Command { std: "docker" "start" "-a" "8dc0c233fd1242d5aacd744b6aeccfea9c3021479e35fccbaed7121ffd93be97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8dc0c233fd1242d5aacd744b6aeccfea9c3021479e35fccbaed7121ffd93be97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8dc0c233fd1242d5aacd744b6aeccfea9c3021479e35fccbaed7121ffd93be97", kill_on_drop: false }` [INFO] [stdout] 8dc0c233fd1242d5aacd744b6aeccfea9c3021479e35fccbaed7121ffd93be97 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c91af980abbf58fa6668aadad1e5585a501e85e2b3d442fc317c164f050fe681 [INFO] running `Command { std: "docker" "start" "-a" "c91af980abbf58fa6668aadad1e5585a501e85e2b3d442fc317c164f050fe681", kill_on_drop: false }` [INFO] [stderr] Compiling windows_x86_64_gnu v0.52.6 [INFO] [stderr] Checking windows-targets v0.52.6 [INFO] [stderr] Checking windows-sys v0.59.0 [INFO] [stderr] Checking winmsg-executor v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn block_on(future: F) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let task = backend::spawn(async move { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | poll_ready(task).map_err(|_| QuitMessageLoop) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/window.rs:85:57 [INFO] [stdout] | [INFO] [stdout] 78 | shared_state: S, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | wndproc: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let wndproc = RefCell::new(wndproc); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Self::new_reentrant(message_only, shared_state, move |state, msg| { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 86 | | // Detect when `wndproc` is re-entered, which can happen when the user [INFO] [stdout] 87 | | // provided handler creates a modal dialog (e.g. a popup-menu). Rust rules [INFO] [stdout] 88 | | // do not allow us to create a second mutable reference to the user provided [INFO] [stdout] ... | [INFO] [stdout] 91 | | wndproc(state, msg) [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/window.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 98 | shared_state: S, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | wndproc: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let user_data = Box::new((shared_state, wndproc)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 154 | | hwnd, [INFO] [stdout] 155 | | shared_state_ptr, [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn block_on(future: F) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let task = backend::spawn(async move { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | poll_ready(task).map_err(|_| QuitMessageLoop) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/window.rs:85:57 [INFO] [stdout] | [INFO] [stdout] 78 | shared_state: S, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | wndproc: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let wndproc = RefCell::new(wndproc); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Self::new_reentrant(message_only, shared_state, move |state, msg| { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 86 | | // Detect when `wndproc` is re-entered, which can happen when the user [INFO] [stdout] 87 | | // provided handler creates a modal dialog (e.g. a popup-menu). Rust rules [INFO] [stdout] 88 | | // do not allow us to create a second mutable reference to the user provided [INFO] [stdout] ... | [INFO] [stdout] 91 | | wndproc(state, msg) [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/window.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 98 | shared_state: S, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | wndproc: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let user_data = Box::new((shared_state, wndproc)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 154 | | hwnd, [INFO] [stdout] 155 | | shared_state_ptr, [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `winmsg-executor` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `winmsg-executor` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "c91af980abbf58fa6668aadad1e5585a501e85e2b3d442fc317c164f050fe681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c91af980abbf58fa6668aadad1e5585a501e85e2b3d442fc317c164f050fe681", kill_on_drop: false }` [INFO] [stdout] c91af980abbf58fa6668aadad1e5585a501e85e2b3d442fc317c164f050fe681