[INFO] fetching crate windsock 0.1.1... [INFO] checking windsock-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate windsock 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate windsock 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate windsock 0.1.1 [INFO] finished tweaking crates.io crate windsock 0.1.1 [INFO] tweaked toml for crates.io crate windsock 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate windsock 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec6cb43ee47cca79e21662fca062cf56b4e05e810b6c93bbc1af1d42f1f0b5fa [INFO] running `Command { std: "docker" "start" "-a" "ec6cb43ee47cca79e21662fca062cf56b4e05e810b6c93bbc1af1d42f1f0b5fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec6cb43ee47cca79e21662fca062cf56b4e05e810b6c93bbc1af1d42f1f0b5fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec6cb43ee47cca79e21662fca062cf56b4e05e810b6c93bbc1af1d42f1f0b5fa", kill_on_drop: false }` [INFO] [stdout] ec6cb43ee47cca79e21662fca062cf56b4e05e810b6c93bbc1af1d42f1f0b5fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d156805221084fa11198e71536885171b89ef23e731e5b15ca82a76561dc11e9 [INFO] running `Command { std: "docker" "start" "-a" "d156805221084fa11198e71536885171b89ef23e731e5b15ca82a76561dc11e9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling indexmap v2.2.5 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling tokio-openssl v0.6.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking lz4_flex v0.11.2 [INFO] [stderr] Compiling windsock v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling docker-compose-runner v0.3.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking copy_dir v0.1.3 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking arc-swap v1.7.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking histogram v0.6.9 [INFO] [stderr] Checking strum v0.23.0 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling strum_macros v0.23.1 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling num_enum_derive v0.6.1 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking num_enum v0.6.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Compiling scylla-macros v0.4.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking scylla-cql v0.1.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_yaml v0.9.32 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking scylla v0.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 44 | / benches: Vec< [INFO] [stdout] 45 | | Box>, [INFO] [stdout] 46 | | >, [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / cloud: Box< [INFO] [stdout] 48 | | dyn Cloud, [INFO] [stdout] 49 | | >, [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | benches: benches.into_iter().map(BenchState::new).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:64:15 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn run(self) -> ! { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | match self.run_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 201 | let mut bench_infos = vec![]; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Ok(self.cloud.order_benches(bench_infos)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 323 | let mut runtime_builder = tokio::runtime::Builder::new_multi_thread(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | runtime_builder.build().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench.rs:305:30 [INFO] [stdout] | [INFO] [stdout] 303 | reporter: UnboundedSender, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | operations_per_second: Option, [INFO] [stdout] 305 | ) -> Vec> { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 306 | | let mut tasks = vec![]; [INFO] [stdout] 307 | | // 100 is a generally nice amount of tasks to have, but if we have more tasks than OPS the throughput is very unstable [INFO] [stdout] 308 | | let task_count = operations_per_second.map(|x| x.min(100)).unwrap_or(100); [INFO] [stdout] ... | [INFO] [stdout] 345 | | tasks [INFO] [stdout] 346 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:299:17 [INFO] [stdout] | [INFO] [stdout] 298 | .map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | x.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 160 | .fold(HashSet::new(), |acc, x| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | acc.union( [INFO] [stdout] 162 | &x.current [INFO] [stdout] | __________________^ [INFO] [stdout] 163 | | .tags [INFO] [stdout] 164 | | .keys() [INFO] [stdout] 165 | | .difference(&intersection_keys) [INFO] [stdout] 166 | | .cloned() [INFO] [stdout] 167 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `windsock` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d156805221084fa11198e71536885171b89ef23e731e5b15ca82a76561dc11e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d156805221084fa11198e71536885171b89ef23e731e5b15ca82a76561dc11e9", kill_on_drop: false }` [INFO] [stdout] d156805221084fa11198e71536885171b89ef23e731e5b15ca82a76561dc11e9