[INFO] fetching crate windows-metadata 0.58.0... [INFO] checking windows-metadata-0.58.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate windows-metadata 0.58.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate windows-metadata 0.58.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate windows-metadata 0.58.0 [INFO] finished tweaking crates.io crate windows-metadata 0.58.0 [INFO] tweaked toml for crates.io crate windows-metadata 0.58.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eea37d48cd7da7e90f0ac589c6def049ae9b3b5fff22d4f0b62c2e69ca1f330d [INFO] running `Command { std: "docker" "start" "-a" "eea37d48cd7da7e90f0ac589c6def049ae9b3b5fff22d4f0b62c2e69ca1f330d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eea37d48cd7da7e90f0ac589c6def049ae9b3b5fff22d4f0b62c2e69ca1f330d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eea37d48cd7da7e90f0ac589c6def049ae9b3b5fff22d4f0b62c2e69ca1f330d", kill_on_drop: false }` [INFO] [stdout] eea37d48cd7da7e90f0ac589c6def049ae9b3b5fff22d4f0b62c2e69ca1f330d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ced6c54b6faa11a5c76b6636be2e0b552b45cb9d7ec6bb914e3c3d6ef787dcb [INFO] running `Command { std: "docker" "start" "-a" "9ced6c54b6faa11a5c76b6636be2e0b552b45cb9d7ec6bb914e3c3d6ef787dcb", kill_on_drop: false }` [INFO] [stderr] Checking windows-metadata v0.58.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:244:21 [INFO] [stdout] | [INFO] [stdout] 239 | let return_type = reader.type_from_blob(&mut blob, None, &[]); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | params: (0..params) [INFO] [stdout] | _____________________^ [INFO] [stdout] 245 | | .map(|_| reader.type_from_blob(&mut blob, None, &[])) [INFO] [stdout] 246 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:287:21 [INFO] [stdout] | [INFO] [stdout] 282 | let return_type = reader.type_from_blob(&mut blob, None, generics); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | params: (0..params) [INFO] [stdout] | _____________________^ [INFO] [stdout] 288 | | .map(|_| reader.type_from_blob(&mut blob, None, generics)) [INFO] [stdout] 289 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:401:38 [INFO] [stdout] | [INFO] [stdout] 401 | .map(|field| field.ty(Some(*self)).size()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:425:30 [INFO] [stdout] | [INFO] [stdout] 425 | .map(|field| field.ty(Some(*self)).align()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:244:21 [INFO] [stdout] | [INFO] [stdout] 239 | let return_type = reader.type_from_blob(&mut blob, None, &[]); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | params: (0..params) [INFO] [stdout] | _____________________^ [INFO] [stdout] 245 | | .map(|_| reader.type_from_blob(&mut blob, None, &[])) [INFO] [stdout] 246 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:287:21 [INFO] [stdout] | [INFO] [stdout] 282 | let return_type = reader.type_from_blob(&mut blob, None, generics); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | params: (0..params) [INFO] [stdout] | _____________________^ [INFO] [stdout] 288 | | .map(|_| reader.type_from_blob(&mut blob, None, generics)) [INFO] [stdout] 289 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:401:38 [INFO] [stdout] | [INFO] [stdout] 401 | .map(|field| field.ty(Some(*self)).size()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tables.rs:425:30 [INFO] [stdout] | [INFO] [stdout] 425 | .map(|field| field.ty(Some(*self)).align()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `windows-metadata` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `windows-metadata` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "9ced6c54b6faa11a5c76b6636be2e0b552b45cb9d7ec6bb914e3c3d6ef787dcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ced6c54b6faa11a5c76b6636be2e0b552b45cb9d7ec6bb914e3c3d6ef787dcb", kill_on_drop: false }` [INFO] [stdout] 9ced6c54b6faa11a5c76b6636be2e0b552b45cb9d7ec6bb914e3c3d6ef787dcb