[INFO] fetching crate win_desktop_duplication 0.10.11... [INFO] checking win_desktop_duplication-0.10.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate win_desktop_duplication 0.10.11 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate win_desktop_duplication 0.10.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate win_desktop_duplication 0.10.11 [INFO] finished tweaking crates.io crate win_desktop_duplication 0.10.11 [INFO] tweaked toml for crates.io crate win_desktop_duplication 0.10.11 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-implement v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-interface v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9190c55d340d9a019731911546141c71c53ff0d13f926dce290775a7624c3616 [INFO] running `Command { std: "docker" "start" "-a" "9190c55d340d9a019731911546141c71c53ff0d13f926dce290775a7624c3616", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9190c55d340d9a019731911546141c71c53ff0d13f926dce290775a7624c3616", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9190c55d340d9a019731911546141c71c53ff0d13f926dce290775a7624c3616", kill_on_drop: false }` [INFO] [stdout] 9190c55d340d9a019731911546141c71c53ff0d13f926dce290775a7624c3616 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6cdf3626edc97b0c3f2678ef4ea839fc5e0ae39e878da3a7af4411e206ca212d [INFO] running `Command { std: "docker" "start" "-a" "6cdf3626edc97b0c3f2678ef4ea839fc5e0ae39e878da3a7af4411e206ca212d", kill_on_drop: false }` [INFO] [stderr] Compiling windows_x86_64_gnu v0.52.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling windows-interface v0.57.0 [INFO] [stderr] Compiling windows-implement v0.57.0 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking windows-targets v0.52.6 [INFO] [stderr] Checking windows-result v0.1.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking windows-core v0.57.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking windows v0.57.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking win_desktop_duplication v0.10.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `DXGI_ADAPTER_DESC` [INFO] [stdout] --> src/devices.rs:6:58 [INFO] [stdout] | [INFO] [stdout] 6 | use windows::Win32::Graphics::Dxgi::{CreateDXGIFactory2, DXGI_ADAPTER_DESC, DXGI_ADAPTER_DESC3, DXGI_GPU_PREFERENCE_HIGH_PERFORMANCE, IDX... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `swap` [INFO] [stdout] --> src/outputs.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | use std::mem::{size_of, swap}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `null_mut` and `null` [INFO] [stdout] --> src/outputs.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ptr::{null, null_mut}; [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError`, and `channel` [INFO] [stdout] --> src/outputs.rs:11:23 [INFO] [stdout] | [INFO] [stdout] 11 | use std::sync::mpsc::{channel, Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Waker` [INFO] [stdout] --> src/outputs.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | use std::task::{Context, Poll, Waker}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error` [INFO] [stdout] --> src/outputs.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | use log::{error, trace}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Result as WinResult` [INFO] [stdout] --> src/outputs.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | use windows::core::{PCSTR, Result as WinResult}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ptr::null` [INFO] [stdout] --> src/duplication.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::ptr::null; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/duplication.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::time` [INFO] [stdout] --> src/duplication.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use tokio::time; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Interval`, `MissedTickBehavior`, and `sleep` [INFO] [stdout] --> src/duplication.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | use tokio::time::{Interval, MissedTickBehavior, sleep}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DXGI_ADAPTER_DESC` [INFO] [stdout] --> src/devices.rs:6:58 [INFO] [stdout] | [INFO] [stdout] 6 | use windows::Win32::Graphics::Dxgi::{CreateDXGIFactory2, DXGI_ADAPTER_DESC, DXGI_ADAPTER_DESC3, DXGI_GPU_PREFERENCE_HIGH_PERFORMANCE, IDX... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `swap` [INFO] [stdout] --> src/outputs.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | use std::mem::{size_of, swap}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `null_mut` and `null` [INFO] [stdout] --> src/outputs.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ptr::{null, null_mut}; [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError`, and `channel` [INFO] [stdout] --> src/outputs.rs:11:23 [INFO] [stdout] | [INFO] [stdout] 11 | use std::sync::mpsc::{channel, Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Waker` [INFO] [stdout] --> src/outputs.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | use std::task::{Context, Poll, Waker}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error` [INFO] [stdout] --> src/outputs.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 17 | use log::{error, trace}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Result as WinResult` [INFO] [stdout] --> src/outputs.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | use windows::core::{PCSTR, Result as WinResult}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ptr::null` [INFO] [stdout] --> src/duplication.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::ptr::null; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/duplication.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::time` [INFO] [stdout] --> src/duplication.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use tokio::time; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Interval`, `MissedTickBehavior`, and `sleep` [INFO] [stdout] --> src/duplication.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | use tokio::time::{Interval, MissedTickBehavior, sleep}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/outputs.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread_handle` is never read [INFO] [stdout] --> src/outputs.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 354 | pub struct DisplayVSyncStream { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 355 | sync_rx: tokio::sync::mpsc::Receiver>, [INFO] [stdout] 356 | thread_handle: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/outputs.rs:387:28 [INFO] [stdout] | [INFO] [stdout] 365 | pub fn new(output: Display) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let (sync_tx, sync_rx) = tokio::sync::mpsc::channel::>(1); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | // the thread auto stops when this object goes out of scope. [INFO] [stdout] 368 | let thread_handle = spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | thread_handle: Some(Box::new(thread_handle)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplication.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new_with(d3d_device: ID3D11Device4, ctx: ID3D11DeviceContext4, output: Display) -> Result { [INFO] [stdout] | ------------------------- ------------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let dupl = Self::create_dupl_output(&d3d_device, &output)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 243 | | d3d_device, [INFO] [stdout] 244 | | d3d_ctx: ctx, [INFO] [stdout] 245 | | vsync_stream: output.get_vsync_stream(), [INFO] [stdout] ... | [INFO] [stdout] 249 | | state: Default::default(), [INFO] [stdout] 250 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplication.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 306 | let device: IDXGIDevice4 = dev.cast().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | let dupl: WinResult = unsafe { output.as_raw_ref().DuplicateOutput1(&device, 0, &supported_formats) }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Ok(dupl.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `BOOL` that must be used [INFO] [stdout] --> src/duplication.rs:487:22 [INFO] [stdout] | [INFO] [stdout] 487 | unsafe { DeleteObject(icon_info.hbmMask); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 487 | unsafe { let _ = DeleteObject(icon_info.hbmMask); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/outputs.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `BOOL` that must be used [INFO] [stdout] --> src/duplication.rs:490:22 [INFO] [stdout] | [INFO] [stdout] 490 | unsafe { DeleteObject(icon_info.hbmColor); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 490 | unsafe { let _ = DeleteObject(icon_info.hbmColor); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/utils.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / SetProcessDpiAwarenessContext( [INFO] [stdout] 22 | | DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2, [INFO] [stdout] 23 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 21 | let _ = SetProcessDpiAwarenessContext( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/texture.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(tex: ID3D11Texture2D) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | desc: Arc::new(RwLock::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tex_reader.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(device: ID3D11Device4, ctx: ID3D11DeviceContext4) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | tex: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `win_desktop_duplication` (lib) due to 6 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `thread_handle` is never read [INFO] [stdout] --> src/outputs.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 354 | pub struct DisplayVSyncStream { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 355 | sync_rx: tokio::sync::mpsc::Receiver>, [INFO] [stdout] 356 | thread_handle: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/outputs.rs:387:28 [INFO] [stdout] | [INFO] [stdout] 365 | pub fn new(output: Display) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let (sync_tx, sync_rx) = tokio::sync::mpsc::channel::>(1); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | // the thread auto stops when this object goes out of scope. [INFO] [stdout] 368 | let thread_handle = spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | thread_handle: Some(Box::new(thread_handle)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplication.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn new_with(d3d_device: ID3D11Device4, ctx: ID3D11DeviceContext4, output: Display) -> Result { [INFO] [stdout] | ------------------------- ------------------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let dupl = Self::create_dupl_output(&d3d_device, &output)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 243 | | d3d_device, [INFO] [stdout] 244 | | d3d_ctx: ctx, [INFO] [stdout] 245 | | vsync_stream: output.get_vsync_stream(), [INFO] [stdout] ... | [INFO] [stdout] 249 | | state: Default::default(), [INFO] [stdout] 250 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplication.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 306 | let device: IDXGIDevice4 = dev.cast().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | let dupl: WinResult = unsafe { output.as_raw_ref().DuplicateOutput1(&device, 0, &supported_formats) }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Ok(dupl.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `BOOL` that must be used [INFO] [stdout] --> src/duplication.rs:487:22 [INFO] [stdout] | [INFO] [stdout] 487 | unsafe { DeleteObject(icon_info.hbmMask); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 487 | unsafe { let _ = DeleteObject(icon_info.hbmMask); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `BOOL` that must be used [INFO] [stdout] --> src/duplication.rs:490:22 [INFO] [stdout] | [INFO] [stdout] 490 | unsafe { DeleteObject(icon_info.hbmColor); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 490 | unsafe { let _ = DeleteObject(icon_info.hbmColor); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/utils.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / SetProcessDpiAwarenessContext( [INFO] [stdout] 22 | | DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2, [INFO] [stdout] 23 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 21 | let _ = SetProcessDpiAwarenessContext( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/texture.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(tex: ID3D11Texture2D) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | desc: Arc::new(RwLock::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tex_reader.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(device: ID3D11Device4, ctx: ID3D11DeviceContext4) -> Self { [INFO] [stdout] | --------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | tex: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `win_desktop_duplication` (lib test) due to 6 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6cdf3626edc97b0c3f2678ef4ea839fc5e0ae39e878da3a7af4411e206ca212d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cdf3626edc97b0c3f2678ef4ea839fc5e0ae39e878da3a7af4411e206ca212d", kill_on_drop: false }` [INFO] [stdout] 6cdf3626edc97b0c3f2678ef4ea839fc5e0ae39e878da3a7af4411e206ca212d