[INFO] fetching crate wikitext_table_parser 0.3.1... [INFO] checking wikitext_table_parser-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wikitext_table_parser 0.3.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate wikitext_table_parser 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wikitext_table_parser 0.3.1 [INFO] finished tweaking crates.io crate wikitext_table_parser 0.3.1 [INFO] tweaked toml for crates.io crate wikitext_table_parser 0.3.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate wikitext_table_parser 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afce10bd9649ef7fb554a8254af74b02cbdd1500c2306b13ada7b71b54b7d2bb [INFO] running `Command { std: "docker" "start" "-a" "afce10bd9649ef7fb554a8254af74b02cbdd1500c2306b13ada7b71b54b7d2bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afce10bd9649ef7fb554a8254af74b02cbdd1500c2306b13ada7b71b54b7d2bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afce10bd9649ef7fb554a8254af74b02cbdd1500c2306b13ada7b71b54b7d2bb", kill_on_drop: false }` [INFO] [stdout] afce10bd9649ef7fb554a8254af74b02cbdd1500c2306b13ada7b71b54b7d2bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d2a719155b055fbd9fd0e59301793e2f2864aedd1b5c43feb9351565f00b5af [INFO] running `Command { std: "docker" "start" "-a" "6d2a719155b055fbd9fd0e59301793e2f2864aedd1b5c43feb9351565f00b5af", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.14 [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling pyo3-build-config v0.21.2 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling pyo3-ffi v0.21.2 [INFO] [stderr] Compiling pyo3 v0.21.2 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling pyo3-macros-backend v0.21.2 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling pyo3-macros v0.21.2 [INFO] [stderr] Checking wikitext_table_parser v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `pyo3::deprecations::GilRefs::::function_arg`: use `&Bound<'_, T>` instead for this function argument [INFO] [stdout] --> src/lib.rs:8:39 [INFO] [stdout] | [INFO] [stdout] 8 | fn wikitext_table_parser(_py: Python, m: &PyModule) -> PyResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cell_text` is never read [INFO] [stdout] --> src/parser.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let mut cell_text = String::new(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `style` [INFO] [stdout] --> src/parser.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let style: String = split_texts[0].clone(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_style` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cell_text` [INFO] [stdout] --> src/parser.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | let cell_text = split_texts[1].clone(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cell_text` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser.rs:326:61 [INFO] [stdout] | [INFO] [stdout] 326 | (State::ReadTableCaption, Event::TableCaption { text }) => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `text: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cell_type` [INFO] [stdout] --> src/parser.rs:338:48 [INFO] [stdout] | [INFO] [stdout] 338 | (State::ReadRow, Event::ColStart { cell_type }) => self.state = State::ReadCol, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `cell_type: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser.rs:341:48 [INFO] [stdout] | [INFO] [stdout] 341 | (State::ReadCol, Event::ColStyle { text }) => {} [INFO] [stdout] | ^^^^ help: try ignoring the field: `text: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser.rs:342:46 [INFO] [stdout] | [INFO] [stdout] 342 | (State::ReadCol, Event::ColEnd { text }) => self.state = State::ReadCol, [INFO] [stdout] | ^^^^ help: try ignoring the field: `text: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `pyo3::deprecations::GilRefs::::function_arg`: use `&Bound<'_, T>` instead for this function argument [INFO] [stdout] --> src/lib.rs:8:39 [INFO] [stdout] | [INFO] [stdout] 8 | fn wikitext_table_parser(_py: Python, m: &PyModule) -> PyResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `table_tokenizer` and `clean_cell_text` are never read [INFO] [stdout] --> src/parser.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub struct WikitextTableParser { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | table_tokenizer: Tokenizer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 51 | cell_tokenizer: Tokenizer, [INFO] [stdout] 52 | clean_cell_text: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WikitextTableParser` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | TableStyle { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | ColStart { cell_type: CellType }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | ColStyle { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | ColEnd { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | TableCaption { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | RowStyle { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wikitext_table_parser` (lib) due to 7 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: value assigned to `cell_text` is never read [INFO] [stdout] --> src/parser.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let mut cell_text = String::new(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `style` [INFO] [stdout] --> src/parser.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let style: String = split_texts[0].clone(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_style` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cell_text` [INFO] [stdout] --> src/parser.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | let cell_text = split_texts[1].clone(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cell_text` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser.rs:326:61 [INFO] [stdout] | [INFO] [stdout] 326 | (State::ReadTableCaption, Event::TableCaption { text }) => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `text: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cell_type` [INFO] [stdout] --> src/parser.rs:338:48 [INFO] [stdout] | [INFO] [stdout] 338 | (State::ReadRow, Event::ColStart { cell_type }) => self.state = State::ReadCol, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `cell_type: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser.rs:341:48 [INFO] [stdout] | [INFO] [stdout] 341 | (State::ReadCol, Event::ColStyle { text }) => {} [INFO] [stdout] | ^^^^ help: try ignoring the field: `text: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/parser.rs:342:46 [INFO] [stdout] | [INFO] [stdout] 342 | (State::ReadCol, Event::ColEnd { text }) => self.state = State::ReadCol, [INFO] [stdout] | ^^^^ help: try ignoring the field: `text: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `table_tokenizer` and `clean_cell_text` are never read [INFO] [stdout] --> src/parser.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub struct WikitextTableParser { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | table_tokenizer: Tokenizer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 51 | cell_tokenizer: Tokenizer, [INFO] [stdout] 52 | clean_cell_text: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WikitextTableParser` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | TableStyle { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | ColStart { cell_type: CellType }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | ColStyle { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | ColEnd { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | TableCaption { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | RowStyle { text: String }, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wikitext_table_parser` (lib test) due to 7 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6d2a719155b055fbd9fd0e59301793e2f2864aedd1b5c43feb9351565f00b5af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d2a719155b055fbd9fd0e59301793e2f2864aedd1b5c43feb9351565f00b5af", kill_on_drop: false }` [INFO] [stdout] 6d2a719155b055fbd9fd0e59301793e2f2864aedd1b5c43feb9351565f00b5af