[INFO] fetching crate wfh 0.1.0... [INFO] checking wfh-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wfh 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate wfh 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wfh 0.1.0 [INFO] finished tweaking crates.io crate wfh 0.1.0 [INFO] tweaked toml for crates.io crate wfh 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate wfh 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dbd0ac84ff99b8c5b11acca7812553b9cb172c8316566a08cd66e09a31e69ab1 [INFO] running `Command { std: "docker" "start" "-a" "dbd0ac84ff99b8c5b11acca7812553b9cb172c8316566a08cd66e09a31e69ab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dbd0ac84ff99b8c5b11acca7812553b9cb172c8316566a08cd66e09a31e69ab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbd0ac84ff99b8c5b11acca7812553b9cb172c8316566a08cd66e09a31e69ab1", kill_on_drop: false }` [INFO] [stdout] dbd0ac84ff99b8c5b11acca7812553b9cb172c8316566a08cd66e09a31e69ab1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9e6a7a010bc48c4f21fbba75ba84c1372459a6b86e59974a68a67b324bf07cae [INFO] running `Command { std: "docker" "start" "-a" "9e6a7a010bc48c4f21fbba75ba84c1372459a6b86e59974a68a67b324bf07cae", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking regex-syntax v0.6.13 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling nix v0.16.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking bstr v0.2.10 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking filetime v0.2.8 [INFO] [stderr] Checking inotify v0.7.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.15 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking globset v0.4.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking ignore v0.4.11 [INFO] [stderr] Compiling syn-mid v0.4.0 [INFO] [stderr] Compiling rustversion v1.0.1 [INFO] [stderr] Compiling proc-macro-error v0.4.4 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.3 [INFO] [stderr] Compiling structopt-derive v0.4.0 [INFO] [stderr] Checking structopt v0.3.7 [INFO] [stderr] Checking wfh v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/app.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 119 | / loop { [INFO] [stdout] 120 | | match rx.recv_timeout(Duration::from_millis(1000)) { [INFO] [stdout] 121 | | Ok(event) => { [INFO] [stdout] 122 | | self.find_dir_to_sync(&event) [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 137 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/app.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 119 | / loop { [INFO] [stdout] 120 | | match rx.recv_timeout(Duration::from_millis(1000)) { [INFO] [stdout] 121 | | Ok(event) => { [INFO] [stdout] 122 | | self.find_dir_to_sync(&event) [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 137 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `reset_pbar` is never used [INFO] [stdout] --> src/pbar.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn reset_pbar(n: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_pbar` is never used [INFO] [stdout] --> src/pbar.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn print_pbar(dirs: &Vec, s: &str) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:77:48 [INFO] [stdout] | [INFO] [stdout] 77 | .find(|dir| edited.starts_with(dir.canonicalize().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 198 | let mut rsync = Command::new("rsync"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | self.spawn_and_wait(&mut rsync).map(|_exit| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `reset_pbar` is never used [INFO] [stdout] --> src/pbar.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn reset_pbar(n: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_pbar` is never used [INFO] [stdout] --> src/pbar.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn print_pbar(dirs: &Vec, s: &str) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wfh` (bin "wfh" test) due to 3 previous errors; 4 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:77:48 [INFO] [stdout] | [INFO] [stdout] 77 | .find(|dir| edited.starts_with(dir.canonicalize().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 198 | let mut rsync = Command::new("rsync"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | self.spawn_and_wait(&mut rsync).map(|_exit| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wfh` (bin "wfh") due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9e6a7a010bc48c4f21fbba75ba84c1372459a6b86e59974a68a67b324bf07cae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e6a7a010bc48c4f21fbba75ba84c1372459a6b86e59974a68a67b324bf07cae", kill_on_drop: false }` [INFO] [stdout] 9e6a7a010bc48c4f21fbba75ba84c1372459a6b86e59974a68a67b324bf07cae