[INFO] fetching crate wendy-k8-metadata-client 3.3.1... [INFO] checking wendy-k8-metadata-client-3.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wendy-k8-metadata-client 3.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate wendy-k8-metadata-client 3.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wendy-k8-metadata-client 3.3.1 [INFO] finished tweaking crates.io crate wendy-k8-metadata-client 3.3.1 [INFO] tweaked toml for crates.io crate wendy-k8-metadata-client 3.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding k8-types v0.5.3 (latest: v0.8.7) [INFO] [stderr] Adding serde_qs v0.8.5 (latest: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86096db84d975506cc6fab2fee83da0b691ee19a6572d495a67b3b772b5af83e [INFO] running `Command { std: "docker" "start" "-a" "86096db84d975506cc6fab2fee83da0b691ee19a6572d495a67b3b772b5af83e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86096db84d975506cc6fab2fee83da0b691ee19a6572d495a67b3b772b5af83e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86096db84d975506cc6fab2fee83da0b691ee19a6572d495a67b3b772b5af83e", kill_on_drop: false }` [INFO] [stdout] 86096db84d975506cc6fab2fee83da0b691ee19a6572d495a67b3b772b5af83e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 62071d3d32c2c18e9552dde2e8bbac6b6e9f2a05ff76ccb8accee5b4745b3f6e [INFO] running `Command { std: "docker" "start" "-a" "62071d3d32c2c18e9552dde2e8bbac6b6e9f2a05ff76ccb8accee5b4745b3f6e", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_qs v0.8.5 [INFO] [stderr] Checking k8-diff v0.1.2 [INFO] [stderr] Checking k8-types v0.5.3 [INFO] [stderr] Checking wendy-k8-metadata-client v3.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn as_token_stream_result(events: Vec>) -> TokenStreamResult [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(events.into_iter().map(|event| Ok(event)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 119 | namespace: N, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / { [INFO] [stdout] 125 | | self.retrieve_items_with_option(namespace, None).await [INFO] [stdout] 126 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 182 | value: InputK8Obj, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | / { [INFO] [stdout] 188 | | debug!("{}: applying '{}' changes", S::label(), value.metadata.name); [INFO] [stdout] 189 | | trace!("{}: applying {:#?}", S::label(), value); [INFO] [stdout] 190 | | match self.retrieve_item(&value.metadata).await { [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 289 | let ft_stream = async move { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | ft_stream.flatten_stream().boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:301:40 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|item| Ok(K8Watch::ADDED(item))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nothing.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 94 | _namespace: N, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / { [INFO] [stdout] 101 | | Err(DoNothingError::NotFound) as Result, Self::MetadataClientError> [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nothing.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 131 | _value: InputK8Obj, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / { [INFO] [stdout] 138 | | Err(DoNothingError::NotFound) as Result, Self::MetadataClientError> [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn as_token_stream_result(events: Vec>) -> TokenStreamResult [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(events.into_iter().map(|event| Ok(event)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 119 | namespace: N, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / { [INFO] [stdout] 125 | | self.retrieve_items_with_option(namespace, None).await [INFO] [stdout] 126 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 182 | value: InputK8Obj, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | / { [INFO] [stdout] 188 | | debug!("{}: applying '{}' changes", S::label(), value.metadata.name); [INFO] [stdout] 189 | | trace!("{}: applying {:#?}", S::label(), value); [INFO] [stdout] 190 | | match self.retrieve_item(&value.metadata).await { [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 289 | let ft_stream = async move { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | ft_stream.flatten_stream().boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:301:40 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|item| Ok(K8Watch::ADDED(item))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nothing.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 94 | _namespace: N, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / { [INFO] [stdout] 101 | | Err(DoNothingError::NotFound) as Result, Self::MetadataClientError> [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nothing.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 131 | _value: InputK8Obj, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / { [INFO] [stdout] 138 | | Err(DoNothingError::NotFound) as Result, Self::MetadataClientError> [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wendy-k8-metadata-client` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `wendy-k8-metadata-client` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "62071d3d32c2c18e9552dde2e8bbac6b6e9f2a05ff76ccb8accee5b4745b3f6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62071d3d32c2c18e9552dde2e8bbac6b6e9f2a05ff76ccb8accee5b4745b3f6e", kill_on_drop: false }` [INFO] [stdout] 62071d3d32c2c18e9552dde2e8bbac6b6e9f2a05ff76ccb8accee5b4745b3f6e