[INFO] fetching crate welds-sqlx-mssql 1.7.0... [INFO] checking welds-sqlx-mssql-1.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate welds-sqlx-mssql 1.7.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate welds-sqlx-mssql 1.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate welds-sqlx-mssql 1.7.0 [INFO] finished tweaking crates.io crate welds-sqlx-mssql 1.7.0 [INFO] tweaked toml for crates.io crate welds-sqlx-mssql 1.7.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 129 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding der v0.6.1 (latest: v0.7.9) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding pem-rfc7468 v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding pkcs1 v0.4.1 (latest: v0.7.5) [INFO] [stderr] Adding pkcs8 v0.9.0 (latest: v0.10.2) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding rsa v0.8.2 (latest: v0.9.6) [INFO] [stderr] Adding spki v0.6.0 (latest: v0.7.3) [INFO] [stderr] Adding sqlx-core v0.7.4 (latest: v0.8.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1e8f94741db1b799af4bbfd142b18d908d59acc497aa570dda8cb1018f553ca [INFO] running `Command { std: "docker" "start" "-a" "f1e8f94741db1b799af4bbfd142b18d908d59acc497aa570dda8cb1018f553ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1e8f94741db1b799af4bbfd142b18d908d59acc497aa570dda8cb1018f553ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1e8f94741db1b799af4bbfd142b18d908d59acc497aa570dda8cb1018f553ca", kill_on_drop: false }` [INFO] [stdout] f1e8f94741db1b799af4bbfd142b18d908d59acc497aa570dda8cb1018f553ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4604e5652bb32f749f55dbb24ca256b65eb7d162af17f801056d1e48e5588193 [INFO] running `Command { std: "docker" "start" "-a" "4604e5652bb32f749f55dbb24ca256b65eb7d162af17f801056d1e48e5588193", kill_on_drop: false }` [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking pem-rfc7468 v0.6.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking pkcs1 v0.4.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sqlformat v0.2.4 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking rsa v0.8.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking sqlx-core v0.7.4 [INFO] [stderr] Checking welds-sqlx-mssql v1.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `TlsConfig` and `self` [INFO] [stdout] --> src/connection/tls.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::net::tls::{self, TlsConfig}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SocketIntoBox` [INFO] [stdout] --> src/connection/tls.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::net::{Socket, SocketIntoBox, WithSocket}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MssqlSslMode` [INFO] [stdout] --> src/connection/tls.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::{MssqlConnectOptions, MssqlSslMode}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TlsConfig` and `self` [INFO] [stdout] --> src/connection/tls.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::net::tls::{self, TlsConfig}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SocketIntoBox` [INFO] [stdout] --> src/connection/tls.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::net::{Socket, SocketIntoBox, WithSocket}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MssqlSslMode` [INFO] [stdout] --> src/connection/tls.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::{MssqlConnectOptions, MssqlSslMode}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/connection/tls.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | options: &MssqlConnectOptions, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection/tls.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | mut socket: S, [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `options` [INFO] [stdout] --> src/connection/tls.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | options: &MssqlConnectOptions, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_options` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection/tls.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | mut socket: S, [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ssl_mode`, `ssl_root_cert`, `ssl_client_cert`, and `ssl_client_key` are never read [INFO] [stdout] --> src/options/mod.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct MssqlConnectOptions { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub(crate) ssl_mode: MssqlSslMode, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub(crate) ssl_root_cert: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 19 | pub(crate) ssl_client_cert: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 20 | pub(crate) ssl_client_key: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MssqlConnectOptions` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/protocol/message.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | LoginAck(LoginAck), [INFO] [stdout] | -------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Message` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 12 | LoginAck(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/protocol/message.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | ReturnStatus(ReturnStatus), [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Message` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 17 | ReturnStatus(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/protocol/message.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | Order(Order), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Message` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 19 | Order(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 37 | fn close(mut self) -> BoxFuture<'static, Result<(), Error>> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 39 | | self.stream.shutdown().await?; [INFO] [stdout] 40 | | Ok(()) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 44 | fn close_hard(mut self) -> BoxFuture<'static, Result<(), Error>> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 46 | | self.stream.shutdown().await?; [INFO] [stdout] 47 | | Ok(()) [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 138 | query: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut s = self.fetch_many(query); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 147 | | while let Some(v) = s.try_next().await? { [INFO] [stdout] 148 | | if let Either::Right(r) = v { [INFO] [stdout] 149 | | return Ok(Some(r)); [INFO] [stdout] ... | [INFO] [stdout] 153 | | Ok(None) [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 144 | let mut s = self.fetch_many(query); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 166 | let metadata = prepare(self, sql).await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | [INFO] [stdout] 168 | Ok(MssqlStatement { [INFO] [stdout] | ________________^ [INFO] [stdout] 169 | | sql: Cow::Borrowed(sql), [INFO] [stdout] 170 | | metadata, [INFO] [stdout] 171 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:191:16 [INFO] [stdout] | [INFO] [stdout] 183 | let metadata = prepare(self, sql).await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | Ok(Describe { [INFO] [stdout] | ________________^ [INFO] [stdout] 192 | | nullable, [INFO] [stdout] 193 | | columns: (metadata.columns).clone(), [INFO] [stdout] 194 | | parameters: None, [INFO] [stdout] 195 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/prepare.rs:25:50 [INFO] [stdout] | [INFO] [stdout] 25 | static PARAMS_RE: Lazy = Lazy::new(|| Regex::new(r"@p[[:alnum:]]+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tls.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 14 | fn with_socket(self, socket: S) -> Self::Output { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Box::pin(maybe_upgrade(socket, self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options/mod.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | .and_then(|v| v.parse().ok()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/env_change.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | let mut data = buf.split_to((len - 1) as usize); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(match ty { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | 1 => EnvChange::Database(data.get_b_varchar()?), [INFO] [stdout] 42 | | 2 => EnvChange::Language(data.get_b_varchar()?), [INFO] [stdout] 43 | | 3 => EnvChange::CharacterSet(data.get_b_varchar()?), [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/order.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | let columns = buf.split_to(len as usize); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | [INFO] [stdout] 16 | Ok(Self { columns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/return_value.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 41 | let value = type_info.get_value(buf); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | param_ordinal: ordinal, [INFO] [stdout] 45 | | param_name: name, [INFO] [stdout] 46 | | status, [INFO] [stdout] ... | [INFO] [stdout] 50 | | value, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/row.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut values = Vec::with_capacity(columns.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let nulls = if nullable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | values, [INFO] [stdout] 41 | | column_types, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `welds-sqlx-mssql` (lib test) due to 14 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `ssl_mode`, `ssl_root_cert`, `ssl_client_cert`, and `ssl_client_key` are never read [INFO] [stdout] --> src/options/mod.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct MssqlConnectOptions { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub(crate) ssl_mode: MssqlSslMode, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub(crate) ssl_root_cert: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 19 | pub(crate) ssl_client_cert: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 20 | pub(crate) ssl_client_key: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MssqlConnectOptions` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/protocol/message.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | LoginAck(LoginAck), [INFO] [stdout] | -------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Message` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 12 | LoginAck(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/protocol/message.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | ReturnStatus(ReturnStatus), [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Message` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 17 | ReturnStatus(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/protocol/message.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | Order(Order), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Message` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 19 | Order(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 37 | fn close(mut self) -> BoxFuture<'static, Result<(), Error>> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 39 | | self.stream.shutdown().await?; [INFO] [stdout] 40 | | Ok(()) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/mod.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 44 | fn close_hard(mut self) -> BoxFuture<'static, Result<(), Error>> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 46 | | self.stream.shutdown().await?; [INFO] [stdout] 47 | | Ok(()) [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 138 | query: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let mut s = self.fetch_many(query); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 147 | | while let Some(v) = s.try_next().await? { [INFO] [stdout] 148 | | if let Either::Right(r) = v { [INFO] [stdout] 149 | | return Ok(Some(r)); [INFO] [stdout] ... | [INFO] [stdout] 153 | | Ok(None) [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 144 | let mut s = self.fetch_many(query); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 166 | let metadata = prepare(self, sql).await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | [INFO] [stdout] 168 | Ok(MssqlStatement { [INFO] [stdout] | ________________^ [INFO] [stdout] 169 | | sql: Cow::Borrowed(sql), [INFO] [stdout] 170 | | metadata, [INFO] [stdout] 171 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/executor.rs:191:16 [INFO] [stdout] | [INFO] [stdout] 183 | let metadata = prepare(self, sql).await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | Ok(Describe { [INFO] [stdout] | ________________^ [INFO] [stdout] 192 | | nullable, [INFO] [stdout] 193 | | columns: (metadata.columns).clone(), [INFO] [stdout] 194 | | parameters: None, [INFO] [stdout] 195 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/prepare.rs:25:50 [INFO] [stdout] | [INFO] [stdout] 25 | static PARAMS_RE: Lazy = Lazy::new(|| Regex::new(r"@p[[:alnum:]]+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tls.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 14 | fn with_socket(self, socket: S) -> Self::Output { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Box::pin(maybe_upgrade(socket, self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options/mod.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | .and_then(|v| v.parse().ok()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/env_change.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | let mut data = buf.split_to((len - 1) as usize); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(match ty { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | 1 => EnvChange::Database(data.get_b_varchar()?), [INFO] [stdout] 42 | | 2 => EnvChange::Language(data.get_b_varchar()?), [INFO] [stdout] 43 | | 3 => EnvChange::CharacterSet(data.get_b_varchar()?), [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/order.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | let columns = buf.split_to(len as usize); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | [INFO] [stdout] 16 | Ok(Self { columns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/return_value.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 41 | let value = type_info.get_value(buf); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | param_ordinal: ordinal, [INFO] [stdout] 45 | | param_name: name, [INFO] [stdout] 46 | | status, [INFO] [stdout] ... | [INFO] [stdout] 50 | | value, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/row.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut values = Vec::with_capacity(columns.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let nulls = if nullable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | values, [INFO] [stdout] 41 | | column_types, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `welds-sqlx-mssql` (lib) due to 14 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4604e5652bb32f749f55dbb24ca256b65eb7d162af17f801056d1e48e5588193", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4604e5652bb32f749f55dbb24ca256b65eb7d162af17f801056d1e48e5588193", kill_on_drop: false }` [INFO] [stdout] 4604e5652bb32f749f55dbb24ca256b65eb7d162af17f801056d1e48e5588193