[INFO] fetching crate weldr 0.3.1... [INFO] checking weldr-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate weldr 0.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate weldr 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate weldr 0.3.1 [INFO] finished tweaking crates.io crate weldr 0.3.1 [INFO] tweaked toml for crates.io crate weldr 0.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cgmath v0.17.0 (latest: v0.18.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00b102dee3e461fe2f5bdb6995d5013a4e1da7d46394d7e471fbed2abdd76f9c [INFO] running `Command { std: "docker" "start" "-a" "00b102dee3e461fe2f5bdb6995d5013a4e1da7d46394d7e471fbed2abdd76f9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00b102dee3e461fe2f5bdb6995d5013a4e1da7d46394d7e471fbed2abdd76f9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00b102dee3e461fe2f5bdb6995d5013a4e1da7d46394d7e471fbed2abdd76f9c", kill_on_drop: false }` [INFO] [stdout] 00b102dee3e461fe2f5bdb6995d5013a4e1da7d46394d7e471fbed2abdd76f9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21c22dce152184ca2ea993f0be4faa84914fd8f5916b93fe7f6433cc350c29ef [INFO] running `Command { std: "docker" "start" "-a" "21c22dce152184ca2ea993f0be4faa84914fd8f5916b93fe7f6433cc350c29ef", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling cgmath v0.17.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking weldr v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cgmath` [INFO] [stdout] --> src/lib.rs:99:7 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(feature = "cgmath")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cgmath` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cgmath` [INFO] [stdout] --> src/lib.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | #[cfg(feature = "cgmath")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cgmath` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cgmath` [INFO] [stdout] --> src/lib.rs:99:7 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(feature = "cgmath")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cgmath` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cgmath` [INFO] [stdout] --> src/lib.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | #[cfg(feature = "cgmath")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cgmath` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:629:17 [INFO] [stdout] | [INFO] [stdout] 629 | |e| Err(Error::Parse(ParseError::new_from_nom(filename, &e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(filename: &str, err: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | parse_error: Some(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(filename: &str, err: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | resolve_error: Some(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `weldr` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:629:17 [INFO] [stdout] | [INFO] [stdout] 629 | |e| Err(Error::Parse(ParseError::new_from_nom(filename, &e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(filename: &str, err: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | parse_error: Some(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(filename: &str, err: impl Into>) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | resolve_error: Some(err.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 138 | let underlying = Error::Parse(ParseError { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | Err(Error::Resolve(ResolveError::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 143 | | "test_file.ldr", [INFO] [stdout] 144 | | underlying, [INFO] [stdout] 145 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `weldr` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "21c22dce152184ca2ea993f0be4faa84914fd8f5916b93fe7f6433cc350c29ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21c22dce152184ca2ea993f0be4faa84914fd8f5916b93fe7f6433cc350c29ef", kill_on_drop: false }` [INFO] [stdout] 21c22dce152184ca2ea993f0be4faa84914fd8f5916b93fe7f6433cc350c29ef