[INFO] fetching crate webusb 0.5.0... [INFO] checking webusb-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate webusb 0.5.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate webusb 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config [INFO] started tweaking crates.io crate webusb 0.5.0 [INFO] finished tweaking crates.io crate webusb 0.5.0 [INFO] tweaked toml for crates.io crate webusb 0.5.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate webusb 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c013d1ba490c65050fe0079705ff98b152950e4ecaea7a5ee0c1764ef28941b9 [INFO] running `Command { std: "docker" "start" "-a" "c013d1ba490c65050fe0079705ff98b152950e4ecaea7a5ee0c1764ef28941b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c013d1ba490c65050fe0079705ff98b152950e4ecaea7a5ee0c1764ef28941b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c013d1ba490c65050fe0079705ff98b152950e4ecaea7a5ee0c1764ef28941b9", kill_on_drop: false }` [INFO] [stdout] c013d1ba490c65050fe0079705ff98b152950e4ecaea7a5ee0c1764ef28941b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8977de8f2d6a79f528adb68d22c2f6a78d1017bc006a5944fe79da782f0c2564 [INFO] running `Command { std: "docker" "start" "-a" "8977de8f2d6a79f528adb68d22c2f6a78d1017bc006a5944fe79da782f0c2564", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.118 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling rusb v0.8.1 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libusb1-sys v0.5.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking webusb v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::DerefMut` [INFO] [stdout] --> src/lib.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | use std::ops::DerefMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `interface` [INFO] [stdout] --> src/lib.rs:393:15 [INFO] [stdout] | [INFO] [stdout] 393 | let interface = configuration [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_interface` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `handle` [INFO] [stdout] --> src/lib.rs:542:11 [INFO] [stdout] | [INFO] [stdout] 542 | let handle = match get_device_handle!(self) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_handle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:567:11 [INFO] [stdout] | [INFO] [stdout] 567 | let mut interface = match active_configuration [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:605:11 [INFO] [stdout] | [INFO] [stdout] 605 | let mut interface = match active_configuration [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `configuration_name` is never read [INFO] [stdout] --> src/lib.rs:91:3 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct UsbConfiguration { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 90 | // Index of String Descriptor describing this configuration. [INFO] [stdout] 91 | configuration_name: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsbConfiguration` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `alternate` is never read [INFO] [stdout] --> src/lib.rs:127:3 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct UsbInterface { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 126 | interface_number: u8, [INFO] [stdout] 127 | alternate: UsbAlternateInterface, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsbInterface` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `packet_size` is never read [INFO] [stdout] --> src/lib.rs:195:3 [INFO] [stdout] | [INFO] [stdout] 190 | pub struct UsbEndpoint { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 195 | packet_size: u16, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsbEndpoint` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:487:11 [INFO] [stdout] | [INFO] [stdout] 487 | drop(handle_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut DeviceHandle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 487 - drop(handle_ref); [INFO] [stdout] 487 + let _ = handle_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `kGetDescriptorRequest` should have a snake case name [INFO] [stdout] --> src/lib.rs:1059:11 [INFO] [stdout] | [INFO] [stdout] 1059 | let kGetDescriptorRequest = 0x06; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `k_get_descriptor_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1191:8 [INFO] [stdout] | [INFO] [stdout] 1190 | let ctx = rusb::Context::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1191 | Ok(Self(ctx)) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webusb` (lib) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8977de8f2d6a79f528adb68d22c2f6a78d1017bc006a5944fe79da782f0c2564", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8977de8f2d6a79f528adb68d22c2f6a78d1017bc006a5944fe79da782f0c2564", kill_on_drop: false }` [INFO] [stdout] 8977de8f2d6a79f528adb68d22c2f6a78d1017bc006a5944fe79da782f0c2564