[INFO] fetching crate webrtc-unreliable 0.6.0... [INFO] checking webrtc-unreliable-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate webrtc-unreliable 0.6.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate webrtc-unreliable 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate webrtc-unreliable 0.6.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate webrtc-unreliable 0.6.0 [INFO] tweaked toml for crates.io crate webrtc-unreliable 0.6.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate webrtc-unreliable 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f239decc9ff34175cb3191aae5795d0f03aef904fad87b9fe0993195f939cbe2 [INFO] running `Command { std: "docker" "start" "-a" "f239decc9ff34175cb3191aae5795d0f03aef904fad87b9fe0993195f939cbe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f239decc9ff34175cb3191aae5795d0f03aef904fad87b9fe0993195f939cbe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f239decc9ff34175cb3191aae5795d0f03aef904fad87b9fe0993195f939cbe2", kill_on_drop: false }` [INFO] [stdout] f239decc9ff34175cb3191aae5795d0f03aef904fad87b9fe0993195f939cbe2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c153f8281a920a0bb532ed30e6be7d5bb81011009744397b62cc5dc30dadf1e [INFO] running `Command { std: "docker" "start" "-a" "9c153f8281a920a0bb532ed30e6be7d5bb81011009744397b62cc5dc30dadf1e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.73 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling openssl v0.10.62 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Compiling quote v1.0.34 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.45 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling openssl-sys v0.9.98 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking webrtc-unreliable v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures v0.3.30 [INFO] [stdout] warning: field `ice_passwd` is never read [INFO] [stdout] --> src/sdp.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct SdpFields { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 11 | pub ice_ufrag: String, [INFO] [stdout] 12 | pub ice_passwd: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SdpFields` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 98 | buffer_pool: BufferPool, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | match ssl_acceptor.accept(ClientSslPackets { [INFO] [stdout] | _______________^ [INFO] [stdout] 102 | | buffer_pool: buffer_pool.clone(), [INFO] [stdout] 103 | | incoming_udp: VecDeque::new(), [INFO] [stdout] 104 | | outgoing_udp: VecDeque::new(), [INFO] [stdout] 105 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 38 | let rsa = Rsa::generate(4096)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let key = PKey::from_rsa(rsa)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut name_builder = X509NameBuilder::new()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | name_builder.append_entry_by_nid(Nid::COMMONNAME, "webrtc-unreliable")?; [INFO] [stdout] 47 | let name = name_builder.build(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | let mut x509_builder = X509::builder()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let not_before = Asn1Time::days_from_now(X509_DAYS_NOT_BEFORE)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let not_after = Asn1Time::days_from_now(X509_DAYS_NOT_AFTER)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let x509 = x509_builder.build(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut ssl_acceptor_builder = SslAcceptor::mozilla_intermediate(SslMethod::dtls())?; [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let ssl_acceptor = Arc::new(ssl_acceptor_builder.build()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | [INFO] [stdout] 88 | Ok(SslConfig { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | fingerprint, [INFO] [stdout] 90 | | ssl_acceptor, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:149:52 [INFO] [stdout] | [INFO] [stdout] 149 | .map_err(|e| SessionError::StreamError(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 225 | runtime: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | SslConfig::create().expect("WebRTC server could not initialize OpenSSL primitives"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:268:12 [INFO] [stdout] | [INFO] [stdout] 243 | runtime: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | crypto: SslConfig, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let udp_socket = runtime.bind_udp(listen_addr)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | [INFO] [stdout] 252 | let (session_sender, session_receiver) = mpsc::channel(SESSION_BUFFER_SIZE); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | let session_endpoint = SessionEndpoint { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | let periodic_timer = Box::pin(runtime.timer(PERIODIC_TIMER_INTERVAL)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | [INFO] [stdout] 268 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 269 | | runtime, [INFO] [stdout] 270 | | udp_socket, [INFO] [stdout] 271 | | session_endpoint, [INFO] [stdout] ... | [INFO] [stdout] 281 | | periodic_timer, [INFO] [stdout] 282 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webrtc-unreliable` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9c153f8281a920a0bb532ed30e6be7d5bb81011009744397b62cc5dc30dadf1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c153f8281a920a0bb532ed30e6be7d5bb81011009744397b62cc5dc30dadf1e", kill_on_drop: false }` [INFO] [stdout] 9c153f8281a920a0bb532ed30e6be7d5bb81011009744397b62cc5dc30dadf1e