[INFO] fetching crate webcam 0.0.0... [INFO] checking webcam-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate webcam 0.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate webcam 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate webcam 0.0.0 [INFO] finished tweaking crates.io crate webcam 0.0.0 [INFO] tweaked toml for crates.io crate webcam 0.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate webcam 0.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7cdb300fc65b61f774885cc389d73cacb03dd95dbafab896913b0d157453dcf [INFO] running `Command { std: "docker" "start" "-a" "e7cdb300fc65b61f774885cc389d73cacb03dd95dbafab896913b0d157453dcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7cdb300fc65b61f774885cc389d73cacb03dd95dbafab896913b0d157453dcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7cdb300fc65b61f774885cc389d73cacb03dd95dbafab896913b0d157453dcf", kill_on_drop: false }` [INFO] [stdout] e7cdb300fc65b61f774885cc389d73cacb03dd95dbafab896913b0d157453dcf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d75dc0ebdacf2a8672e46408c43f05c60148f85c1e6cdeee2a9333f5b9f89261 [INFO] running `Command { std: "docker" "start" "-a" "d75dc0ebdacf2a8672e46408c43f05c60148f85c1e6cdeee2a9333f5b9f89261", kill_on_drop: false }` [INFO] [stderr] Compiling pix v0.13.1 [INFO] [stderr] Checking smelling_salts v0.1.0 [INFO] [stderr] Checking pasts v0.7.4 [INFO] [stderr] Checking webcam v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable `all_open` is assigned to, but never used [INFO] [stdout] --> src/lib.rs:367:25 [INFO] [stdout] | [INFO] [stdout] 367 | let mut all_open = true; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_all_open` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `all_open` is never read [INFO] [stdout] --> src/lib.rs:388:37 [INFO] [stdout] | [INFO] [stdout] 388 | ... all_open = false; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fd` [INFO] [stdout] --> src/lib.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn new(fd: c_int, raster: Raster) -> Option { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_fd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROT_READ` is never used [INFO] [stdout] --> src/lib.rs:272:7 [INFO] [stdout] | [INFO] [stdout] 272 | const PROT_READ: c_int = 0x04; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROT_WRITE` is never used [INFO] [stdout] --> src/lib.rs:273:7 [INFO] [stdout] | [INFO] [stdout] 273 | const PROT_WRITE: c_int = 0x02; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAP_SHARED` is never used [INFO] [stdout] --> src/lib.rs:275:7 [INFO] [stdout] | [INFO] [stdout] 275 | const MAP_SHARED: c_int = 0x0010; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `data` and `raster` are never read [INFO] [stdout] --> src/lib.rs:444:2 [INFO] [stdout] | [INFO] [stdout] 435 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 444 | data: *mut c_void, // JPEG file data [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 448 | raster: Raster, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mmap` is never used [INFO] [stdout] --> src/lib.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 294 | fn mmap(addr: *mut c_void, length: usize, prot: c_int, flags: c_int, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write` is never used [INFO] [stdout] --> src/lib.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 298 | fn write(fd: c_int, buf: *const c_void, count: usize) -> isize; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:557:11 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn new(fd: c_int, raster: Raster) -> Option { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | Ok(f) => f.into_raw_fd(), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | Err(_e) => return None, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Some(Camera { [INFO] [stdout] | ______________^ [INFO] [stdout] 558 | | device: Device::new(fd, Watcher::new().input()), [INFO] [stdout] 559 | | size: buf.length, [INFO] [stdout] 560 | | buf, [INFO] [stdout] ... | [INFO] [stdout] 563 | | raster, [INFO] [stdout] 564 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `all_open` is assigned to, but never used [INFO] [stdout] --> src/lib.rs:367:25 [INFO] [stdout] | [INFO] [stdout] 367 | let mut all_open = true; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_all_open` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `all_open` is never read [INFO] [stdout] --> src/lib.rs:388:37 [INFO] [stdout] | [INFO] [stdout] 388 | ... all_open = false; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fd` [INFO] [stdout] --> src/lib.rs:452:16 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn new(fd: c_int, raster: Raster) -> Option { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_fd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROT_READ` is never used [INFO] [stdout] --> src/lib.rs:272:7 [INFO] [stdout] | [INFO] [stdout] 272 | const PROT_READ: c_int = 0x04; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PROT_WRITE` is never used [INFO] [stdout] --> src/lib.rs:273:7 [INFO] [stdout] | [INFO] [stdout] 273 | const PROT_WRITE: c_int = 0x02; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAP_SHARED` is never used [INFO] [stdout] --> src/lib.rs:275:7 [INFO] [stdout] | [INFO] [stdout] 275 | const MAP_SHARED: c_int = 0x0010; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `data` and `raster` are never read [INFO] [stdout] --> src/lib.rs:444:2 [INFO] [stdout] | [INFO] [stdout] 435 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 444 | data: *mut c_void, // JPEG file data [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 448 | raster: Raster, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mmap` is never used [INFO] [stdout] --> src/lib.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 294 | fn mmap(addr: *mut c_void, length: usize, prot: c_int, flags: c_int, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write` is never used [INFO] [stdout] --> src/lib.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 298 | fn write(fd: c_int, buf: *const c_void, count: usize) -> isize; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:557:11 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn new(fd: c_int, raster: Raster) -> Option { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | Ok(f) => f.into_raw_fd(), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | Err(_e) => return None, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Some(Camera { [INFO] [stdout] | ______________^ [INFO] [stdout] 558 | | device: Device::new(fd, Watcher::new().input()), [INFO] [stdout] 559 | | size: buf.length, [INFO] [stdout] 560 | | buf, [INFO] [stdout] ... | [INFO] [stdout] 563 | | raster, [INFO] [stdout] 564 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webcam` (lib test) due to 2 previous errors; 9 warnings emitted [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `webcam` (lib) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d75dc0ebdacf2a8672e46408c43f05c60148f85c1e6cdeee2a9333f5b9f89261", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d75dc0ebdacf2a8672e46408c43f05c60148f85c1e6cdeee2a9333f5b9f89261", kill_on_drop: false }` [INFO] [stdout] d75dc0ebdacf2a8672e46408c43f05c60148f85c1e6cdeee2a9333f5b9f89261