[INFO] fetching crate web-push-native 0.4.0... [INFO] checking web-push-native-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate web-push-native 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate web-push-native 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate web-push-native 0.4.0 [INFO] finished tweaking crates.io crate web-push-native 0.4.0 [INFO] tweaked toml for crates.io crate web-push-native 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 104 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ad01c7d1adaad7aff20c436c4907f5e0c7977f7379c78d561047566408bd63b [INFO] running `Command { std: "docker" "start" "-a" "1ad01c7d1adaad7aff20c436c4907f5e0c7977f7379c78d561047566408bd63b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ad01c7d1adaad7aff20c436c4907f5e0c7977f7379c78d561047566408bd63b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ad01c7d1adaad7aff20c436c4907f5e0c7977f7379c78d561047566408bd63b", kill_on_drop: false }` [INFO] [stdout] 1ad01c7d1adaad7aff20c436c4907f5e0c7977f7379c78d561047566408bd63b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39f1b118158f935da040b80d97756dbfda9d9671bc7ab4df60c71b51c81e1f30 [INFO] running `Command { std: "docker" "start" "-a" "39f1b118158f935da040b80d97756dbfda9d9671bc7ab4df60c71b51c81e1f30", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking ct-codecs v1.1.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking ed25519-compact v2.1.1 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking coarsetime v0.1.34 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking binstring v0.1.1 [INFO] [stderr] Checking hmac-sha1-compact v1.1.4 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking hmac-sha512 v1.1.5 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking hmac-sha256 v1.1.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking ece-native v0.4.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking superboring v0.1.2 [INFO] [stderr] Checking jwt-simple v0.12.10 [INFO] [stderr] Checking web-push-native v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn build>>(&self, body: T) -> Result>, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let builder = Request::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let builder = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(builder [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | .body(payload) [INFO] [stdout] 192 | | .expect("builder arguments are always well-defined")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:82 [INFO] [stdout] | [INFO] [stdout] 188 | AddHeaders::add_headers(self, builder).map_err(|it| Error::Extension(it.into()))?; [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | fn string_to_url<'de, D: Deserializer<'de>>(d: D) -> Result, D::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let s: Cow = Deserialize::deserialize(d)?; [INFO] [stdout] 31 | s.parse().map(Cow::Owned).map_err(de::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 60 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / WebPushSerde { [INFO] [stdout] 65 | | endpoint: Cow::Borrowed(&self.endpoint), [INFO] [stdout] 66 | | expiration_time: None, [INFO] [stdout] 67 | | keys: Keys { [INFO] [stdout] ... | [INFO] [stdout] 70 | | }, [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let serde = WebPushSerde::deserialize(deserializer)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Ok(WebPushBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | endpoint: serde.endpoint.into_owned(), [INFO] [stdout] 84 | | valid_duration: Duration::from_secs(12 * 60 * 60), [INFO] [stdout] 85 | | ua_public: serde.keys.p256dh, [INFO] [stdout] 86 | | ua_auth: serde.keys.auth, [INFO] [stdout] 87 | | http_auth: (), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vapid.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 26 | builder: http::request::Builder, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(builder.header(header::AUTHORIZATION, vapid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `web-push-native` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn build>>(&self, body: T) -> Result>, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let builder = Request::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let builder = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(builder [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | .body(payload) [INFO] [stdout] 192 | | .expect("builder arguments are always well-defined")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:82 [INFO] [stdout] | [INFO] [stdout] 188 | AddHeaders::add_headers(self, builder).map_err(|it| Error::Extension(it.into()))?; [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | fn string_to_url<'de, D: Deserializer<'de>>(d: D) -> Result, D::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let s: Cow = Deserialize::deserialize(d)?; [INFO] [stdout] 31 | s.parse().map(Cow::Owned).map_err(de::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 60 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / WebPushSerde { [INFO] [stdout] 65 | | endpoint: Cow::Borrowed(&self.endpoint), [INFO] [stdout] 66 | | expiration_time: None, [INFO] [stdout] 67 | | keys: Keys { [INFO] [stdout] ... | [INFO] [stdout] 70 | | }, [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let serde = WebPushSerde::deserialize(deserializer)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Ok(WebPushBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | endpoint: serde.endpoint.into_owned(), [INFO] [stdout] 84 | | valid_duration: Duration::from_secs(12 * 60 * 60), [INFO] [stdout] 85 | | ua_public: serde.keys.p256dh, [INFO] [stdout] 86 | | ua_auth: serde.keys.auth, [INFO] [stdout] 87 | | http_auth: (), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vapid.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 26 | builder: http::request::Builder, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(builder.header(header::AUTHORIZATION, vapid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `web-push-native` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "39f1b118158f935da040b80d97756dbfda9d9671bc7ab4df60c71b51c81e1f30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39f1b118158f935da040b80d97756dbfda9d9671bc7ab4df60c71b51c81e1f30", kill_on_drop: false }` [INFO] [stdout] 39f1b118158f935da040b80d97756dbfda9d9671bc7ab4df60c71b51c81e1f30