[INFO] fetching crate wcal 0.2.0... [INFO] checking wcal-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wcal 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate wcal 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wcal 0.2.0 [INFO] finished tweaking crates.io crate wcal 0.2.0 [INFO] tweaked toml for crates.io crate wcal 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate wcal 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19d0126e48e7620c9e4ce7c175f0a701f21ddcef093e2aad8537ef4c4562a058 [INFO] running `Command { std: "docker" "start" "-a" "19d0126e48e7620c9e4ce7c175f0a701f21ddcef093e2aad8537ef4c4562a058", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19d0126e48e7620c9e4ce7c175f0a701f21ddcef093e2aad8537ef4c4562a058", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19d0126e48e7620c9e4ce7c175f0a701f21ddcef093e2aad8537ef4c4562a058", kill_on_drop: false }` [INFO] [stdout] 19d0126e48e7620c9e4ce7c175f0a701f21ddcef093e2aad8537ef4c4562a058 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 305621b2f40375c510d2c3a930e80a6da40fc3555f908b0eb3705efd4e7efbe2 [INFO] running `Command { std: "docker" "start" "-a" "305621b2f40375c510d2c3a930e80a6da40fc3555f908b0eb3705efd4e7efbe2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling regex-syntax v0.6.23 [INFO] [stderr] Compiling utf8-ranges v1.0.4 [INFO] [stderr] Compiling beef v0.5.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling logos-derive v0.12.0 [INFO] [stderr] Checking logos v0.12.0 [INFO] [stderr] Checking wcal v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/lib.rs:43:58 [INFO] [stdout] | [INFO] [stdout] 43 | calculator($expr, parser::top_down_parser::parse); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 92 | let res: f64 = calculator!("1+2")?; [INFO] [stdout] | ------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `calculator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/lib.rs:46:67 [INFO] [stdout] | [INFO] [stdout] 46 | calculator::<$type>($expr, parser::top_down_parser::parse); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 95 | let res: f64 = calculator!("1+2", f64)?; [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: this warning originates in the macro `calculator` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 70 | let ast = parser(tokens)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(T::from_ast(ast)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Expr::Pair(Pair{expr: Box::new(expr)}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(lhs: Expr, rhs: Expr, token: Token) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Expr::BinOp(BinOp{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 53 | | lhs: Box::new(lhs), [INFO] [stdout] 54 | | rhs: Box::new(rhs), [INFO] [stdout] 55 | | op: token [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Expr::Neg(Neg{expr: Box::new(expr)}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wcal` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 70 | let ast = parser(tokens)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(T::from_ast(ast)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Expr::Pair(Pair{expr: Box::new(expr)}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(lhs: Expr, rhs: Expr, token: Token) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Expr::BinOp(BinOp{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 53 | | lhs: Box::new(lhs), [INFO] [stdout] 54 | | rhs: Box::new(rhs), [INFO] [stdout] 55 | | op: token [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Expr::Neg(Neg{expr: Box::new(expr)}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wcal` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "305621b2f40375c510d2c3a930e80a6da40fc3555f908b0eb3705efd4e7efbe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "305621b2f40375c510d2c3a930e80a6da40fc3555f908b0eb3705efd4e7efbe2", kill_on_drop: false }` [INFO] [stdout] 305621b2f40375c510d2c3a930e80a6da40fc3555f908b0eb3705efd4e7efbe2