[INFO] fetching crate wayrs-client 1.1.1... [INFO] checking wayrs-client-1.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wayrs-client 1.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate wayrs-client 1.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wayrs-client 1.1.1 [INFO] finished tweaking crates.io crate wayrs-client 1.1.1 [INFO] tweaked toml for crates.io crate wayrs-client 1.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate wayrs-client 1.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4df39b7aba224860468433093fe146471cec9baf2cfb40a193b849ffb10f1970 [INFO] running `Command { std: "docker" "start" "-a" "4df39b7aba224860468433093fe146471cec9baf2cfb40a193b849ffb10f1970", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4df39b7aba224860468433093fe146471cec9baf2cfb40a193b849ffb10f1970", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4df39b7aba224860468433093fe146471cec9baf2cfb40a193b849ffb10f1970", kill_on_drop: false }` [INFO] [stdout] 4df39b7aba224860468433093fe146471cec9baf2cfb40a193b849ffb10f1970 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a30018ac0b314fd5bcc0f626fb193cf9b9eeb0aa8911a06b962800b36b69cdf [INFO] running `Command { std: "docker" "start" "-a" "6a30018ac0b314fd5bcc0f626fb193cf9b9eeb0aa8911a06b962800b36b69cdf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Compiling syn v2.0.51 [INFO] [stderr] Compiling indexmap v2.2.3 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling wayrs-proto-parser v2.0.0 [INFO] [stderr] Checking wayrs-core v1.0.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling wayrs-scanner v0.14.0 [INFO] [stderr] Checking wayrs-client v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn clear_callbacks(self) -> ObjectManager { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | client_objects: self [INFO] [stdout] | _____________________________^ [INFO] [stdout] 175 | | .client_objects [INFO] [stdout] 176 | | .into_iter() [INFO] [stdout] 177 | | .map(|x| x.map(map)) [INFO] [stdout] 178 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:179:29 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn clear_callbacks(self) -> ObjectManager { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | server_objects: self [INFO] [stdout] | _____________________________^ [INFO] [stdout] 180 | | .server_objects [INFO] [stdout] 181 | | .into_iter() [INFO] [stdout] 182 | | .map(|x| x.map(map)) [INFO] [stdout] 183 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 167 | let map = |x: ObjectState| ObjectState { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | cb: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 117 | let mut this = Self::connect()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | this.blocking_roundtrip()?; [INFO] [stdout] 119 | let globals = this [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok((this, globals)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn clear_callbacks(self) -> Connection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | object_mgr: self.object_mgr.clear_callbacks(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:224:27 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn clear_callbacks(self) -> Connection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | registry_cbs: Some(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 314 | let event = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | Ok(QueuedEvent::Message(event)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:579:18 [INFO] [stdout] | [INFO] [stdout] 576 | mut cb: F, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | Box::new(move |conn, state, object, event| { [INFO] [stdout] | __________________^ [INFO] [stdout] 580 | | let proxy: P = object.try_into().unwrap(); [INFO] [stdout] 581 | | let event = P::parse_event(event, object.version, &mut conn.msg_buffers_pool).unwrap(); [INFO] [stdout] 582 | | let ctx = EventCtx { [INFO] [stdout] ... | [INFO] [stdout] 588 | | cb(ctx); [INFO] [stdout] 589 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wayrs-client` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn clear_callbacks(self) -> ObjectManager { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | client_objects: self [INFO] [stdout] | _____________________________^ [INFO] [stdout] 175 | | .client_objects [INFO] [stdout] 176 | | .into_iter() [INFO] [stdout] 177 | | .map(|x| x.map(map)) [INFO] [stdout] 178 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:179:29 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn clear_callbacks(self) -> ObjectManager { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | server_objects: self [INFO] [stdout] | _____________________________^ [INFO] [stdout] 180 | | .server_objects [INFO] [stdout] 181 | | .into_iter() [INFO] [stdout] 182 | | .map(|x| x.map(map)) [INFO] [stdout] 183 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 167 | let map = |x: ObjectState| ObjectState { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | cb: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 117 | let mut this = Self::connect()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | this.blocking_roundtrip()?; [INFO] [stdout] 119 | let globals = this [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok((this, globals)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn clear_callbacks(self) -> Connection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | object_mgr: self.object_mgr.clear_callbacks(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:224:27 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn clear_callbacks(self) -> Connection { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | registry_cbs: Some(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 314 | let event = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | Ok(QueuedEvent::Message(event)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:579:18 [INFO] [stdout] | [INFO] [stdout] 576 | mut cb: F, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | Box::new(move |conn, state, object, event| { [INFO] [stdout] | __________________^ [INFO] [stdout] 580 | | let proxy: P = object.try_into().unwrap(); [INFO] [stdout] 581 | | let event = P::parse_event(event, object.version, &mut conn.msg_buffers_pool).unwrap(); [INFO] [stdout] 582 | | let ctx = EventCtx { [INFO] [stdout] ... | [INFO] [stdout] 588 | | cb(ctx); [INFO] [stdout] 589 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wayrs-client` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "6a30018ac0b314fd5bcc0f626fb193cf9b9eeb0aa8911a06b962800b36b69cdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a30018ac0b314fd5bcc0f626fb193cf9b9eeb0aa8911a06b962800b36b69cdf", kill_on_drop: false }` [INFO] [stdout] 6a30018ac0b314fd5bcc0f626fb193cf9b9eeb0aa8911a06b962800b36b69cdf