[INFO] fetching crate waycrate_xkbkeycode 0.5.1... [INFO] checking waycrate_xkbkeycode-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate waycrate_xkbkeycode 0.5.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate waycrate_xkbkeycode 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate waycrate_xkbkeycode 0.5.1 [INFO] finished tweaking crates.io crate waycrate_xkbkeycode 0.5.1 [INFO] tweaked toml for crates.io crate waycrate_xkbkeycode 0.5.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-xml v0.34.0 (latest: v0.36.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb4861773bcbace745b1648ee1717dd82b6602e6d463597e296e04d0090a3487 [INFO] running `Command { std: "docker" "start" "-a" "bb4861773bcbace745b1648ee1717dd82b6602e6d463597e296e04d0090a3487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb4861773bcbace745b1648ee1717dd82b6602e6d463597e296e04d0090a3487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4861773bcbace745b1648ee1717dd82b6602e6d463597e296e04d0090a3487", kill_on_drop: false }` [INFO] [stdout] bb4861773bcbace745b1648ee1717dd82b6602e6d463597e296e04d0090a3487 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f61f0195dc97d65e93cc517c5c3313d513b20edee47b110c2b1fe838d8e602c [INFO] running `Command { std: "docker" "start" "-a" "4f61f0195dc97d65e93cc517c5c3313d513b20edee47b110c2b1fe838d8e602c", kill_on_drop: false }` [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling wayland-client v0.31.5 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Compiling wayland-sys v0.31.4 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling wayland-backend v0.3.6 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling quick-xml v0.34.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling wayland-scanner v0.31.4 [INFO] [stderr] Checking waycrate_xkbkeycode v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:76:26 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn new(keyboard: WlKeyboard) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | xkb_context: Context::new().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 115 | let context = XkbContext::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut compose_table = XkbComposeTable::new(&context); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let mut compose_state1 = compose_table.as_ref().and_then(|table| table.new_state()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut compose_state2 = compose_table.as_ref().and_then(|table| table.new_state()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | state: None, [INFO] [stdout] 129 | | keymap: None, [INFO] [stdout] 130 | | compose_state1, [INFO] [stdout] ... | [INFO] [stdout] 134 | | scratch_buffer: Vec::with_capacity(8), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:189:14 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn from_fd(context: &XkbContext, fd: OwnedFd, size: usize) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let map = MmapOptions::new().len(size).map_raw_read_only(&fd).ok()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Some(Self { keymap }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:399:14 [INFO] [stdout] | [INFO] [stdout] 388 | let locale = CString::new(locale.into_vec()).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | Some(Self { table }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:76:26 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn new(keyboard: WlKeyboard) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | xkb_context: Context::new().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 115 | let context = XkbContext::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut compose_table = XkbComposeTable::new(&context); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let mut compose_state1 = compose_table.as_ref().and_then(|table| table.new_state()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut compose_state2 = compose_table.as_ref().and_then(|table| table.new_state()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | state: None, [INFO] [stdout] 129 | | keymap: None, [INFO] [stdout] 130 | | compose_state1, [INFO] [stdout] ... | [INFO] [stdout] 134 | | scratch_buffer: Vec::with_capacity(8), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:189:14 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn from_fd(context: &XkbContext, fd: OwnedFd, size: usize) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let map = MmapOptions::new().len(size).map_raw_read_only(&fd).ok()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Some(Self { keymap }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xkb_keyboard.rs:399:14 [INFO] [stdout] | [INFO] [stdout] 388 | let locale = CString::new(locale.into_vec()).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | Some(Self { table }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `waycrate_xkbkeycode` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `waycrate_xkbkeycode` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "4f61f0195dc97d65e93cc517c5c3313d513b20edee47b110c2b1fe838d8e602c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f61f0195dc97d65e93cc517c5c3313d513b20edee47b110c2b1fe838d8e602c", kill_on_drop: false }` [INFO] [stdout] 4f61f0195dc97d65e93cc517c5c3313d513b20edee47b110c2b1fe838d8e602c