[INFO] fetching crate waterrower 0.1.0... [INFO] checking waterrower-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate waterrower 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate waterrower 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate waterrower 0.1.0 [INFO] finished tweaking crates.io crate waterrower 0.1.0 [INFO] tweaked toml for crates.io crate waterrower 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding ioctl-rs v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding nix v0.7.0 (latest: v0.29.0) [INFO] [stderr] Adding rustc_version v0.1.7 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.1.20 (latest: v1.0.23) [INFO] [stderr] Adding serial v0.3.4 (latest: v0.4.0) [INFO] [stderr] Adding termios v0.2.2 (latest: v0.3.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6efb3d8050862531be8d7af244c6f74cccae4efdb83912954878ee45249b104 [INFO] running `Command { std: "docker" "start" "-a" "f6efb3d8050862531be8d7af244c6f74cccae4efdb83912954878ee45249b104", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6efb3d8050862531be8d7af244c6f74cccae4efdb83912954878ee45249b104", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6efb3d8050862531be8d7af244c6f74cccae4efdb83912954878ee45249b104", kill_on_drop: false }` [INFO] [stdout] f6efb3d8050862531be8d7af244c6f74cccae4efdb83912954878ee45249b104 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b2d3d57e04b5495882ae01cd390456fcf69d7f839e3ef2bc37b6ba0c8e9cdbb [INFO] running `Command { std: "docker" "start" "-a" "4b2d3d57e04b5495882ae01cd390456fcf69d7f839e3ef2bc37b6ba0c8e9cdbb", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serial v0.3.4 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling nix v0.7.0 [INFO] [stderr] Checking waterrower v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::str` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::str; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | try!(port.reconfigure(&|settings| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | try!(port.set_timeout(Duration::from_millis(1100))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | try!(settings.set_baud_rate(serial::Baud115200)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:13:47 [INFO] [stdout] | [INFO] [stdout] 13 | use std::sync::atomic::{AtomicBool, Ordering, ATOMIC_BOOL_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:17:31 [INFO] [stdout] | [INFO] [stdout] 17 | static EXIT_NOW: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 17 | static EXIT_NOW: AtomicBool = AtomicBool::new(false); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `serialtx` [INFO] [stdout] --> src/main.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | let (serialtx, serialrx) = mpsc::channel(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serialtx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::str; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | try!(port.reconfigure(&|settings| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | try!(port.set_timeout(Duration::from_millis(1100))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | try!(settings.set_baud_rate(serial::Baud115200)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:48:11 [INFO] [stdout] | [INFO] [stdout] 30 | let mut port = serial::open("/dev/ttyACM0").unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let (disptx, disprx) = mpsc::channel(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let (serialtx, serialrx) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let poller = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | match poller.join().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | unsafe { signal::sigaction(signal::SIGINT, &sig_action); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | unsafe { let _ = signal::sigaction(signal::SIGINT, &sig_action); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | unsafe { signal::sigaction(signal::SIGTERM, &sig_action); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 28 | unsafe { let _ = signal::sigaction(signal::SIGTERM, &sig_action); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:13:47 [INFO] [stdout] | [INFO] [stdout] 13 | use std::sync::atomic::{AtomicBool, Ordering, ATOMIC_BOOL_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:17:31 [INFO] [stdout] | [INFO] [stdout] 17 | static EXIT_NOW: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 17 | static EXIT_NOW: AtomicBool = AtomicBool::new(false); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `waterrower` (bin "waterrower") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `serialtx` [INFO] [stdout] --> src/main.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | let (serialtx, serialrx) = mpsc::channel(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serialtx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:48:11 [INFO] [stdout] | [INFO] [stdout] 30 | let mut port = serial::open("/dev/ttyACM0").unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let (disptx, disprx) = mpsc::channel(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let (serialtx, serialrx) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let poller = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | match poller.join().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | unsafe { signal::sigaction(signal::SIGINT, &sig_action); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | unsafe { let _ = signal::sigaction(signal::SIGINT, &sig_action); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | unsafe { signal::sigaction(signal::SIGTERM, &sig_action); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 28 | unsafe { let _ = signal::sigaction(signal::SIGTERM, &sig_action); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `waterrower` (bin "waterrower" test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4b2d3d57e04b5495882ae01cd390456fcf69d7f839e3ef2bc37b6ba0c8e9cdbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b2d3d57e04b5495882ae01cd390456fcf69d7f839e3ef2bc37b6ba0c8e9cdbb", kill_on_drop: false }` [INFO] [stdout] 4b2d3d57e04b5495882ae01cd390456fcf69d7f839e3ef2bc37b6ba0c8e9cdbb