[INFO] fetching crate watchexec 4.1.0... [INFO] checking watchexec-4.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate watchexec 4.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate watchexec 4.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate watchexec 4.1.0 [INFO] finished tweaking crates.io crate watchexec 4.1.0 [INFO] tweaked toml for crates.io crate watchexec 4.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate watchexec 4.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 441d492611464d0a12bd09813e0b94875ef35262ae3854322f8bf13afca2bb99 [INFO] running `Command { std: "docker" "start" "-a" "441d492611464d0a12bd09813e0b94875ef35262ae3854322f8bf13afca2bb99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "441d492611464d0a12bd09813e0b94875ef35262ae3854322f8bf13afca2bb99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "441d492611464d0a12bd09813e0b94875ef35262ae3854322f8bf13afca2bb99", kill_on_drop: false }` [INFO] [stdout] 441d492611464d0a12bd09813e0b94875ef35262ae3854322f8bf13afca2bb99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84a80e801767c44afaac00f024281c4e06f3b5895c6b60e41b9dbb6f6b71d9c2 [INFO] running `Command { std: "docker" "start" "-a" "84a80e801767c44afaac00f024281c4e06f3b5895c6b60e41b9dbb6f6b71d9c2", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking winnow v0.6.6 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking gix-sec v0.10.6 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking normalize-path v0.2.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking atomic-take v1.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking async-priority-channel v0.2.0 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-recursion v1.1.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-path v0.10.7 [INFO] [stderr] Checking gix-date v0.8.5 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking gix-validate v0.8.4 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking gix-config-value v0.14.6 [INFO] [stderr] Checking gix-features v0.38.1 [INFO] [stderr] Checking gix-actor v0.31.1 [INFO] [stderr] Checking gix-fs v0.10.2 [INFO] [stderr] Checking gix-glob v0.16.2 [INFO] [stderr] Checking gix-object v0.42.1 [INFO] [stderr] Checking watchexec-signals v3.0.0 [INFO] [stderr] Checking gix-tempfile v13.1.1 [INFO] [stderr] Checking gix-lock v13.1.1 [INFO] [stderr] Checking watchexec-events v3.0.0 [INFO] [stderr] Checking gix-ref v0.43.0 [INFO] [stderr] Checking gix-config v0.36.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking process-wrap v8.0.0 [INFO] [stderr] Checking watchexec-supervisor v2.0.0 [INFO] [stderr] Checking project-origins v1.4.0 [INFO] [stderr] Checking ignore-files v3.0.1 [INFO] [stderr] Checking watchexec v4.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 61 | pub(crate) fn new(events: Arc<[Event]>, jobs: HashMap) -> Self { [INFO] [stdout] | -------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | new: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:94:3 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_or_create_job(&mut self, id: Id, command: impl Fn() -> Arc) -> Job { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | self.get_job(id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:95:51 [INFO] [stdout] | [INFO] [stdout] 95 | .unwrap_or_else(|| self.create_job_with_id(id, command())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:111:44 [INFO] [stdout] | [INFO] [stdout] 111 | self.extant.iter().map(|(id, job)| (*id, job.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:50:3 [INFO] [stdout] | [INFO] [stdout] 46 | f: impl notify::EventHandler, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / match self { [INFO] [stdout] 51 | | Self::Native => { [INFO] [stdout] 52 | | notify::RecommendedWatcher::new(f, Config::default()).map(|w| Box::new(w) as _) [INFO] [stdout] 53 | | } [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:52:67 [INFO] [stdout] | [INFO] [stdout] 52 | notify::RecommendedWatcher::new(f, Config::default()).map(|w| Box::new(w) as _) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | .map(|w| Box::new(w) as _) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 59 | .map_err(|err| CriticalError::FsWatcherInit { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | kind: self, [INFO] [stdout] 61 | err: if cfg!(target_os = "linux") [INFO] [stdout] | __________________^ [INFO] [stdout] 62 | | && (matches!(err.kind, notify::ErrorKind::MaxFilesWatch) [INFO] [stdout] 63 | | || matches!(err.kind, notify::ErrorKind::Io(ref ioerr) if ioerr.raw_os_error() == Some(28))) [INFO] [stdout] 64 | | { [INFO] [stdout] ... | [INFO] [stdout] 71 | | FsWatcherError::Create(err) [INFO] [stdout] 72 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 262 | let nev = nev.map_err(|err| RuntimeError::FsWatcher { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | kind, [INFO] [stdout] 264 | err: FsWatcherError::Event(err), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changeable.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Self(Arc::new(RwLock::new(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changeable.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 79 | pub(crate) fn new(f: impl (Fn(T) -> U) + Send + Sync + 'static) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Self(Changeable::new(Arc::new(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changeable.rs:94:3 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn call(&self, data: T) -> U { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | (self.0.get())(data) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:249:46 [INFO] [stdout] | [INFO] [stdout] 245 | handler: impl (Fn(ActionHandler) -> ActionHandler) + Send + Sync + 'static, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | .replace(move |action| ActionReturn::Sync(handler(action))); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:263:47 [INFO] [stdout] | [INFO] [stdout] 256 | handler: impl (Fn(ActionHandler) -> Box + Send + Sync>) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | .replace(move |action| ActionReturn::Async(handler(action))); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:112:3 [INFO] [stdout] | [INFO] [stdout] 108 | action_handler: impl (Fn(ActionHandler) -> ActionHandler) + Send + Sync + 'static, [INFO] [stdout] | --------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ) -> Result, CriticalError> { [INFO] [stdout] 110 | let config = Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | config.on_action(action_handler); [INFO] [stdout] 112 | Self::with_config(config).map(Arc::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:126:3 [INFO] [stdout] | [INFO] [stdout] 119 | / action_handler: impl (Fn(ActionHandler) -> Box + Send + Sync>) [INFO] [stdout] 120 | | + Send [INFO] [stdout] 121 | | + Sync [INFO] [stdout] 122 | | + 'static, [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | ) -> Result, CriticalError> { [INFO] [stdout] 124 | let config = Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | config.on_action_async(action_handler); [INFO] [stdout] 126 | Self::with_config(config).map(Arc::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:194:6 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn with_config(config: Config) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | debug!(?config, pid=%std::process::id(), version=%env!("CARGO_PKG_VERSION"), "initialising"); [INFO] [stdout] 137 | let config = Arc::new(config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let outer_config = config.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | [INFO] [stdout] 140 | let notify = Arc::new(Notify::new()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let start_lock = notify.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | [INFO] [stdout] 143 | let (ev_s, ev_r) = [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | priority::bounded(config.event_channel_size.try_into().unwrap_or(u64::MAX)); [INFO] [stdout] 145 | let event_input = ev_s.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let handle = spawn(async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | config: outer_config, [INFO] [stdout] 196 | | start_lock, [INFO] [stdout] 197 | | event_input, [INFO] [stdout] 198 | | handle: Arc::new(AtomicTake::new(handle)), [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:270:14 [INFO] [stdout] | [INFO] [stdout] 267 | fn new(error: RuntimeError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | critical: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 274 | fn handle_crit(crit: Arc>) -> Result<(), CriticalError> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | match Arc::try_unwrap(crit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `watchexec` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 61 | pub(crate) fn new(events: Arc<[Event]>, jobs: HashMap) -> Self { [INFO] [stdout] | -------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | new: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:94:3 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_or_create_job(&mut self, id: Id, command: impl Fn() -> Arc) -> Job { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | self.get_job(id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:95:51 [INFO] [stdout] | [INFO] [stdout] 95 | .unwrap_or_else(|| self.create_job_with_id(id, command())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action/handler.rs:111:44 [INFO] [stdout] | [INFO] [stdout] 111 | self.extant.iter().map(|(id, job)| (*id, job.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:50:3 [INFO] [stdout] | [INFO] [stdout] 46 | f: impl notify::EventHandler, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / match self { [INFO] [stdout] 51 | | Self::Native => { [INFO] [stdout] 52 | | notify::RecommendedWatcher::new(f, Config::default()).map(|w| Box::new(w) as _) [INFO] [stdout] 53 | | } [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:52:67 [INFO] [stdout] | [INFO] [stdout] 52 | notify::RecommendedWatcher::new(f, Config::default()).map(|w| Box::new(w) as _) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | .map(|w| Box::new(w) as _) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 59 | .map_err(|err| CriticalError::FsWatcherInit { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | kind: self, [INFO] [stdout] 61 | err: if cfg!(target_os = "linux") [INFO] [stdout] | __________________^ [INFO] [stdout] 62 | | && (matches!(err.kind, notify::ErrorKind::MaxFilesWatch) [INFO] [stdout] 63 | | || matches!(err.kind, notify::ErrorKind::Io(ref ioerr) if ioerr.raw_os_error() == Some(28))) [INFO] [stdout] 64 | | { [INFO] [stdout] ... | [INFO] [stdout] 71 | | FsWatcherError::Create(err) [INFO] [stdout] 72 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sources/fs.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 262 | let nev = nev.map_err(|err| RuntimeError::FsWatcher { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | kind, [INFO] [stdout] 264 | err: FsWatcherError::Event(err), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changeable.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Self(Arc::new(RwLock::new(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changeable.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 79 | pub(crate) fn new(f: impl (Fn(T) -> U) + Send + Sync + 'static) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Self(Changeable::new(Arc::new(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changeable.rs:94:3 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn call(&self, data: T) -> U { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | (self.0.get())(data) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:249:46 [INFO] [stdout] | [INFO] [stdout] 245 | handler: impl (Fn(ActionHandler) -> ActionHandler) + Send + Sync + 'static, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | .replace(move |action| ActionReturn::Sync(handler(action))); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:263:47 [INFO] [stdout] | [INFO] [stdout] 256 | handler: impl (Fn(ActionHandler) -> Box + Send + Sync>) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | .replace(move |action| ActionReturn::Async(handler(action))); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:112:3 [INFO] [stdout] | [INFO] [stdout] 108 | action_handler: impl (Fn(ActionHandler) -> ActionHandler) + Send + Sync + 'static, [INFO] [stdout] | --------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ) -> Result, CriticalError> { [INFO] [stdout] 110 | let config = Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | config.on_action(action_handler); [INFO] [stdout] 112 | Self::with_config(config).map(Arc::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:126:3 [INFO] [stdout] | [INFO] [stdout] 119 | / action_handler: impl (Fn(ActionHandler) -> Box + Send + Sync>) [INFO] [stdout] 120 | | + Send [INFO] [stdout] 121 | | + Sync [INFO] [stdout] 122 | | + 'static, [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | ) -> Result, CriticalError> { [INFO] [stdout] 124 | let config = Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | config.on_action_async(action_handler); [INFO] [stdout] 126 | Self::with_config(config).map(Arc::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:194:6 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn with_config(config: Config) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | debug!(?config, pid=%std::process::id(), version=%env!("CARGO_PKG_VERSION"), "initialising"); [INFO] [stdout] 137 | let config = Arc::new(config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let outer_config = config.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | [INFO] [stdout] 140 | let notify = Arc::new(Notify::new()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let start_lock = notify.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | [INFO] [stdout] 143 | let (ev_s, ev_r) = [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | priority::bounded(config.event_channel_size.try_into().unwrap_or(u64::MAX)); [INFO] [stdout] 145 | let event_input = ev_s.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let handle = spawn(async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | config: outer_config, [INFO] [stdout] 196 | | start_lock, [INFO] [stdout] 197 | | event_input, [INFO] [stdout] 198 | | handle: Arc::new(AtomicTake::new(handle)), [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:270:14 [INFO] [stdout] | [INFO] [stdout] 267 | fn new(error: RuntimeError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | critical: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchexec.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 274 | fn handle_crit(crit: Arc>) -> Result<(), CriticalError> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | match Arc::try_unwrap(crit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `watchexec` (lib test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "84a80e801767c44afaac00f024281c4e06f3b5895c6b60e41b9dbb6f6b71d9c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84a80e801767c44afaac00f024281c4e06f3b5895c6b60e41b9dbb6f6b71d9c2", kill_on_drop: false }` [INFO] [stdout] 84a80e801767c44afaac00f024281c4e06f3b5895c6b60e41b9dbb6f6b71d9c2