[INFO] fetching crate watchable 1.1.2... [INFO] checking watchable-1.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate watchable 1.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate watchable 1.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate watchable 1.1.2 [INFO] finished tweaking crates.io crate watchable 1.1.2 [INFO] tweaked toml for crates.io crate watchable 1.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate watchable 1.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4737bf636dd2a5b856a74aa510c2cf493802abb295e0ade84b1c837a614763f2 [INFO] running `Command { std: "docker" "start" "-a" "4737bf636dd2a5b856a74aa510c2cf493802abb295e0ade84b1c837a614763f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4737bf636dd2a5b856a74aa510c2cf493802abb295e0ade84b1c837a614763f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4737bf636dd2a5b856a74aa510c2cf493802abb295e0ade84b1c837a614763f2", kill_on_drop: false }` [INFO] [stdout] 4737bf636dd2a5b856a74aa510c2cf493802abb295e0ade84b1c837a614763f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23ba43f25257220cfe6ab9a244430bc472103239f503898c63f0795a13ff7750 [INFO] running `Command { std: "docker" "start" "-a" "23ba43f25257220cfe6ab9a244430bc472103239f503898c63f0795a13ff7750", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling thiserror v1.0.52 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking event-listener v4.0.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.43 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.52 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking watchable v1.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(initial_value: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Self { [INFO] [stdout] 56 | data: Arc::new(Data { [INFO] [stdout] | ___________________^ [INFO] [stdout] 57 | | value: RwLock::new(initial_value), [INFO] [stdout] 58 | | changed: RwLock::new(Some(Event::new())), [INFO] [stdout] 59 | | version: AtomicUsize::new(0), [INFO] [stdout] 60 | | watchers: AtomicUsize::new(0), [INFO] [stdout] 61 | | watchables: AtomicUsize::new(1), [INFO] [stdout] 62 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:503:31 [INFO] [stdout] | [INFO] [stdout] 503 | self.watch().map(|()| self.read().clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:43 [INFO] [stdout] | [INFO] [stdout] 522 | self.watch_async().await.map(|()| self.read().clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:529:23 [INFO] [stdout] | [INFO] [stdout] 526 | pub fn into_stream(self) -> WatcherStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | listener: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `watchable` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(initial_value: T) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Self { [INFO] [stdout] 56 | data: Arc::new(Data { [INFO] [stdout] | ___________________^ [INFO] [stdout] 57 | | value: RwLock::new(initial_value), [INFO] [stdout] 58 | | changed: RwLock::new(Some(Event::new())), [INFO] [stdout] 59 | | version: AtomicUsize::new(0), [INFO] [stdout] 60 | | watchers: AtomicUsize::new(0), [INFO] [stdout] 61 | | watchables: AtomicUsize::new(1), [INFO] [stdout] 62 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:503:31 [INFO] [stdout] | [INFO] [stdout] 503 | self.watch().map(|()| self.read().clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:43 [INFO] [stdout] | [INFO] [stdout] 522 | self.watch_async().await.map(|()| self.read().clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:529:23 [INFO] [stdout] | [INFO] [stdout] 526 | pub fn into_stream(self) -> WatcherStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | listener: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:763:10 [INFO] [stdout] | [INFO] [stdout] 756 | let watcher = watchable.watch(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 757 | let (sender, receiver) = std::sync::mpsc::sync_channel(1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 763 | *watcher.read() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `watchable` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "23ba43f25257220cfe6ab9a244430bc472103239f503898c63f0795a13ff7750", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23ba43f25257220cfe6ab9a244430bc472103239f503898c63f0795a13ff7750", kill_on_drop: false }` [INFO] [stdout] 23ba43f25257220cfe6ab9a244430bc472103239f503898c63f0795a13ff7750