[INFO] fetching crate wasmtime-fiber 24.0.0... [INFO] checking wasmtime-fiber-24.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wasmtime-fiber 24.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate wasmtime-fiber 24.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wasmtime-fiber 24.0.0 [INFO] finished tweaking crates.io crate wasmtime-fiber 24.0.0 [INFO] tweaked toml for crates.io crate wasmtime-fiber 24.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58dc965c9b9463466cb5ebcb4251b6e6e76cee23ca009ac932795becbe6ed0eb [INFO] running `Command { std: "docker" "start" "-a" "58dc965c9b9463466cb5ebcb4251b6e6e76cee23ca009ac932795becbe6ed0eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58dc965c9b9463466cb5ebcb4251b6e6e76cee23ca009ac932795becbe6ed0eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58dc965c9b9463466cb5ebcb4251b6e6e76cee23ca009ac932795becbe6ed0eb", kill_on_drop: false }` [INFO] [stdout] 58dc965c9b9463466cb5ebcb4251b6e6e76cee23ca009ac932795becbe6ed0eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c22a4234f81d1b3b92426577d7d2b8f596b48cbfb6916a95b166964efd12e6e7 [INFO] running `Command { std: "docker" "start" "-a" "c22a4234f81d1b3b92426577d7d2b8f596b48cbfb6916a95b166964efd12e6e7", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking wasmtime-asm-macros v24.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Compiling wasmtime-versioned-export-macros v24.0.0 [INFO] [stderr] Compiling wasmtime-fiber v24.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn from_custom(custom: Box) -> io::Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(Self(imp::FiberStack::from_custom(custom)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 117 | stack: FiberStack, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | func: impl FnOnce(Resume, &mut Suspend) -> Return + 'a, [INFO] [stdout] | ----------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 123 | | stack: Some(stack), [INFO] [stdout] 124 | | inner, [INFO] [stdout] 125 | | done: Cell::new(false), [INFO] [stdout] 126 | | _phantom: PhantomData, [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:15 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn resume(&self, val: Resume) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | assert!(!self.done.replace(true), "cannot resume a finished fiber"); [INFO] [stdout] 147 | let result = Cell::new(RunResult::Resuming(val)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | self.inner.resume(&self.stack().0, &result); [INFO] [stdout] 149 | match result.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn into_stack(mut self) -> FiberStack { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | assert!(self.done()); [INFO] [stdout] 173 | self.stack.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:46 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn suspend(&mut self, value: Yield) -> Resume { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | self.inner [INFO] [stdout] 189 | .switch::(RunResult::Yield(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 61 | let stack = MmapFiberStack::new(size)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(FiberStack { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | base: stack.mapping_base.wrapping_byte_add(page_size), [INFO] [stdout] 68 | | len: stack.mapping_len - page_size, [INFO] [stdout] 69 | | storage: FiberStackStorage::Mmap(stack), [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn from_custom(custom: Box) -> io::Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(FiberStack { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | base: start_ptr, [INFO] [stdout] 105 | | len: range.len(), [INFO] [stdout] 106 | | storage: FiberStackStorage::Custom(custom), [INFO] [stdout] 107 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmtime-fiber` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn from_custom(custom: Box) -> io::Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(Self(imp::FiberStack::from_custom(custom)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 117 | stack: FiberStack, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | func: impl FnOnce(Resume, &mut Suspend) -> Return + 'a, [INFO] [stdout] | ----------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 123 | | stack: Some(stack), [INFO] [stdout] 124 | | inner, [INFO] [stdout] 125 | | done: Cell::new(false), [INFO] [stdout] 126 | | _phantom: PhantomData, [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:15 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn resume(&self, val: Resume) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | assert!(!self.done.replace(true), "cannot resume a finished fiber"); [INFO] [stdout] 147 | let result = Cell::new(RunResult::Resuming(val)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | self.inner.resume(&self.stack().0, &result); [INFO] [stdout] 149 | match result.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn into_stack(mut self) -> FiberStack { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | assert!(self.done()); [INFO] [stdout] 173 | self.stack.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:46 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn suspend(&mut self, value: Yield) -> Resume { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | self.inner [INFO] [stdout] 189 | .switch::(RunResult::Yield(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 61 | let stack = MmapFiberStack::new(size)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(FiberStack { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | base: stack.mapping_base.wrapping_byte_add(page_size), [INFO] [stdout] 68 | | len: stack.mapping_len - page_size, [INFO] [stdout] 69 | | storage: FiberStackStorage::Mmap(stack), [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn from_custom(custom: Box) -> io::Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(FiberStack { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | base: start_ptr, [INFO] [stdout] 105 | | len: range.len(), [INFO] [stdout] 106 | | storage: FiberStackStorage::Custom(custom), [INFO] [stdout] 107 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmtime-fiber` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "c22a4234f81d1b3b92426577d7d2b8f596b48cbfb6916a95b166964efd12e6e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c22a4234f81d1b3b92426577d7d2b8f596b48cbfb6916a95b166964efd12e6e7", kill_on_drop: false }` [INFO] [stdout] c22a4234f81d1b3b92426577d7d2b8f596b48cbfb6916a95b166964efd12e6e7