[INFO] fetching crate wasmium-securemem 0.2.1... [INFO] checking wasmium-securemem-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wasmium-securemem 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate wasmium-securemem 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wasmium-securemem 0.2.1 [INFO] finished tweaking crates.io crate wasmium-securemem 0.2.1 [INFO] tweaked toml for crates.io crate wasmium-securemem 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding aead v0.4.3 (latest: v0.5.2) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding bs58 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding chacha20 v0.8.2 (latest: v0.9.1) [INFO] [stderr] Adding chacha20poly1305 v0.9.1 (latest: v0.10.1) [INFO] [stderr] Adding cipher v0.3.0 (latest: v0.4.4) [INFO] [stderr] Adding curve25519-dalek v3.2.0 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding nanorand v0.6.1 (latest: v0.7.0) [INFO] [stderr] Adding poly1305 v0.7.2 (latest: v0.8.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding universal-hash v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d9c9672497343dca2a3aca55c820f34502d54108c15e774af8e5dfe59d038d6 [INFO] running `Command { std: "docker" "start" "-a" "6d9c9672497343dca2a3aca55c820f34502d54108c15e774af8e5dfe59d038d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d9c9672497343dca2a3aca55c820f34502d54108c15e774af8e5dfe59d038d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d9c9672497343dca2a3aca55c820f34502d54108c15e774af8e5dfe59d038d6", kill_on_drop: false }` [INFO] [stdout] 6d9c9672497343dca2a3aca55c820f34502d54108c15e774af8e5dfe59d038d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4bbbc5d311541ce29072900a73558fb444e2040bb4936d0fc595882fc1a026dd [INFO] running `Command { std: "docker" "start" "-a" "4bbbc5d311541ce29072900a73558fb444e2040bb4936d0fc595882fc1a026dd", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking nanorand v0.6.1 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking wasmium_errors v1.0.3 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking wasmium-random v1.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking poly1305 v0.7.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking chacha20 v0.8.2 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking chacha20poly1305 v0.9.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking wasmium-securemem v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `prekey_vault::*` [INFO] [stdout] --> src/lib.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub use prekey_vault::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prekey_vault.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 48 | let sealing_key = EncryptedVault::sealing_key(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let key = Key::from_slice(sealing_key.expose_secret().0.as_bytes()); // 32-bytes [INFO] [stdout] 50 | let aead = XChaCha8Poly1305::new(key); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | let random_nonce = Secret::new(WasmiumRandom::secure_alphanumeric24()); // Can be public [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let nonce = XNonce::from_slice(random_nonce.expose_secret()); // 24-bytes; unique [INFO] [stdout] 54 | let ciphertext = match aead.encrypt(nonce, &user_secrets.0.to_bytes()[..]) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(EncryptedVault { [INFO] [stdout] | ________________^ [INFO] [stdout] 62 | | secret: ciphertext, [INFO] [stdout] 63 | | nonce: random_nonce, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protected_keypair.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | let secret = SecretKey::from_bytes(&[0_u8; 32]).unwrap(); // Never fails hence `.unwrap()` [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | let keypair = Keypair { secret, public }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | Ok(ProtectedEd25519KeyPair(keypair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `prekey_vault::*` [INFO] [stdout] --> src/lib.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub use prekey_vault::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmium-securemem` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prekey_vault.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 48 | let sealing_key = EncryptedVault::sealing_key(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let key = Key::from_slice(sealing_key.expose_secret().0.as_bytes()); // 32-bytes [INFO] [stdout] 50 | let aead = XChaCha8Poly1305::new(key); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | let random_nonce = Secret::new(WasmiumRandom::secure_alphanumeric24()); // Can be public [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let nonce = XNonce::from_slice(random_nonce.expose_secret()); // 24-bytes; unique [INFO] [stdout] 54 | let ciphertext = match aead.encrypt(nonce, &user_secrets.0.to_bytes()[..]) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(EncryptedVault { [INFO] [stdout] | ________________^ [INFO] [stdout] 62 | | secret: ciphertext, [INFO] [stdout] 63 | | nonce: random_nonce, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protected_keypair.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | let secret = SecretKey::from_bytes(&[0_u8; 32]).unwrap(); // Never fails hence `.unwrap()` [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | let keypair = Keypair { secret, public }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | Ok(ProtectedEd25519KeyPair(keypair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmium-securemem` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4bbbc5d311541ce29072900a73558fb444e2040bb4936d0fc595882fc1a026dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bbbc5d311541ce29072900a73558fb444e2040bb4936d0fc595882fc1a026dd", kill_on_drop: false }` [INFO] [stdout] 4bbbc5d311541ce29072900a73558fb444e2040bb4936d0fc595882fc1a026dd