[INFO] fetching crate wasmi_runtime_layer 0.36.0... [INFO] checking wasmi_runtime_layer-0.36.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wasmi_runtime_layer 0.36.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate wasmi_runtime_layer 0.36.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wasmi_runtime_layer 0.36.0 [INFO] finished tweaking crates.io crate wasmi_runtime_layer 0.36.0 [INFO] tweaked toml for crates.io crate wasmi_runtime_layer 0.36.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56e068e072e79587ec043e21ed1d09f76aba0b4cb6493af54bfa550187655cab [INFO] running `Command { std: "docker" "start" "-a" "56e068e072e79587ec043e21ed1d09f76aba0b4cb6493af54bfa550187655cab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56e068e072e79587ec043e21ed1d09f76aba0b4cb6493af54bfa550187655cab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56e068e072e79587ec043e21ed1d09f76aba0b4cb6493af54bfa550187655cab", kill_on_drop: false }` [INFO] [stdout] 56e068e072e79587ec043e21ed1d09f76aba0b4cb6493af54bfa550187655cab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96ac122604379de6e60fe2f8c990876db087d220eb455c7f2cba0e49a6e1cc08 [INFO] running `Command { std: "docker" "start" "-a" "96ac122604379de6e60fe2f8c990876db087d220eb455c7f2cba0e49a6e1cc08", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking indexmap-nostd v0.4.0 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking multi-stash v0.2.0 [INFO] [stderr] Checking wasmparser-nostd v0.100.2 [INFO] [stderr] Checking wasm_runtime_layer v0.4.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking wasmi_core v0.36.0 [INFO] [stderr] Checking string-interner v0.17.0 [INFO] [stderr] Checking wasmi_collections v0.36.0 [INFO] [stderr] Checking wasmi v0.36.0 [INFO] [stderr] Checking wasmi_runtime_layer v0.36.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 208 | mut ctx: impl AsContextMut, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | ty: FuncType, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | / func: impl 'static [INFO] [stdout] 211 | | + Send [INFO] [stdout] 212 | | + Sync [INFO] [stdout] 213 | | + Fn(StoreContextMut, &[Value], &mut [Value]) -> Result<()>, [INFO] [stdout] | |__________________________________________________________________________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | func_type_into(ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 208 | mut ctx: impl AsContextMut, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | ty: FuncType, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | / func: impl 'static [INFO] [stdout] 211 | | + Send [INFO] [stdout] 212 | | + Sync [INFO] [stdout] 213 | | + Fn(StoreContextMut, &[Value], &mut [Value]) -> Result<()>, [INFO] [stdout] | |__________________________________________________________________________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | / move |mut caller, args, results| { [INFO] [stdout] 219 | | let mut input = ArgumentVec::with_capacity(args.len()); [INFO] [stdout] 220 | | input.extend(args.iter().cloned().map(value_from)); [INFO] [stdout] ... | [INFO] [stdout] 237 | | Ok(()) [INFO] [stdout] 238 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:243:24 [INFO] [stdout] | [INFO] [stdout] 242 | fn ty(&self, ctx: impl AsContext) -> FuncType { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | func_type_from(self.as_ref().ty(ctx.as_context().into_inner())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(engine: &Engine, stream: impl std::io::Read) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | Ok(Self::new(Arc::new(wasmi::Module::new_streaming( [INFO] [stdout] | ____________^ [INFO] [stdout] 381 | | engine.as_ref(), [INFO] [stdout] 382 | | stream, [INFO] [stdout] 383 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:389:17 [INFO] [stdout] | [INFO] [stdout] 387 | Box::new(self.as_ref().exports().map(|x| ExportType { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | name: x.name(), [INFO] [stdout] 389 | ty: extern_type_from(x.ty().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 398 | Box::new(self.as_ref().imports().map(|x| ImportType { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | ty: extern_type_from(x.ty().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:408:19 [INFO] [stdout] | [INFO] [stdout] 407 | fn new(engine: &Engine, data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | Self::new(wasmi::Store::new(engine.as_ref(), data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 423 | fn into_data(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | self.into_inner().into_data() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 208 | mut ctx: impl AsContextMut, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | ty: FuncType, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | / func: impl 'static [INFO] [stdout] 211 | | + Send [INFO] [stdout] 212 | | + Sync [INFO] [stdout] 213 | | + Fn(StoreContextMut, &[Value], &mut [Value]) -> Result<()>, [INFO] [stdout] | |__________________________________________________________________________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | func_type_into(ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 208 | mut ctx: impl AsContextMut, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | ty: FuncType, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | / func: impl 'static [INFO] [stdout] 211 | | + Send [INFO] [stdout] 212 | | + Sync [INFO] [stdout] 213 | | + Fn(StoreContextMut, &[Value], &mut [Value]) -> Result<()>, [INFO] [stdout] | |__________________________________________________________________________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | / move |mut caller, args, results| { [INFO] [stdout] 219 | | let mut input = ArgumentVec::with_capacity(args.len()); [INFO] [stdout] 220 | | input.extend(args.iter().cloned().map(value_from)); [INFO] [stdout] ... | [INFO] [stdout] 237 | | Ok(()) [INFO] [stdout] 238 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:243:24 [INFO] [stdout] | [INFO] [stdout] 242 | fn ty(&self, ctx: impl AsContext) -> FuncType { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | func_type_from(self.as_ref().ty(ctx.as_context().into_inner())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 379 | fn new(engine: &Engine, stream: impl std::io::Read) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | Ok(Self::new(Arc::new(wasmi::Module::new_streaming( [INFO] [stdout] | ____________^ [INFO] [stdout] 381 | | engine.as_ref(), [INFO] [stdout] 382 | | stream, [INFO] [stdout] 383 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:389:17 [INFO] [stdout] | [INFO] [stdout] 387 | Box::new(self.as_ref().exports().map(|x| ExportType { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | name: x.name(), [INFO] [stdout] 389 | ty: extern_type_from(x.ty().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 398 | Box::new(self.as_ref().imports().map(|x| ImportType { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | ty: extern_type_from(x.ty().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:408:19 [INFO] [stdout] | [INFO] [stdout] 407 | fn new(engine: &Engine, data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | Self::new(wasmi::Store::new(engine.as_ref(), data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 423 | fn into_data(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | self.into_inner().into_data() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmi_runtime_layer` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `wasmi_runtime_layer` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "96ac122604379de6e60fe2f8c990876db087d220eb455c7f2cba0e49a6e1cc08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96ac122604379de6e60fe2f8c990876db087d220eb455c7f2cba0e49a6e1cc08", kill_on_drop: false }` [INFO] [stdout] 96ac122604379de6e60fe2f8c990876db087d220eb455c7f2cba0e49a6e1cc08