[INFO] fetching crate wasmflow-traits 0.10.0... [INFO] checking wasmflow-traits-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wasmflow-traits 0.10.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate wasmflow-traits 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wasmflow-traits 0.10.0 [INFO] finished tweaking crates.io crate wasmflow-traits 0.10.0 [INFO] tweaked toml for crates.io crate wasmflow-traits 0.10.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 112 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6b2a58a01c6e442b6e0f307cf8549f114f702a6be0576f75f8c1a30611962c3 [INFO] running `Command { std: "docker" "start" "-a" "b6b2a58a01c6e442b6e0f307cf8549f114f702a6be0576f75f8c1a30611962c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6b2a58a01c6e442b6e0f307cf8549f114f702a6be0576f75f8c1a30611962c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6b2a58a01c6e442b6e0f307cf8549f114f702a6be0576f75f8c1a30611962c3", kill_on_drop: false }` [INFO] [stdout] b6b2a58a01c6e442b6e0f307cf8549f114f702a6be0576f75f8c1a30611962c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e54b7d0828b92fee6addd7d8ec51945d5f22b330f5d80c92bfb4501a2af6138 [INFO] running `Command { std: "docker" "start" "-a" "6e54b7d0828b92fee6addd7d8ec51945d5f22b330f5d80c92bfb4501a2af6138", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wasmflow-macros v0.10.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking wasmflow-codec v0.10.0 [INFO] [stderr] Checking wasmflow-packet v0.10.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking wasmflow-transport v0.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking wasmflow-streams v0.10.0 [INFO] [stderr] Checking wasmflow-traits v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/lib.rs:41:3 [INFO] [stdout] | [INFO] [stdout] 41 | const_err, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/lib.rs:41:3 [INFO] [stdout] | [INFO] [stdout] 41 | const_err, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> src/lib.rs:55:3 [INFO] [stdout] | [INFO] [stdout] 55 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC for more information [INFO] [stdout] --> src/lib.rs:55:3 [INFO] [stdout] | [INFO] [stdout] 55 | private_in_public, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 13 | fn send_message(port: &PortChannel, name: impl AsRef, packet: Packet) -> Result { [INFO] [stdout] | --------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | port.send(PacketWrapper { [INFO] [stdout] | _____________^ [INFO] [stdout] 15 | | payload: packet, [INFO] [stdout] 16 | | port: name.as_ref().to_owned(), [INFO] [stdout] 17 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 35 | fn done(&self, data: Self::PayloadType) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | send_message(port, name, Packet::V1(V1::done())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 43 | fn done_message(&self, packet: Packet) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | send_message(port, name, Packet::V1(V1::done())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:55:30 [INFO] [stdout] | [INFO] [stdout] 55 | send_message(port, name, Packet::V1(V1::done())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new>(name: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | incoming: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 107 | let mut channels = StreamMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let stream = channels.map(|(_, packet)| packet); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | PacketStream::new(Box::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmflow-traits` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 13 | fn send_message(port: &PortChannel, name: impl AsRef, packet: Packet) -> Result { [INFO] [stdout] | --------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | port.send(PacketWrapper { [INFO] [stdout] | _____________^ [INFO] [stdout] 15 | | payload: packet, [INFO] [stdout] 16 | | port: name.as_ref().to_owned(), [INFO] [stdout] 17 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 35 | fn done(&self, data: Self::PayloadType) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | send_message(port, name, Packet::V1(V1::done())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 43 | fn done_message(&self, packet: Packet) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | send_message(port, name, Packet::V1(V1::done())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:55:30 [INFO] [stdout] | [INFO] [stdout] 55 | send_message(port, name, Packet::V1(V1::done())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new>(name: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | incoming: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable_port.rs:113:23 [INFO] [stdout] | [INFO] [stdout] 107 | let mut channels = StreamMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let stream = channels.map(|(_, packet)| packet); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | PacketStream::new(Box::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmflow-traits` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6e54b7d0828b92fee6addd7d8ec51945d5f22b330f5d80c92bfb4501a2af6138", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e54b7d0828b92fee6addd7d8ec51945d5f22b330f5d80c92bfb4501a2af6138", kill_on_drop: false }` [INFO] [stdout] 6e54b7d0828b92fee6addd7d8ec51945d5f22b330f5d80c92bfb4501a2af6138