[INFO] fetching crate wasmer-inline-c 0.1.2... [INFO] checking wasmer-inline-c-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wasmer-inline-c 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate wasmer-inline-c 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wasmer-inline-c 0.1.2 [INFO] finished tweaking crates.io crate wasmer-inline-c 0.1.2 [INFO] tweaked toml for crates.io crate wasmer-inline-c 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding assert_cmd v1.0.8 (latest: v2.0.16) [INFO] [stderr] Adding bstr v0.2.17 (latest: v1.10.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding predicates v2.1.5 (latest: v3.1.2) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding rustc_version v0.3.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.11.0 (latest: v1.0.23) [INFO] [stderr] Adding target-lexicon v0.11.2 (latest: v0.12.16) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24e48c78c5ca20aee480f601d4e3adf0d5c8654a0bfc0a3a671fcb6dcf02b026 [INFO] running `Command { std: "docker" "start" "-a" "24e48c78c5ca20aee480f601d4e3adf0d5c8654a0bfc0a3a671fcb6dcf02b026", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24e48c78c5ca20aee480f601d4e3adf0d5c8654a0bfc0a3a671fcb6dcf02b026", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24e48c78c5ca20aee480f601d4e3adf0d5c8654a0bfc0a3a671fcb6dcf02b026", kill_on_drop: false }` [INFO] [stdout] 24e48c78c5ca20aee480f601d4e3adf0d5c8654a0bfc0a3a671fcb6dcf02b026 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66d5b16661087fc634987053690b0ba127eccbde3acfe6fe0426ea78c313a38c [INFO] running `Command { std: "docker" "start" "-a" "66d5b16661087fc634987053690b0ba127eccbde3acfe6fe0426ea78c313a38c", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling target-lexicon v0.11.2 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking cc v1.1.15 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking assert_cmd v1.0.8 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Compiling wasmer-inline-c-macro v0.1.6 [INFO] [stderr] Checking wasmer-inline-c v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `cppflags` [INFO] [stdout] --> src/lib.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let cppflags = get_env_flags(&variables, "CPPFLAGS"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cppflags` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cxxflags` [INFO] [stdout] --> src/lib.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | let cxxflags = get_env_flags(&variables, "CXXFLAGS"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cxxflags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cppflags` [INFO] [stdout] --> src/lib.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let cppflags = get_env_flags(&variables, "CPPFLAGS"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cppflags` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cxxflags` [INFO] [stdout] --> src/lib.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | let cxxflags = get_env_flags(&variables, "CXXFLAGS"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cxxflags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn new(command: Command, files_to_remove: Option>) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { [INFO] [stdout] 14 | command: assert_cmd::Command::from_std(command), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 79 | let mut program_file = tempfile::Builder::new() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let mut build = cc::Build::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut command = compiler.to_command(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let regex = regex::Regex::new(INCLUDE_REGEX).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Assert::new(command, Some(files_to_remove))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn new(command: Command, files_to_remove: Option>) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { [INFO] [stdout] 14 | command: assert_cmd::Command::from_std(command), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 79 | let mut program_file = tempfile::Builder::new() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let mut build = cc::Build::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut command = compiler.to_command(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let regex = regex::Regex::new(INCLUDE_REGEX).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Assert::new(command, Some(files_to_remove))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:280:64 [INFO] [stdout] | [INFO] [stdout] 280 | if let Ok(symlink) = std::fs::read_to_string(parent.clone().join(&file)) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 280 - if let Ok(symlink) = std::fs::read_to_string(parent.clone().join(&file)) { [INFO] [stdout] 280 + if let Ok(symlink) = std::fs::read_to_string(parent.join(&file)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:294:38 [INFO] [stdout] | [INFO] [stdout] 294 | let path = parent.clone().join(s); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 294 - let path = parent.clone().join(s); [INFO] [stdout] 294 + let path = parent.join(s); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:280:64 [INFO] [stdout] | [INFO] [stdout] 280 | if let Ok(symlink) = std::fs::read_to_string(parent.clone().join(&file)) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 280 - if let Ok(symlink) = std::fs::read_to_string(parent.clone().join(&file)) { [INFO] [stdout] 280 + if let Ok(symlink) = std::fs::read_to_string(parent.join(&file)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:294:38 [INFO] [stdout] | [INFO] [stdout] 294 | let path = parent.clone().join(s); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 294 - let path = parent.clone().join(s); [INFO] [stdout] 294 + let path = parent.join(s); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmer-inline-c` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `wasmer-inline-c` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "66d5b16661087fc634987053690b0ba127eccbde3acfe6fe0426ea78c313a38c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66d5b16661087fc634987053690b0ba127eccbde3acfe6fe0426ea78c313a38c", kill_on_drop: false }` [INFO] [stdout] 66d5b16661087fc634987053690b0ba127eccbde3acfe6fe0426ea78c313a38c