[INFO] fetching crate wasmdbg 0.1.0... [INFO] checking wasmdbg-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wasmdbg 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate wasmdbg 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wasmdbg 0.1.0 [INFO] finished tweaking crates.io crate wasmdbg 0.1.0 [INFO] tweaked toml for crates.io crate wasmdbg 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate wasmdbg 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 279fec39b9c25e5326a8c41cc013d4f8a771533c13cde800b84b7a6add121a1f [INFO] running `Command { std: "docker" "start" "-a" "279fec39b9c25e5326a8c41cc013d4f8a771533c13cde800b84b7a6add121a1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "279fec39b9c25e5326a8c41cc013d4f8a771533c13cde800b84b7a6add121a1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "279fec39b9c25e5326a8c41cc013d4f8a771533c13cde800b84b7a6add121a1f", kill_on_drop: false }` [INFO] [stdout] 279fec39b9c25e5326a8c41cc013d4f8a771533c13cde800b84b7a6add121a1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8078369b809631dbc0778047b4fc5f48b3aab20b908c404d4a05887c28be6d5 [INFO] running `Command { std: "docker" "start" "-a" "a8078369b809631dbc0778047b4fc5f48b3aab20b908c404d4a05887c28be6d5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling winapi v0.3.8 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking smallstr v0.1.0 [INFO] [stderr] Checking rgb v0.8.14 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking parity-wasm v0.40.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking shellexpand v1.0.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking terminal_size v0.1.8 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking wasmi-validation v0.2.0 [INFO] [stderr] Checking backtrace v0.3.38 [INFO] [stderr] Compiling terminfo v0.6.1 [INFO] [stderr] Checking winconsole v0.10.0 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking colored v1.8.0 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking mortal v0.2.1 [INFO] [stderr] Checking linefeed v0.6.0 [INFO] [stderr] Checking wasmdbg v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/vm.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | (self.data.len() as u32 / PAGE_SIZE) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 162 - (self.data.len() as u32 / PAGE_SIZE) [INFO] [stdout] 162 + self.data.len() as u32 / PAGE_SIZE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/vm.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | (self.data.len() as u32 / PAGE_SIZE) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 162 - (self.data.len() as u32 / PAGE_SIZE) [INFO] [stdout] 162 + self.data.len() as u32 / PAGE_SIZE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 190 | Ok(T::from_little_endian(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn new(module: Rc, breakpoints: Rc>) -> Result { [INFO] [stdout] | ------------------ ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | Ok(VM { [INFO] [stdout] | ____________^ [INFO] [stdout] 293 | | module, [INFO] [stdout] 294 | | memory, [INFO] [stdout] 295 | | table, [INFO] [stdout] ... | [INFO] [stdout] 302 | | breakpoints, [INFO] [stdout] 303 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:954:63 [INFO] [stdout] | [INFO] [stdout] 954 | self.unop_try(|x: F32| x.trunc_to_u32().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:960:63 [INFO] [stdout] | [INFO] [stdout] 960 | self.unop_try(|x: F64| x.trunc_to_u32().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:968:63 [INFO] [stdout] | [INFO] [stdout] 968 | self.unop_try(|x: F32| x.trunc_to_u64().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:974:63 [INFO] [stdout] | [INFO] [stdout] 974 | self.unop_try(|x: F64| x.trunc_to_u64().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/mod.rs:446:45 [INFO] [stdout] | [INFO] [stdout] 297 | fn from_parity_module(module: parity_wasm::elements::Module) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | // TODO: What happens when multiple functions have the same name? [INFO] [stdout] 299 | let module = match module.parse_names() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | Ok(module) => module, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | Err((errors, module)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | let mut functions = Vec::with_capacity(func_count); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | custom_sections: Vec::from_iter(module.custom_sections().cloned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 190 | Ok(T::from_little_endian(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn new(module: Rc, breakpoints: Rc>) -> Result { [INFO] [stdout] | ------------------ ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | Ok(VM { [INFO] [stdout] | ____________^ [INFO] [stdout] 293 | | module, [INFO] [stdout] 294 | | memory, [INFO] [stdout] 295 | | table, [INFO] [stdout] ... | [INFO] [stdout] 302 | | breakpoints, [INFO] [stdout] 303 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:954:63 [INFO] [stdout] | [INFO] [stdout] 954 | self.unop_try(|x: F32| x.trunc_to_u32().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:960:63 [INFO] [stdout] | [INFO] [stdout] 960 | self.unop_try(|x: F64| x.trunc_to_u32().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:968:63 [INFO] [stdout] | [INFO] [stdout] 968 | self.unop_try(|x: F32| x.trunc_to_u64().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:974:63 [INFO] [stdout] | [INFO] [stdout] 974 | self.unop_try(|x: F64| x.trunc_to_u64().ok_or(Trap::InvalidConversionToInt))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/mod.rs:446:45 [INFO] [stdout] | [INFO] [stdout] 297 | fn from_parity_module(module: parity_wasm::elements::Module) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | // TODO: What happens when multiple functions have the same name? [INFO] [stdout] 299 | let module = match module.parse_names() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | Ok(module) => module, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | Err((errors, module)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | let mut functions = Vec::with_capacity(func_count); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | custom_sections: Vec::from_iter(module.custom_sections().cloned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wasmdbg` (lib test) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `wasmdbg` (lib) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a8078369b809631dbc0778047b4fc5f48b3aab20b908c404d4a05887c28be6d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8078369b809631dbc0778047b4fc5f48b3aab20b908c404d4a05887c28be6d5", kill_on_drop: false }` [INFO] [stdout] a8078369b809631dbc0778047b4fc5f48b3aab20b908c404d4a05887c28be6d5