[INFO] fetching crate warpack-formats 0.0.1... [INFO] checking warpack-formats-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate warpack-formats 0.0.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate warpack-formats 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate warpack-formats 0.0.1 [INFO] finished tweaking crates.io crate warpack-formats 0.0.1 [INFO] tweaked toml for crates.io crate warpack-formats 0.0.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding atoi v0.3.3 (latest: v2.0.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding byte-slice-cast v0.3.5 (latest: v1.2.2) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding rlua v0.16.3 (latest: v0.20.1) [INFO] [stderr] Adding slotmap v0.4.3 (latest: v1.0.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f10c43d7d3f75e551f120d01d03a0804c0de1b9c3b2ee726f7481622b4729a3 [INFO] running `Command { std: "docker" "start" "-a" "3f10c43d7d3f75e551f120d01d03a0804c0de1b9c3b2ee726f7481622b4729a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f10c43d7d3f75e551f120d01d03a0804c0de1b9c3b2ee726f7481622b4729a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f10c43d7d3f75e551f120d01d03a0804c0de1b9c3b2ee726f7481622b4729a3", kill_on_drop: false }` [INFO] [stdout] 3f10c43d7d3f75e551f120d01d03a0804c0de1b9c3b2ee726f7481622b4729a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bc116ed7175ca96b62e2d08bdc4c2d6b3efc7c01ae2fec45494fa0f60180d02 [INFO] running `Command { std: "docker" "start" "-a" "3bc116ed7175ca96b62e2d08bdc4c2d6b3efc7c01ae2fec45494fa0f60180d02", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking byte-slice-cast v0.3.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking atoi v0.3.3 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling rlua v0.16.3 [INFO] [stderr] Checking slotmap v0.4.3 [INFO] [stderr] Checking warpack-formats v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 81 | .and_then(|object| object.read().unwrap().aliased_id()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:284:26 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|o| o.read().unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:333:22 [INFO] [stdout] | [INFO] [stdout] 333 | .map(|o| o.read().unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:340:22 [INFO] [stdout] | [INFO] [stdout] 340 | .map(|o| o.read().unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:302:23 [INFO] [stdout] | [INFO] [stdout] 296 | fn find_named_field(&self, name: &str, closure: F) -> Option<&FieldDesc> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | .and_then(|v| self.find_field(v.iter().copied(), closure)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 305 | fn find_field(&self, iter: I, mut closure: F) -> Option<&FieldDesc> [INFO] [stdout] | ------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | iter.filter_map(|k| self.fields.get(k)).find(|f| closure(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warpack-formats` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 81 | .and_then(|object| object.read().unwrap().aliased_id()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:284:26 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|o| o.read().unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:333:22 [INFO] [stdout] | [INFO] [stdout] 333 | .map(|o| o.read().unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/w3obj.rs:340:22 [INFO] [stdout] | [INFO] [stdout] 340 | .map(|o| o.read().unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:302:23 [INFO] [stdout] | [INFO] [stdout] 296 | fn find_named_field(&self, name: &str, closure: F) -> Option<&FieldDesc> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | .and_then(|v| self.find_field(v.iter().copied(), closure)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 305 | fn find_field(&self, iter: I, mut closure: F) -> Option<&FieldDesc> [INFO] [stdout] | ------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | iter.filter_map(|k| self.fields.get(k)).find(|f| closure(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warpack-formats` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3bc116ed7175ca96b62e2d08bdc4c2d6b3efc7c01ae2fec45494fa0f60180d02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bc116ed7175ca96b62e2d08bdc4c2d6b3efc7c01ae2fec45494fa0f60180d02", kill_on_drop: false }` [INFO] [stdout] 3bc116ed7175ca96b62e2d08bdc4c2d6b3efc7c01ae2fec45494fa0f60180d02