[INFO] fetching crate warp-dir 0.1.0... [INFO] checking warp-dir-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate warp-dir 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate warp-dir 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate warp-dir 0.1.0 [INFO] finished tweaking crates.io crate warp-dir 0.1.0 [INFO] tweaked toml for crates.io crate warp-dir 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate warp-dir 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e03143cb07343af3764cce1772c464c8a5d1758bb669db0ff9631a206969da1 [INFO] running `Command { std: "docker" "start" "-a" "5e03143cb07343af3764cce1772c464c8a5d1758bb669db0ff9631a206969da1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e03143cb07343af3764cce1772c464c8a5d1758bb669db0ff9631a206969da1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e03143cb07343af3764cce1772c464c8a5d1758bb669db0ff9631a206969da1", kill_on_drop: false }` [INFO] [stdout] 5e03143cb07343af3764cce1772c464c8a5d1758bb669db0ff9631a206969da1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b7fa579543a3a3ad583b1086e8fea2bbc4996d8b4f21104d5ef459ba85cdbc3 [INFO] running `Command { std: "docker" "start" "-a" "2b7fa579543a3a3ad583b1086e8fea2bbc4996d8b4f21104d5ef459ba85cdbc3", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.7 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking path-dedot v3.1.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Compiling indoc v2.0.3 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking path-absolutize v3.1.0 [INFO] [stderr] Checking etcetera v0.8.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking bstr v1.6.0 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking clap_complete v4.3.2 [INFO] [stderr] Checking warp-dir v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 93 | .map(|(pv, help)| PossibleValue::new(pv).help(help.to_str())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:197:38 [INFO] [stdout] | [INFO] [stdout] 197 | let mut target_file = target_file.deref().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `TargetsFile` does not implement `Deref`, so calling `deref` on `&TargetsFile` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - let mut target_file = target_file.deref().clone(); [INFO] [stdout] 197 + let mut target_file = target_file.clone(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `TargetsFile`, implement `Clone` for it [INFO] [stdout] --> src/target.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Clone)] [INFO] [stdout] 34 | pub struct TargetsFile { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warp-dir` (bin "wd" test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 93 | .map(|(pv, help)| PossibleValue::new(pv).help(help.to_str())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:197:38 [INFO] [stdout] | [INFO] [stdout] 197 | let mut target_file = target_file.deref().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `TargetsFile` does not implement `Deref`, so calling `deref` on `&TargetsFile` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 197 - let mut target_file = target_file.deref().clone(); [INFO] [stdout] 197 + let mut target_file = target_file.clone(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `TargetsFile`, implement `Clone` for it [INFO] [stdout] --> src/target.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Clone)] [INFO] [stdout] 34 | pub struct TargetsFile { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `warp-dir` (bin "wd") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2b7fa579543a3a3ad583b1086e8fea2bbc4996d8b4f21104d5ef459ba85cdbc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b7fa579543a3a3ad583b1086e8fea2bbc4996d8b4f21104d5ef459ba85cdbc3", kill_on_drop: false }` [INFO] [stdout] 2b7fa579543a3a3ad583b1086e8fea2bbc4996d8b4f21104d5ef459ba85cdbc3