[INFO] fetching crate war 0.2.0... [INFO] checking war-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate war 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate war 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate war 0.2.0 [INFO] finished tweaking crates.io crate war 0.2.0 [INFO] tweaked toml for crates.io crate war 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding byteordered v0.4.1 (latest: v0.6.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num_enum v0.4.3 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.4.3 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scroll v0.9.2 (latest: v0.12.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92364c1b72367722645755f46114b20bb7aa437d3442fb0a392542d2313ac376 [INFO] running `Command { std: "docker" "start" "-a" "92364c1b72367722645755f46114b20bb7aa437d3442fb0a392542d2313ac376", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92364c1b72367722645755f46114b20bb7aa437d3442fb0a392542d2313ac376", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92364c1b72367722645755f46114b20bb7aa437d3442fb0a392542d2313ac376", kill_on_drop: false }` [INFO] [stdout] 92364c1b72367722645755f46114b20bb7aa437d3442fb0a392542d2313ac376 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8fff3d706474dbbe25f2fd6119c6b86406e4040612e620a3997aa62792fa4d37 [INFO] running `Command { std: "docker" "start" "-a" "8fff3d706474dbbe25f2fd6119c6b86406e4040612e620a3997aa62792fa4d37", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling scroll v0.9.2 [INFO] [stderr] Checking byteordered v0.4.1 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling num_enum_derive v0.4.3 [INFO] [stderr] Checking num_enum v0.4.3 [INFO] [stderr] Checking war v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `OCClassManager__ScriptInfo`, `OCClassManager__ScriptUnpacked`, `ResBinHeader`, `ResourcePackageRead__ExtInfo`, `ResourcePackageRead__FileInfo`, and `WorldFactory__WorldInfo` [INFO] [stdout] --> src/darksiders1/gfc.rs:18:42 [INFO] [stdout] | [INFO] [stdout] 18 | worldfactory::{WorldFactory, WorldFactory__WorldInfo}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | OCClassManager__ScriptInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 36 | OCClassManager__ScriptUnpacked, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | ResourcePackageRead__ExtInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 71 | ResourcePackageRead__FileInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 72 | }, [INFO] [stdout] 73 | resourcepackagebin::{ResBinHeader, ResourcePackageBin}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:73 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_imports)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `OCClassManager__ScriptInfo`, `OCClassManager__ScriptUnpacked`, `ResBinHeader`, `ResourcePackageRead__ExtInfo`, `ResourcePackageRead__FileInfo`, and `WorldFactory__WorldInfo` [INFO] [stdout] --> src/darksiders1/gfc.rs:18:42 [INFO] [stdout] | [INFO] [stdout] 18 | worldfactory::{WorldFactory, WorldFactory__WorldInfo}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | OCClassManager__ScriptInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 36 | OCClassManager__ScriptUnpacked, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | ResourcePackageRead__ExtInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 71 | ResourcePackageRead__FileInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 72 | }, [INFO] [stdout] 73 | resourcepackagebin::{ResBinHeader, ResourcePackageBin}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:73 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(future_incompatible, rust_2018_compatibility, rust_2018_idioms, unused)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_imports)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `save_game_version`, `save_file_crc`, and `padding` are never read [INFO] [stdout] --> src/darksiders1/code/vigil/drivers/generic/save/keensavegamemanager.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct KeenSaveGameHeader { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 10 | pub header_name: [u8; 128], [INFO] [stdout] 11 | pub save_game_version: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | pub save_file_crc: u32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 13 | pub padding: [u8; 508], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/oc/occlassmanager.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 191 | pub struct OCClassManager__ScriptUnpacked { [INFO] [stdout] | ------------------------------ field in this struct [INFO] [stdout] 192 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `ext` are never read [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/world/resource/resourcecache.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ResourceLoadInfo<'b> { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 5 | pub name: &'b str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | pub ext: &'b str, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 16 | let values = data.values.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 19 | | classname: "WorldObjectData".to_string(), [INFO] [stdout] 20 | | properties: vec![ [INFO] [stdout] 21 | | prop!( [INFO] [stdout] ... | [INFO] [stdout] 27 | | ], [INFO] [stdout] 28 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 102 | let world_objects = data.world_objects.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 105 | | classname: "LayerData".to_string(), [INFO] [stdout] 106 | | properties: vec![ [INFO] [stdout] 107 | | prop!("LayerID", gfc::Value::Int(data.layer_id.into())), [INFO] [stdout] 108 | | prop!("WorldObjects", gfc::Value::Array(world_objects)), [INFO] [stdout] 109 | | ], [INFO] [stdout] 110 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 149 | let layers = data.layers.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 152 | | classname: "RegionData".to_string(), [INFO] [stdout] 153 | | properties: vec![ [INFO] [stdout] 154 | | prop!("RegionID", gfc::Value::Int(data.region_id.into())), [INFO] [stdout] 155 | | prop!("Layers", gfc::Value::Array(layers)), [INFO] [stdout] 156 | | ], [INFO] [stdout] 157 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:200:28 [INFO] [stdout] | [INFO] [stdout] 197 | let regions = data.regions.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | let values = data.values.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | [INFO] [stdout] 200 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 201 | | classname: "WorldData".to_string(), [INFO] [stdout] 202 | | properties: vec![ [INFO] [stdout] 203 | | prop!("World", gfc::Value::HString(data.world)), [INFO] [stdout] ... | [INFO] [stdout] 206 | | ], [INFO] [stdout] 207 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/io/binaryobjectreader.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 98 | let mut properties = Vec::with_capacity(count.try_into()?); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(gfc::Object { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | classname, [INFO] [stdout] 107 | | properties, [INFO] [stdout] 108 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/io/compressedinputstream.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | Ok(ZlibDecoder::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/io/compressedoutputstream.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 19 | let zstream = ZlibEncoder::new(out, Compression::best()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let inner = ByteOrdered::new(zstream, Endianness::Little); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | inner, [INFO] [stdout] 23 | | write_size_here, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/oc/occlassmanager.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | let mut stream = Self::get_stream(packfile, info)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(gfc::BinaryObjectReader::read_object(&mut stream)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/reflection/value.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn object(object: gfc::Object) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Self::Object(Arc::new(object)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/util/directorymanager.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(root: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let manifest_file = fs::File::open(&manifest)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let manifest_stream = io::BufReader::new(manifest_file); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut manifest_stream = ByteOrdered::le(manifest_stream); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | media_folder_string, [INFO] [stdout] 72 | | manifest_stream, [INFO] [stdout] 73 | | manifest_offsets, [INFO] [stdout] 74 | | manifest_length, [INFO] [stdout] 75 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/world/resource/resourcecache.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 78 | let object = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | gfc::BinaryObjectReader::read_object_from_buffer(load_info.buffers)?; [INFO] [stdout] 80 | Ok(gfc::ResourceData::Object(object)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 6 | root: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | ) -> Result<(Manifest, gfc::ResourcePackageList), Error> { [INFO] [stdout] 8 | let mut directory_manager = gfc::DirectoryManager::new(root)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let package_list = gfc::ResourceManager::init(&mut directory_manager)?; [INFO] [stdout] 10 | let manifest = Manifest { directory_manager }; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok((manifest, package_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sav/mod.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 28 | buffer: B, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ) -> gfc::KeenSaveGameManager { [INFO] [stdout] 30 | gfc::KeenSaveGameManager::new(gfc::SaveGameManagerParams { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 31 | | game_session: unit4::LocalGameSession::create(buffer), [INFO] [stdout] 32 | | game_name: "Darksiders Warfinitive Edition - All your save game are belong to \ [INFO] [stdout] 33 | | us!", [INFO] [stdout] 34 | | save_game_version: 0x0100_0000, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 13 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let value = De::default() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Arc::try_unwrap(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:19:40 [INFO] [stdout] | [INFO] [stdout] 19 | .map_err(|_| Error::custom(derailed()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:21:40 [INFO] [stdout] | [INFO] [stdout] 21 | .map_err(|_| Error::custom(derailed()))?; [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | fn value(&mut self, repr: repr::Value) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(match repr { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | repr::Value::Int { value } => gfc::Value::Int(value), [INFO] [stdout] 35 | | repr::Value::Float { value } => gfc::Value::Float(value), [INFO] [stdout] 36 | | repr::Value::Bool { value } => gfc::Value::Bool(value), [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:50:44 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|(key, value)| Ok((self.value(key)?, self.value(value)?))) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn object(&mut self, repr: repr::Object) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let properties = match repr.properties { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | repr::ObjectProperties::List(entries) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | repr::ObjectProperties::Map(entries) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let object = Arc::new(gfc::Object { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(gfc::Value::Object(object)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:75:45 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|(name, value)| Ok((name, self.value(value)?))) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:81:45 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(name, value)| Ok((name, self.value(value)?))) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let mut ser = Ser { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | ser.object(self).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:114:36 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|(k, v)| (self.value(k), self.value(v))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:114:51 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|(k, v)| (self.value(k), self.value(v))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:163:29 [INFO] [stdout] | [INFO] [stdout] 140 | let unique_properties = object [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let properties = if any_duplicate_keys { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let list = object [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let map = object [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | repr::Value::Object(repr::Object { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 164 | | id, [INFO] [stdout] 165 | | classname: object.classname.clone(), [INFO] [stdout] 166 | | properties, [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:151:53 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|(name, value)| (name.clone(), self.value(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:158:53 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|(name, value)| (name.clone(), self.value(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | ser_object(self.0).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:45:36 [INFO] [stdout] | [INFO] [stdout] 45 | .map(|(n, v)| (n.as_str(), ser_value(v))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 54 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | ser_script_class(self.0).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:66:36 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|p| (p.name.as_str(), ser_script_property(p))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:71:36 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|p| (p.name.as_str(), ser_script_static_property(p))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(n, v)| (n.as_str(), ser_value(v))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:86:36 [INFO] [stdout] | [INFO] [stdout] 86 | .map(|(n, s)| (n.as_str(), ser_script_state(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worlds/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn read(file: impl Read + Seek) -> Result, Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let mut files = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | let mut world_package = ByteOrdered::new(file, Endianness::Big); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(files [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | .into_iter() [INFO] [stdout] 81 | | // Unwrap the `Rc`s which we used to appease the borrow checker. [INFO] [stdout] 82 | | .map(|(p, o)| (p, Rc::try_unwrap(o).unwrap())) [INFO] [stdout] 83 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worlds/mod.rs:82:27 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(p, o)| (p, Rc::try_unwrap(o).unwrap())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `save_game_version`, `save_file_crc`, and `padding` are never read [INFO] [stdout] --> src/darksiders1/code/vigil/drivers/generic/save/keensavegamemanager.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct KeenSaveGameHeader { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 10 | pub header_name: [u8; 128], [INFO] [stdout] 11 | pub save_game_version: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | pub save_file_crc: u32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 13 | pub padding: [u8; 508], [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/oc/occlassmanager.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 191 | pub struct OCClassManager__ScriptUnpacked { [INFO] [stdout] | ------------------------------ field in this struct [INFO] [stdout] 192 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `ext` are never read [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/world/resource/resourcecache.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ResourceLoadInfo<'b> { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 5 | pub name: &'b str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | pub ext: &'b str, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 16 | let values = data.values.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 19 | | classname: "WorldObjectData".to_string(), [INFO] [stdout] 20 | | properties: vec![ [INFO] [stdout] 21 | | prop!( [INFO] [stdout] ... | [INFO] [stdout] 27 | | ], [INFO] [stdout] 28 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 102 | let world_objects = data.world_objects.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 105 | | classname: "LayerData".to_string(), [INFO] [stdout] 106 | | properties: vec![ [INFO] [stdout] 107 | | prop!("LayerID", gfc::Value::Int(data.layer_id.into())), [INFO] [stdout] 108 | | prop!("WorldObjects", gfc::Value::Array(world_objects)), [INFO] [stdout] 109 | | ], [INFO] [stdout] 110 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:151:28 [INFO] [stdout] | [INFO] [stdout] 149 | let layers = data.layers.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 152 | | classname: "RegionData".to_string(), [INFO] [stdout] 153 | | properties: vec![ [INFO] [stdout] 154 | | prop!("RegionID", gfc::Value::Int(data.region_id.into())), [INFO] [stdout] 155 | | prop!("Layers", gfc::Value::Array(layers)), [INFO] [stdout] 156 | | ], [INFO] [stdout] 157 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/darksiders/world/save/playersavedata.rs:200:28 [INFO] [stdout] | [INFO] [stdout] 197 | let regions = data.regions.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | let values = data.values.into_iter().map(Into::into).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | [INFO] [stdout] 200 | gfc::Value::Object(Arc::new(gfc::Object { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 201 | | classname: "WorldData".to_string(), [INFO] [stdout] 202 | | properties: vec![ [INFO] [stdout] 203 | | prop!("World", gfc::Value::HString(data.world)), [INFO] [stdout] ... | [INFO] [stdout] 206 | | ], [INFO] [stdout] 207 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/io/binaryobjectreader.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 98 | let mut properties = Vec::with_capacity(count.try_into()?); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(gfc::Object { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | classname, [INFO] [stdout] 107 | | properties, [INFO] [stdout] 108 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 36 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/io/compressedinputstream.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | Ok(ZlibDecoder::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/io/compressedoutputstream.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 19 | let zstream = ZlibEncoder::new(out, Compression::best()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let inner = ByteOrdered::new(zstream, Endianness::Little); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | inner, [INFO] [stdout] 23 | | write_size_here, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/oc/occlassmanager.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | let mut stream = Self::get_stream(packfile, info)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(gfc::BinaryObjectReader::read_object(&mut stream)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/reflection/value.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn object(object: gfc::Object) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Self::Object(Arc::new(object)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/util/directorymanager.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(root: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let manifest_file = fs::File::open(&manifest)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let manifest_stream = io::BufReader::new(manifest_file); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut manifest_stream = ByteOrdered::le(manifest_stream); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | media_folder_string, [INFO] [stdout] 72 | | manifest_stream, [INFO] [stdout] 73 | | manifest_offsets, [INFO] [stdout] 74 | | manifest_length, [INFO] [stdout] 75 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/darksiders1/code/vigil/gfc/world/resource/resourcecache.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 78 | let object = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | gfc::BinaryObjectReader::read_object_from_buffer(load_info.buffers)?; [INFO] [stdout] 80 | Ok(gfc::ResourceData::Object(object)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 6 | root: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | ) -> Result<(Manifest, gfc::ResourcePackageList), Error> { [INFO] [stdout] 8 | let mut directory_manager = gfc::DirectoryManager::new(root)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let package_list = gfc::ResourceManager::init(&mut directory_manager)?; [INFO] [stdout] 10 | let manifest = Manifest { directory_manager }; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok((manifest, package_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/obsp/mod.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 106 | let file = fs::File::open(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Ok(io::BufReader::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sav/mod.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 28 | buffer: B, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ) -> gfc::KeenSaveGameManager { [INFO] [stdout] 30 | gfc::KeenSaveGameManager::new(gfc::SaveGameManagerParams { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 31 | | game_session: unit4::LocalGameSession::create(buffer), [INFO] [stdout] 32 | | game_name: "Darksiders Warfinitive Edition - All your save game are belong to \ [INFO] [stdout] 33 | | us!", [INFO] [stdout] 34 | | save_game_version: 0x0100_0000, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 13 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let value = De::default() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Arc::try_unwrap(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:19:40 [INFO] [stdout] | [INFO] [stdout] 19 | .map_err(|_| Error::custom(derailed()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:21:40 [INFO] [stdout] | [INFO] [stdout] 21 | .map_err(|_| Error::custom(derailed()))?; [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | fn value(&mut self, repr: repr::Value) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(match repr { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | repr::Value::Int { value } => gfc::Value::Int(value), [INFO] [stdout] 35 | | repr::Value::Float { value } => gfc::Value::Float(value), [INFO] [stdout] 36 | | repr::Value::Bool { value } => gfc::Value::Bool(value), [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:50:44 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|(key, value)| Ok((self.value(key)?, self.value(value)?))) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn object(&mut self, repr: repr::Object) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let properties = match repr.properties { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | repr::ObjectProperties::List(entries) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | repr::ObjectProperties::Map(entries) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let object = Arc::new(gfc::Object { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(gfc::Value::Object(object)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:75:45 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|(name, value)| Ok((name, self.value(value)?))) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/de.rs:81:45 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(name, value)| Ok((name, self.value(value)?))) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `war` (lib) due to 37 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let mut ser = Ser { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | ser.object(self).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:114:36 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|(k, v)| (self.value(k), self.value(v))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:114:51 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|(k, v)| (self.value(k), self.value(v))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:163:29 [INFO] [stdout] | [INFO] [stdout] 140 | let unique_properties = object [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let properties = if any_duplicate_keys { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let list = object [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let map = object [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | repr::Value::Object(repr::Object { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 164 | | id, [INFO] [stdout] 165 | | classname: object.classname.clone(), [INFO] [stdout] 166 | | properties, [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:151:53 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|(name, value)| (name.clone(), self.value(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde/ser.rs:158:53 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|(name, value)| (name.clone(), self.value(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | ser_object(self.0).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:45:36 [INFO] [stdout] | [INFO] [stdout] 45 | .map(|(n, v)| (n.as_str(), ser_value(v))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 54 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | ser_script_class(self.0).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:66:36 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|p| (p.name.as_str(), ser_script_property(p))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:71:36 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|p| (p.name.as_str(), ser_script_static_property(p))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|(n, v)| (n.as_str(), ser_value(v))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/serde_lossy/ser.rs:86:36 [INFO] [stdout] | [INFO] [stdout] 86 | .map(|(n, s)| (n.as_str(), ser_script_state(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worlds/mod.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn read(file: impl Read + Seek) -> Result, Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let mut files = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | let mut world_package = ByteOrdered::new(file, Endianness::Big); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(files [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | .into_iter() [INFO] [stdout] 81 | | // Unwrap the `Rc`s which we used to appease the borrow checker. [INFO] [stdout] 82 | | .map(|(p, o)| (p, Rc::try_unwrap(o).unwrap())) [INFO] [stdout] 83 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worlds/mod.rs:82:27 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(p, o)| (p, Rc::try_unwrap(o).unwrap())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worlds/mod.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 115 | let file = fs::File::open(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(io::BufReader::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 38 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `war` (lib test) due to 39 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8fff3d706474dbbe25f2fd6119c6b86406e4040612e620a3997aa62792fa4d37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fff3d706474dbbe25f2fd6119c6b86406e4040612e620a3997aa62792fa4d37", kill_on_drop: false }` [INFO] [stdout] 8fff3d706474dbbe25f2fd6119c6b86406e4040612e620a3997aa62792fa4d37