[INFO] fetching crate waitcell 0.4.1... [INFO] checking waitcell-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate waitcell 0.4.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate waitcell 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate waitcell 0.4.1 [INFO] finished tweaking crates.io crate waitcell 0.4.1 [INFO] tweaked toml for crates.io crate waitcell 0.4.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2badb0a9a3f78d17c41f9fc16f15263ee4a0bb35c425dec1b7749e007f2ceb71 [INFO] running `Command { std: "docker" "start" "-a" "2badb0a9a3f78d17c41f9fc16f15263ee4a0bb35c425dec1b7749e007f2ceb71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2badb0a9a3f78d17c41f9fc16f15263ee4a0bb35c425dec1b7749e007f2ceb71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2badb0a9a3f78d17c41f9fc16f15263ee4a0bb35c425dec1b7749e007f2ceb71", kill_on_drop: false }` [INFO] [stdout] 2badb0a9a3f78d17c41f9fc16f15263ee4a0bb35c425dec1b7749e007f2ceb71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc1ca023a90f92e0f8efa041040f90d678105a98e5caf6de1cdea002e6886885 [INFO] running `Command { std: "docker" "start" "-a" "cc1ca023a90f92e0f8efa041040f90d678105a98e5caf6de1cdea002e6886885", kill_on_drop: false }` [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking waitcell v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 238 | unsafe fn wake_with T>(&self, func: F) -> &T { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | self.wake({ [INFO] [stdout] | ___________________^ [INFO] [stdout] 240 | | defer_on_unwind! { [INFO] [stdout] 241 | | self.state.fetch_and(!BUSY_BIT, Ordering::Relaxed); [INFO] [stdout] 242 | | } [INFO] [stdout] 243 | | [INFO] [stdout] 244 | | func() [INFO] [stdout] 245 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:390:28 [INFO] [stdout] | [INFO] [stdout] 389 | pub fn into_inner(mut self) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 390 | self.is_set().then(|| unsafe { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 391 | | let result = ptr::read(self.get_ptr()); [INFO] [stdout] 392 | | mem::forget(self); [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 238 | unsafe fn wake_with T>(&self, func: F) -> &T { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | self.wake({ [INFO] [stdout] | ___________________^ [INFO] [stdout] 240 | | defer_on_unwind! { [INFO] [stdout] 241 | | self.state.fetch_and(!BUSY_BIT, Ordering::Relaxed); [INFO] [stdout] 242 | | } [INFO] [stdout] 243 | | [INFO] [stdout] 244 | | func() [INFO] [stdout] 245 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:390:28 [INFO] [stdout] | [INFO] [stdout] 389 | pub fn into_inner(mut self) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 390 | self.is_set().then(|| unsafe { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 391 | | let result = ptr::read(self.get_ptr()); [INFO] [stdout] 392 | | mem::forget(self); [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `waitcell` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `waitcell` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "cc1ca023a90f92e0f8efa041040f90d678105a98e5caf6de1cdea002e6886885", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc1ca023a90f92e0f8efa041040f90d678105a98e5caf6de1cdea002e6886885", kill_on_drop: false }` [INFO] [stdout] cc1ca023a90f92e0f8efa041040f90d678105a98e5caf6de1cdea002e6886885