[INFO] fetching crate wagon-codegen 1.0.0... [INFO] checking wagon-codegen-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wagon-codegen 1.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate wagon-codegen 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wagon-codegen 1.0.0 [INFO] finished tweaking crates.io crate wagon-codegen 1.0.0 [INFO] tweaked toml for crates.io crate wagon-codegen 1.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding logos v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding logos-codegen v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.13.0 (latest: v0.14.1) [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc672d9357784d17b126098839b2f3f40bc6b81760fb056c5d9453d679d686b5 [INFO] running `Command { std: "docker" "start" "-a" "fc672d9357784d17b126098839b2f3f40bc6b81760fb056c5d9453d679d686b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc672d9357784d17b126098839b2f3f40bc6b81760fb056c5d9453d679d686b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc672d9357784d17b126098839b2f3f40bc6b81760fb056c5d9453d679d686b5", kill_on_drop: false }` [INFO] [stdout] fc672d9357784d17b126098839b2f3f40bc6b81760fb056c5d9453d679d686b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5f1e6e7da3d61a97072ac8846f13d6ff3483e40d5217b6a5b8ccbc6b0ec94c1 [INFO] running `Command { std: "docker" "start" "-a" "c5f1e6e7da3d61a97072ac8846f13d6ff3483e40d5217b6a5b8ccbc6b0ec94c1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking wagon-ident v1.0.0 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking wagon-utils v1.0.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling logos-codegen v0.13.0 [INFO] [stderr] Compiling extendable-data-helpers v0.1.5 [INFO] [stderr] Compiling logos-display v0.1.3 [INFO] [stderr] Compiling extendable-data v0.1.5 [INFO] [stderr] Compiling wagon-macros v1.0.0 [INFO] [stderr] Compiling logos-derive v0.13.0 [INFO] [stderr] Checking logos v0.13.0 [INFO] [stderr] Checking wagon-lexer v1.0.0 [INFO] [stderr] Checking wagon-value v1.0.0 [INFO] [stderr] Checking wagon-parser v1.0.0 [INFO] [stderr] Checking wagon-codegen v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/disjunct.rs:12:80 [INFO] [stdout] | [INFO] [stdout] 12 | let stream: Vec = c.iter().map(|x| x.to_tokens(state, label.clone(), attr_fun)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/conjunct.rs:12:80 [INFO] [stdout] | [INFO] [stdout] 12 | let stream: Vec = i.iter().map(|x| x.to_tokens(state, label.clone(), attr_fun)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/sum.rs:12:69 [INFO] [stdout] | [INFO] [stdout] 9 | fn to_tokens_sump(left: &TokenStream, sump: &SumP, state: &mut U, label: Rc, attr_fun: fn(&mut U, Rc, SpannableIdent)) -... [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let op = &sump.op; [INFO] [stdout] 11 | let right = sump.right.to_tokens(state, label.clone(), attr_fun); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | sump.cont.as_ref().map_or_else(|| quote!(#op (#left, #right)?), |cont| { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 13 | | let cont_stream = to_tokens_sump(&right, cont, state, label, attr_fun); [INFO] [stdout] 14 | | quote!(#op (#left, #cont_stream)?) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/term.rs:12:70 [INFO] [stdout] | [INFO] [stdout] 9 | fn to_tokens_termp(left: &TokenStream, termp: &TermP, state: &mut U, label: Rc, attr_fun: fn(&mut U, Rc, SpannableIdent)... [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let op = &termp.op; [INFO] [stdout] 11 | let right = termp.right.to_tokens(state, label.clone(), attr_fun); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | termp.cont.as_ref().map_or_else(|| quote!(#op (#left, #right)?), |cont| { [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 13 | | let cont_stream = to_tokens_termp(&right, cont, state, label, attr_fun); [INFO] [stdout] 14 | | quote!(#op (#left, #cont_stream)?) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filestructure.rs:81:60 [INFO] [stdout] | [INFO] [stdout] 81 | components.pop().map_or_else(|| Self::new(String::new(), FileType::Dir(vec![])), |leaf_path| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filestructure.rs:263:14 [INFO] [stdout] | [INFO] [stdout] 259 | fn insert_data(&mut self, path: &str, data: FileType) -> Option<&mut Self> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | dir.insert(Self::new(filename, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filestructure.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn insert_blob(&mut self, path: &str, blob: Box<[u8]>) -> Option<&mut Self> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | self.insert_data(path, FileType::Blob(blob)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wagon-codegen` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/disjunct.rs:12:80 [INFO] [stdout] | [INFO] [stdout] 12 | let stream: Vec = c.iter().map(|x| x.to_tokens(state, label.clone(), attr_fun)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/conjunct.rs:12:80 [INFO] [stdout] | [INFO] [stdout] 12 | let stream: Vec = i.iter().map(|x| x.to_tokens(state, label.clone(), attr_fun)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/sum.rs:12:69 [INFO] [stdout] | [INFO] [stdout] 9 | fn to_tokens_sump(left: &TokenStream, sump: &SumP, state: &mut U, label: Rc, attr_fun: fn(&mut U, Rc, SpannableIdent)) -... [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let op = &sump.op; [INFO] [stdout] 11 | let right = sump.right.to_tokens(state, label.clone(), attr_fun); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | sump.cont.as_ref().map_or_else(|| quote!(#op (#left, #right)?), |cont| { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 13 | | let cont_stream = to_tokens_sump(&right, cont, state, label, attr_fun); [INFO] [stdout] 14 | | quote!(#op (#left, #cont_stream)?) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/term.rs:12:70 [INFO] [stdout] | [INFO] [stdout] 9 | fn to_tokens_termp(left: &TokenStream, termp: &TermP, state: &mut U, label: Rc, attr_fun: fn(&mut U, Rc, SpannableIdent)... [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let op = &termp.op; [INFO] [stdout] 11 | let right = termp.right.to_tokens(state, label.clone(), attr_fun); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | termp.cont.as_ref().map_or_else(|| quote!(#op (#left, #right)?), |cont| { [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 13 | | let cont_stream = to_tokens_termp(&right, cont, state, label, attr_fun); [INFO] [stdout] 14 | | quote!(#op (#left, #cont_stream)?) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filestructure.rs:81:60 [INFO] [stdout] | [INFO] [stdout] 81 | components.pop().map_or_else(|| Self::new(String::new(), FileType::Dir(vec![])), |leaf_path| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filestructure.rs:263:14 [INFO] [stdout] | [INFO] [stdout] 259 | fn insert_data(&mut self, path: &str, data: FileType) -> Option<&mut Self> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | dir.insert(Self::new(filename, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filestructure.rs:278:26 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn insert_blob(&mut self, path: &str, blob: Box<[u8]>) -> Option<&mut Self> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | self.insert_data(path, FileType::Blob(blob)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wagon-codegen` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "c5f1e6e7da3d61a97072ac8846f13d6ff3483e40d5217b6a5b8ccbc6b0ec94c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5f1e6e7da3d61a97072ac8846f13d6ff3483e40d5217b6a5b8ccbc6b0ec94c1", kill_on_drop: false }` [INFO] [stdout] c5f1e6e7da3d61a97072ac8846f13d6ff3483e40d5217b6a5b8ccbc6b0ec94c1