[INFO] fetching crate vscode-helper 1.0.0... [INFO] checking vscode-helper-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vscode-helper 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate vscode-helper 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vscode-helper 1.0.0 [INFO] finished tweaking crates.io crate vscode-helper 1.0.0 [INFO] tweaked toml for crates.io crate vscode-helper 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate vscode-helper 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08aa9b0996c24f4af5737d3697100d1ff397ec5b89eaf8b54c310c3c3144f993 [INFO] running `Command { std: "docker" "start" "-a" "08aa9b0996c24f4af5737d3697100d1ff397ec5b89eaf8b54c310c3c3144f993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08aa9b0996c24f4af5737d3697100d1ff397ec5b89eaf8b54c310c3c3144f993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08aa9b0996c24f4af5737d3697100d1ff397ec5b89eaf8b54c310c3c3144f993", kill_on_drop: false }` [INFO] [stdout] 08aa9b0996c24f4af5737d3697100d1ff397ec5b89eaf8b54c310c3c3144f993 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9e04014cc90b7af8e3f91667a690a558128a6a64fec65e0101e4ea0b6b5a8cf0 [INFO] running `Command { std: "docker" "start" "-a" "9e04014cc90b7af8e3f91667a690a558128a6a64fec65e0101e4ea0b6b5a8cf0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking tracing-core v0.1.22 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.78 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tracing v0.1.30 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling async-stream-impl v0.3.2 [INFO] [stderr] Compiling clap_derive v3.0.14 [INFO] [stderr] Checking tokio v1.16.1 [INFO] [stderr] Checking async-stream v0.3.2 [INFO] [stderr] Checking clap v3.0.14 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tokio-test v0.4.2 [INFO] [stderr] Checking h2 v0.3.11 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.9 [INFO] [stderr] Checking vscode-helper v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / if opts.save_only { [INFO] [stdout] 79 | | match save_extensions_from_vscode() { [INFO] [stdout] 80 | | Ok(_) => { [INFO] [stdout] 81 | | println!("A list of installed extensions has been saved to ./vscode-extensions.lis") [INFO] [stdout] ... | [INFO] [stdout] 85 | | } else { [INFO] [stdout] | | ____________- [INFO] [stdout] 86 | || let extensions = match &opts.file { [INFO] [stdout] 87 | || Some(file) => read_lines(&file).await.unwrap(), [INFO] [stdout] 88 | || None => get_extensions_from_vscode().unwrap(), [INFO] [stdout] ... || [INFO] [stdout] 98 | || } [INFO] [stdout] 99 | || } [INFO] [stdout] | ||_____^ [INFO] [stdout] | |_____| [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/cli.rs:11:46 [INFO] [stdout] | [INFO] [stdout] 11 | #[clap(short, long, parse(try_from_str = parse_file))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/cli.rs:14:46 [INFO] [stdout] | [INFO] [stdout] 14 | #[clap(short, long, parse(try_from_str = parse_dir))] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/extension.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | let re = Regex::new(r"^([\w-]+)\.([\w-]+)@(\d+\.\d+\.\d+)$").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match re.captures(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vscode-helper` (bin "vscode-helper") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / if opts.save_only { [INFO] [stdout] 79 | | match save_extensions_from_vscode() { [INFO] [stdout] 80 | | Ok(_) => { [INFO] [stdout] 81 | | println!("A list of installed extensions has been saved to ./vscode-extensions.lis") [INFO] [stdout] ... | [INFO] [stdout] 85 | | } else { [INFO] [stdout] | | ____________- [INFO] [stdout] 86 | || let extensions = match &opts.file { [INFO] [stdout] 87 | || Some(file) => read_lines(&file).await.unwrap(), [INFO] [stdout] 88 | || None => get_extensions_from_vscode().unwrap(), [INFO] [stdout] ... || [INFO] [stdout] 98 | || } [INFO] [stdout] 99 | || } [INFO] [stdout] | ||_____^ [INFO] [stdout] | |_____| [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/cli.rs:11:46 [INFO] [stdout] | [INFO] [stdout] 11 | #[clap(short, long, parse(try_from_str = parse_file))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/cli.rs:14:46 [INFO] [stdout] | [INFO] [stdout] 14 | #[clap(short, long, parse(try_from_str = parse_dir))] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/extension.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | let re = Regex::new(r"^([\w-]+)\.([\w-]+)@(\d+\.\d+\.\d+)$").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match re.captures(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:119:26 [INFO] [stdout] | [INFO] [stdout] 119 | for extension in &extensions { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 119 | while let Ok(extension) = &extensions { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 119 | if let Ok(extension) = &extensions { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vscode-helper` (bin "vscode-helper" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9e04014cc90b7af8e3f91667a690a558128a6a64fec65e0101e4ea0b6b5a8cf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e04014cc90b7af8e3f91667a690a558128a6a64fec65e0101e4ea0b6b5a8cf0", kill_on_drop: false }` [INFO] [stdout] 9e04014cc90b7af8e3f91667a690a558128a6a64fec65e0101e4ea0b6b5a8cf0