[INFO] fetching crate vscli 0.3.0... [INFO] checking vscli-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vscli 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate vscli 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate vscli 0.3.0 [INFO] finished tweaking crates.io crate vscli 0.3.0 [INFO] tweaked toml for crates.io crate vscli 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate vscli 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97f5e5c2c1275b8faeb20790ce3e7970e1f05061b8b776a982b7189e01c0d0a2 [INFO] running `Command { std: "docker" "start" "-a" "97f5e5c2c1275b8faeb20790ce3e7970e1f05061b8b776a982b7189e01c0d0a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97f5e5c2c1275b8faeb20790ce3e7970e1f05061b8b776a982b7189e01c0d0a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97f5e5c2c1275b8faeb20790ce3e7970e1f05061b8b776a982b7189e01c0d0a2", kill_on_drop: false }` [INFO] [stdout] 97f5e5c2c1275b8faeb20790ce3e7970e1f05061b8b776a982b7189e01c0d0a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48b34307a55281ca098ec7e033097f4bbfb46573131c3e8406fcb89994ce834b [INFO] running `Command { std: "docker" "start" "-a" "48b34307a55281ca098ec7e033097f4bbfb46573131c3e8406fcb89994ce834b", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking inquire v0.7.4 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking wslpath2 v0.1.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling pest v2.7.9 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap-verbosity-flag v2.2.0 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking ratatui v0.26.2 [INFO] [stderr] Compiling pest_meta v2.7.9 [INFO] [stderr] Compiling pest_generator v2.7.9 [INFO] [stderr] Compiling pest_derive v2.7.9 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking vscli v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 117 | let file = File::open(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | match serde_json::from_reader::<_, History>(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:93:30 [INFO] [stdout] | [INFO] [stdout] 93 | Ok(res?.and_then(|index| tracker.history.iter().nth(index).cloned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 299 | extractor: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | / history [INFO] [stdout] 309 | | .iter() [INFO] [stdout] 310 | | .map(|entry| extractor(entry).len()) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | exec_code(args, insiders, dry_run) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 117 | let file = File::open(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | match serde_json::from_reader::<_, History>(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:93:30 [INFO] [stdout] | [INFO] [stdout] 93 | Ok(res?.and_then(|index| tracker.history.iter().nth(index).cloned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 299 | extractor: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | / history [INFO] [stdout] 309 | | .iter() [INFO] [stdout] 310 | | .map(|entry| extractor(entry).len()) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | exec_code(args, insiders, dry_run) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vscli` (bin "vscli" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vscli` (bin "vscli") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "48b34307a55281ca098ec7e033097f4bbfb46573131c3e8406fcb89994ce834b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48b34307a55281ca098ec7e033097f4bbfb46573131c3e8406fcb89994ce834b", kill_on_drop: false }` [INFO] [stdout] 48b34307a55281ca098ec7e033097f4bbfb46573131c3e8406fcb89994ce834b