[INFO] fetching crate vortex-sampling-compressor 0.7.0... [INFO] checking vortex-sampling-compressor-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vortex-sampling-compressor 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate vortex-sampling-compressor 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vortex-sampling-compressor 0.7.0 [INFO] finished tweaking crates.io crate vortex-sampling-compressor 0.7.0 [INFO] tweaked toml for crates.io crate vortex-sampling-compressor 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 141 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6909d410733cc61a81ade2705e7150c62744c0c12b520675a65fd4e85ee11f90 [INFO] running `Command { std: "docker" "start" "-a" "6909d410733cc61a81ade2705e7150c62744c0c12b520675a65fd4e85ee11f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6909d410733cc61a81ade2705e7150c62744c0c12b520675a65fd4e85ee11f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6909d410733cc61a81ade2705e7150c62744c0c12b520675a65fd4e85ee11f90", kill_on_drop: false }` [INFO] [stdout] 6909d410733cc61a81ade2705e7150c62744c0c12b520675a65fd4e85ee11f90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1169e908fccadae22ae89291ff27c50cad7b4f2098d04950325a142812283140 [INFO] running `Command { std: "docker" "start" "-a" "1169e908fccadae22ae89291ff27c50cad7b4f2098d04950325a142812283140", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling croaring-sys v4.1.1 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking const_for v0.1.4 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking vortex-flatbuffers v0.7.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking zigzag v0.1.0 [INFO] [stderr] Checking fastlanes v0.1.7 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking croaring v2.0.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enum-iterator-derive v1.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking enum-iterator v2.1.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking flexbuffers v2.0.0 [INFO] [stderr] Checking vortex-error v0.7.0 [INFO] [stderr] Checking vortex-buffer v0.7.0 [INFO] [stderr] Checking vortex-dtype v0.7.0 [INFO] [stderr] Checking vortex-scalar v0.7.0 [INFO] [stderr] Checking vortex-expr v0.7.0 [INFO] [stderr] Checking vortex-array v0.7.0 [INFO] [stderr] Checking vortex-fastlanes v0.7.0 [INFO] [stderr] Checking vortex-runend v0.7.0 [INFO] [stderr] Checking vortex-roaring v0.7.0 [INFO] [stderr] Checking vortex-dict v0.7.0 [INFO] [stderr] Checking vortex-alp v0.7.0 [INFO] [stderr] Checking vortex-datetime-parts v0.7.0 [INFO] [stderr] Checking vortex-zigzag v0.7.0 [INFO] [stderr] Checking vortex-sampling-compressor v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:35 [INFO] [stdout] | [INFO] [stdout] 108 | compressors: HashSet>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | disabled_compressors: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:34 [INFO] [stdout] | [INFO] [stdout] 199 | .map(|chunk| self.compress_array(&chunk).map(|a| a.into_array())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | .map(|field| self.compress_array(&field).map(|a| a.into_array())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:76 [INFO] [stdout] | [INFO] [stdout] 230 | Ok(sampled.unwrap_or_else(|| CompressedArray::uncompressed(arr.clone()))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:5 [INFO] [stdout] | [INFO] [stdout] 297 | let sample = ChunkedArray::try_new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | / find_best_compression(candidates, &sample, compressor)? [INFO] [stdout] 312 | | .into_path() [INFO] [stdout] 313 | | .map(|best_compressor| { [INFO] [stdout] 314 | | info!("Compressing array {} with {}", array, best_compressor); [INFO] [stdout] 315 | | best_compressor.compress_unchecked(array, compressor) [INFO] [stdout] 316 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 325 | let mut best = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | Ok(best.unwrap_or_else(|| CompressedArray::uncompressed(sample.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:61 [INFO] [stdout] | [INFO] [stdout] 346 | Ok(best.unwrap_or_else(|| CompressedArray::uncompressed(sample.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/mod.rs:108:60 [INFO] [stdout] | [INFO] [stdout] 108 | .map(|c| c.compress(array, Some(self.clone()), ctx.for_compressor(c))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/alp.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 37 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let parray = array.as_primitive(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | let (exponents, encoded, patches) = match_each_alp_float_ptype!( [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let compressed_encoded = ctx [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let compressed_patches = patches [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | ALPArray::try_new( [INFO] [stdout] 62 | | compressed_encoded.array, [INFO] [stdout] 63 | | exponents, [INFO] [stdout] ... | [INFO] [stdout] 73 | | )), [INFO] [stdout] 74 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/alp.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|p| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / ctx.auxiliary("patches") [INFO] [stdout] 55 | | .excluding(self) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/bitpacked.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 47 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> VortexResult> { [INFO] [stdout] 49 | let parray = array.as_primitive(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let validity = ctx.compress_validity(parray.validity())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let packed = bitpack(&parray, bit_width)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let patches = if num_exceptions > 0 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | BitPackedArray::try_new( [INFO] [stdout] 77 | | packed, [INFO] [stdout] 78 | | validity, [INFO] [stdout] ... | [INFO] [stdout] 87 | | )), [INFO] [stdout] 88 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/constant.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 30 | _ctx: SamplingCompressor<'a>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> VortexResult> { [INFO] [stdout] 32 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | ConstantArray::new(scalar_at(array, 0)?, array.len()).into_array(), [INFO] [stdout] 34 | | Some(CompressionTree::flat(self)), [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/date_time_parts.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 39 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> VortexResult> { [INFO] [stdout] 41 | let (days, seconds, subseconds) = compress_temporal(TemporalArray::try_from(array)?)?; [INFO] [stdout] | ---- ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let days = ctx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let seconds = ctx [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let subsecond = ctx [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | DateTimePartsArray::try_new( [INFO] [stdout] 54 | | array.dtype().clone(), [INFO] [stdout] 55 | | days.array, [INFO] [stdout] ... | [INFO] [stdout] 63 | | )), [INFO] [stdout] 64 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/delta.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> VortexResult> { [INFO] [stdout] 38 | let parray = PrimitiveArray::try_from(array)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let validity = ctx.compress_validity(parray.validity())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let (bases, deltas) = delta_compress(&parray)?; [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let bases = ctx [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let deltas = ctx [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | DeltaArray::try_new(bases.array, deltas.array, validity)?.into_array(), [INFO] [stdout] 54 | | Some(CompressionTree::new(self, vec![bases.path, deltas.path])), [INFO] [stdout] 55 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/dict.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 44 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | ) -> VortexResult> { [INFO] [stdout] 46 | let (codes, values) = match array.encoding().id() { [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Primitive::ID => { [INFO] [stdout] 48 | let p = PrimitiveArray::try_from(array)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (codes, values) = dict_encode_primitive(&p); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let vb = VarBinArray::try_from(array)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let (codes, values) = dict_encode_varbin(&vb); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let (codes, values) = ( [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | DictArray::try_new(codes.array, values.array)?.into_array(), [INFO] [stdout] 72 | | Some(CompressionTree::new(self, vec![codes.path, values.path])), [INFO] [stdout] 73 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/for.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 53 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> VortexResult> { [INFO] [stdout] 55 | let (child, min, shift) = for_compress(&PrimitiveArray::try_from(array)?)?; [INFO] [stdout] | ----- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | let compressed_child = ctx [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | FoRArray::try_new(compressed_child.array, min, shift).map(|a| a.into_array())?, [INFO] [stdout] 63 | | Some(CompressionTree::new(self, vec![compressed_child.path])), [INFO] [stdout] 64 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/roaring_bool.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | _ctx: SamplingCompressor<'a>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | ) -> VortexResult> { [INFO] [stdout] 45 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | roaring_bool_encode(array.clone().into_bool()?)?.into_array(), [INFO] [stdout] 47 | | Some(CompressionTree::flat(self)), [INFO] [stdout] 48 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/roaring_int.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 51 | _ctx: SamplingCompressor<'a>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ) -> VortexResult> { [INFO] [stdout] 53 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | roaring_int_encode(array.clone().into_primitive()?)?.into_array(), [INFO] [stdout] 55 | | Some(CompressionTree::flat(self)), [INFO] [stdout] 56 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/runend.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 51 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ) -> VortexResult> { [INFO] [stdout] 53 | let primitive_array = array.as_primitive(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let (ends, values) = runend_encode(&primitive_array); [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let compressed_ends = ctx [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let compressed_values = ctx [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | RunEndArray::try_new( [INFO] [stdout] 66 | | compressed_ends.array, [INFO] [stdout] 67 | | compressed_values.array, [INFO] [stdout] ... | [INFO] [stdout] 74 | | )), [INFO] [stdout] 75 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/sparse.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 31 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> VortexResult> { [INFO] [stdout] 33 | let sparse_array = SparseArray::try_from(array)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let indices = ctx.auxiliary("indices").compress( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let values = ctx.named("values").compress( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | SparseArray::try_new( [INFO] [stdout] 44 | | indices.array, [INFO] [stdout] 45 | | values.array, [INFO] [stdout] ... | [INFO] [stdout] 50 | | Some(CompressionTree::new(self, vec![indices.path, values.path])), [INFO] [stdout] 51 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/zigzag.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 47 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> VortexResult> { [INFO] [stdout] 49 | let encoded = zigzag_encode(&array.as_primitive())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let compressed = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ctx.compress(&encoded.encoded(), like.as_ref().and_then(|l| l.child(0)))?; [INFO] [stdout] 52 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | ZigZagArray::new(compressed.array).into_array(), [INFO] [stdout] 54 | | Some(CompressionTree::new(self, vec![compressed.path])), [INFO] [stdout] 55 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vortex-sampling-compressor` (lib test) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:35 [INFO] [stdout] | [INFO] [stdout] 108 | compressors: HashSet>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | disabled_compressors: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:34 [INFO] [stdout] | [INFO] [stdout] 199 | .map(|chunk| self.compress_array(&chunk).map(|a| a.into_array())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | .map(|field| self.compress_array(&field).map(|a| a.into_array())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:76 [INFO] [stdout] | [INFO] [stdout] 230 | Ok(sampled.unwrap_or_else(|| CompressedArray::uncompressed(arr.clone()))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:5 [INFO] [stdout] | [INFO] [stdout] 297 | let sample = ChunkedArray::try_new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | / find_best_compression(candidates, &sample, compressor)? [INFO] [stdout] 312 | | .into_path() [INFO] [stdout] 313 | | .map(|best_compressor| { [INFO] [stdout] 314 | | info!("Compressing array {} with {}", array, best_compressor); [INFO] [stdout] 315 | | best_compressor.compress_unchecked(array, compressor) [INFO] [stdout] 316 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 325 | let mut best = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | Ok(best.unwrap_or_else(|| CompressedArray::uncompressed(sample.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:61 [INFO] [stdout] | [INFO] [stdout] 346 | Ok(best.unwrap_or_else(|| CompressedArray::uncompressed(sample.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/mod.rs:108:60 [INFO] [stdout] | [INFO] [stdout] 108 | .map(|c| c.compress(array, Some(self.clone()), ctx.for_compressor(c))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/alp.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 37 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let parray = array.as_primitive(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | let (exponents, encoded, patches) = match_each_alp_float_ptype!( [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let compressed_encoded = ctx [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let compressed_patches = patches [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | ALPArray::try_new( [INFO] [stdout] 62 | | compressed_encoded.array, [INFO] [stdout] 63 | | exponents, [INFO] [stdout] ... | [INFO] [stdout] 73 | | )), [INFO] [stdout] 74 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/alp.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|p| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / ctx.auxiliary("patches") [INFO] [stdout] 55 | | .excluding(self) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/bitpacked.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 47 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> VortexResult> { [INFO] [stdout] 49 | let parray = array.as_primitive(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let validity = ctx.compress_validity(parray.validity())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let packed = bitpack(&parray, bit_width)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let patches = if num_exceptions > 0 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | BitPackedArray::try_new( [INFO] [stdout] 77 | | packed, [INFO] [stdout] 78 | | validity, [INFO] [stdout] ... | [INFO] [stdout] 87 | | )), [INFO] [stdout] 88 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/constant.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 30 | _ctx: SamplingCompressor<'a>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> VortexResult> { [INFO] [stdout] 32 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | ConstantArray::new(scalar_at(array, 0)?, array.len()).into_array(), [INFO] [stdout] 34 | | Some(CompressionTree::flat(self)), [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/date_time_parts.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 39 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> VortexResult> { [INFO] [stdout] 41 | let (days, seconds, subseconds) = compress_temporal(TemporalArray::try_from(array)?)?; [INFO] [stdout] | ---- ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let days = ctx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let seconds = ctx [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let subsecond = ctx [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | DateTimePartsArray::try_new( [INFO] [stdout] 54 | | array.dtype().clone(), [INFO] [stdout] 55 | | days.array, [INFO] [stdout] ... | [INFO] [stdout] 63 | | )), [INFO] [stdout] 64 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/delta.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> VortexResult> { [INFO] [stdout] 38 | let parray = PrimitiveArray::try_from(array)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let validity = ctx.compress_validity(parray.validity())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let (bases, deltas) = delta_compress(&parray)?; [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let bases = ctx [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let deltas = ctx [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | DeltaArray::try_new(bases.array, deltas.array, validity)?.into_array(), [INFO] [stdout] 54 | | Some(CompressionTree::new(self, vec![bases.path, deltas.path])), [INFO] [stdout] 55 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/dict.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 44 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | ) -> VortexResult> { [INFO] [stdout] 46 | let (codes, values) = match array.encoding().id() { [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Primitive::ID => { [INFO] [stdout] 48 | let p = PrimitiveArray::try_from(array)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (codes, values) = dict_encode_primitive(&p); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let vb = VarBinArray::try_from(array)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let (codes, values) = dict_encode_varbin(&vb); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let (codes, values) = ( [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | DictArray::try_new(codes.array, values.array)?.into_array(), [INFO] [stdout] 72 | | Some(CompressionTree::new(self, vec![codes.path, values.path])), [INFO] [stdout] 73 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/for.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 53 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> VortexResult> { [INFO] [stdout] 55 | let (child, min, shift) = for_compress(&PrimitiveArray::try_from(array)?)?; [INFO] [stdout] | ----- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | let compressed_child = ctx [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | FoRArray::try_new(compressed_child.array, min, shift).map(|a| a.into_array())?, [INFO] [stdout] 63 | | Some(CompressionTree::new(self, vec![compressed_child.path])), [INFO] [stdout] 64 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/roaring_bool.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | _ctx: SamplingCompressor<'a>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | ) -> VortexResult> { [INFO] [stdout] 45 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | roaring_bool_encode(array.clone().into_bool()?)?.into_array(), [INFO] [stdout] 47 | | Some(CompressionTree::flat(self)), [INFO] [stdout] 48 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/roaring_int.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 51 | _ctx: SamplingCompressor<'a>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ) -> VortexResult> { [INFO] [stdout] 53 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | roaring_int_encode(array.clone().into_primitive()?)?.into_array(), [INFO] [stdout] 55 | | Some(CompressionTree::flat(self)), [INFO] [stdout] 56 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/runend.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 51 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ) -> VortexResult> { [INFO] [stdout] 53 | let primitive_array = array.as_primitive(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let (ends, values) = runend_encode(&primitive_array); [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let compressed_ends = ctx [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let compressed_values = ctx [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | RunEndArray::try_new( [INFO] [stdout] 66 | | compressed_ends.array, [INFO] [stdout] 67 | | compressed_values.array, [INFO] [stdout] ... | [INFO] [stdout] 74 | | )), [INFO] [stdout] 75 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/sparse.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 31 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> VortexResult> { [INFO] [stdout] 33 | let sparse_array = SparseArray::try_from(array)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let indices = ctx.auxiliary("indices").compress( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let values = ctx.named("values").compress( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | SparseArray::try_new( [INFO] [stdout] 44 | | indices.array, [INFO] [stdout] 45 | | values.array, [INFO] [stdout] ... | [INFO] [stdout] 50 | | Some(CompressionTree::new(self, vec![indices.path, values.path])), [INFO] [stdout] 51 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compressors/zigzag.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 47 | ctx: SamplingCompressor<'a>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> VortexResult> { [INFO] [stdout] 49 | let encoded = zigzag_encode(&array.as_primitive())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let compressed = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ctx.compress(&encoded.encoded(), like.as_ref().and_then(|l| l.child(0)))?; [INFO] [stdout] 52 | Ok(CompressedArray::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | ZigZagArray::new(compressed.array).into_array(), [INFO] [stdout] 54 | | Some(CompressionTree::new(self, vec![compressed.path])), [INFO] [stdout] 55 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vortex-sampling-compressor` (lib) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "1169e908fccadae22ae89291ff27c50cad7b4f2098d04950325a142812283140", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1169e908fccadae22ae89291ff27c50cad7b4f2098d04950325a142812283140", kill_on_drop: false }` [INFO] [stdout] 1169e908fccadae22ae89291ff27c50cad7b4f2098d04950325a142812283140