[INFO] fetching crate vortex-dht 0.1.0... [INFO] checking vortex-dht-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vortex-dht 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate vortex-dht 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vortex-dht 0.1.0 [INFO] finished tweaking crates.io crate vortex-dht 0.1.0 [INFO] tweaked toml for crates.io crate vortex-dht 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-uring v0.5.13 (latest: v0.6.4) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding tokio-uring v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3202565e10bc8355b11486af34bc0f3afc9535a8e2b93905fce46330d8a1e22e [INFO] running `Command { std: "docker" "start" "-a" "3202565e10bc8355b11486af34bc0f3afc9535a8e2b93905fce46330d8a1e22e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3202565e10bc8355b11486af34bc0f3afc9535a8e2b93905fce46330d8a1e22e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3202565e10bc8355b11486af34bc0f3afc9535a8e2b93905fce46330d8a1e22e", kill_on_drop: false }` [INFO] [stdout] 3202565e10bc8355b11486af34bc0f3afc9535a8e2b93905fce46330d8a1e22e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a3c922b309b786d0eab35cb77ac7eaf3324a9c8591d5e2f99ef7d1d6c69fbcf [INFO] running `Command { std: "docker" "start" "-a" "1a3c922b309b786d0eab35cb77ac7eaf3324a9c8591d5e2f99ef7d1d6c69fbcf", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling io-uring v0.5.13 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_bencoded v0.3.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tokio-uring v0.4.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking vortex-dht v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:524:21 [INFO] [stdout] | [INFO] [stdout] 524 | for mut unknown_node in unknown_nodes [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `table_json` [INFO] [stdout] --> src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | let table_json = { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_json` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/lib.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | let file = tokio_uring::fs::File::create(&path).await?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:524:21 [INFO] [stdout] | [INFO] [stdout] 524 | for mut unknown_node in unknown_nodes [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `table_json` [INFO] [stdout] --> src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | let table_json = { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_json` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/lib.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | let file = tokio_uring::fs::File::create(&path).await?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/krpc/protocol.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 141 | pub struct FindNodesResponse { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 142 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `FindNodesResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/krpc/protocol.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct GetPeersResponse { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 233 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetPeersResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/krpc/protocol.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 317 | pub struct AnnounceResponse { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 318 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `AnnounceResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:53 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|node_addr| tokio_uring::spawn(tokio::net::lookup_host(node_addr))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:312:34 [INFO] [stdout] | [INFO] [stdout] 312 | .filter_map(|result| result.map(|inner| inner.ok()).ok().flatten()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vortex-dht` (lib) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/krpc/protocol.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 141 | pub struct FindNodesResponse { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 142 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `FindNodesResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/krpc/protocol.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct GetPeersResponse { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 233 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `GetPeersResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/krpc/protocol.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 317 | pub struct AnnounceResponse { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 318 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `AnnounceResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:53 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|node_addr| tokio_uring::spawn(tokio::net::lookup_host(node_addr))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:312:34 [INFO] [stdout] | [INFO] [stdout] 312 | .filter_map(|result| result.map(|inner| inner.ok()).ok().flatten()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vortex-dht` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1a3c922b309b786d0eab35cb77ac7eaf3324a9c8591d5e2f99ef7d1d6c69fbcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a3c922b309b786d0eab35cb77ac7eaf3324a9c8591d5e2f99ef7d1d6c69fbcf", kill_on_drop: false }` [INFO] [stdout] 1a3c922b309b786d0eab35cb77ac7eaf3324a9c8591d5e2f99ef7d1d6c69fbcf