[INFO] crate vortex-datafusion 0.7.0 is already in cache [INFO] checking vortex-datafusion-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vortex-datafusion 0.7.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate vortex-datafusion 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vortex-datafusion 0.7.0 [INFO] finished tweaking crates.io crate vortex-datafusion 0.7.0 [INFO] tweaked toml for crates.io crate vortex-datafusion 0.7.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate vortex-datafusion 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a037880b07c7580eec612cbef45a1fc96cecf422831d576eebf7b8d00a39d5e [INFO] running `Command { std: "docker" "start" "-a" "7a037880b07c7580eec612cbef45a1fc96cecf422831d576eebf7b8d00a39d5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a037880b07c7580eec612cbef45a1fc96cecf422831d576eebf7b8d00a39d5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a037880b07c7580eec612cbef45a1fc96cecf422831d576eebf7b8d00a39d5e", kill_on_drop: false }` [INFO] [stdout] 7a037880b07c7580eec612cbef45a1fc96cecf422831d576eebf7b8d00a39d5e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f16df060f98c371f16612c3f19da942bb5ce35c25a70624ac744cfa649218b50 [INFO] running `Command { std: "docker" "start" "-a" "f16df060f98c371f16612c3f19da942bb5ce35c25a70624ac744cfa649218b50", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Compiling indexmap v2.3.0 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking vortex-flatbuffers v0.7.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking sqlparser v0.47.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Compiling enum-iterator-derive v1.4.0 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking enum-iterator v2.1.0 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking datafusion-common-runtime v40.0.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking flexbuffers v2.0.0 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking vortex-buffer v0.7.0 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking parquet v52.2.0 [INFO] [stderr] Checking datafusion-common v40.0.0 [INFO] [stderr] Checking datafusion-expr v40.0.0 [INFO] [stderr] Checking vortex-error v0.7.0 [INFO] [stderr] Checking vortex-dtype v0.7.0 [INFO] [stderr] Checking vortex-scalar v0.7.0 [INFO] [stderr] Checking vortex-expr v0.7.0 [INFO] [stderr] Checking vortex-array v0.7.0 [INFO] [stderr] Checking datafusion-execution v40.0.0 [INFO] [stderr] Checking datafusion-physical-expr-common v40.0.0 [INFO] [stderr] Checking datafusion-sql v40.0.0 [INFO] [stderr] Checking datafusion-functions v40.0.0 [INFO] [stderr] Checking datafusion-physical-expr v40.0.0 [INFO] [stderr] Checking datafusion-functions-aggregate v40.0.0 [INFO] [stderr] Checking vortex-serde v0.7.0 [INFO] [stderr] Checking datafusion-physical-plan v40.0.0 [INFO] [stderr] Checking datafusion-optimizer v40.0.0 [INFO] [stderr] Checking datafusion-functions-array v40.0.0 [INFO] [stderr] Checking datafusion v40.0.0 [INFO] [stderr] Checking vortex-datafusion v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | || dt == DataType::Boolean [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | || dt == DataType::Binary [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | || dt == DataType::Utf8 [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | || dt == DataType::Binary [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | || dt == DataType::BinaryView [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | || dt == DataType::Utf8View [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 98 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | array: Array, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let vortex_table = VortexMemTable::new(array, options); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | self.register_table(name.as_ref(), Arc::new(vortex_table)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 114 | array: Array, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let vortex_table = VortexMemTable::new(array, options); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | self.read_table(Arc::new(vortex_table)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:21 [INFO] [stdout] | [INFO] [stdout] 237 | let chunk = this [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let struct_array = chunk [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let projected_struct = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | Poll::Ready(Some(Ok(projected_struct.into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:300:12 [INFO] [stdout] | [INFO] [stdout] 297 | _context: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | Ok(Box::pin(VortexRecordBatchStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 301 | | schema_ref: self.schema().clone(), [INFO] [stdout] 302 | | idx: 0, [INFO] [stdout] 303 | | num_chunks: self.array.nchunks(), [INFO] [stdout] 304 | | chunks: self.array.clone(), [INFO] [stdout] 305 | | projection: self.scan_projection.clone(), [INFO] [stdout] 306 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 192 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | chunked_array: ChunkedArray, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let row_selector_op = Arc::new(RowSelectorExec::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Arc::new(TakeRowsExec::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 206 | | schema.clone(), [INFO] [stdout] 207 | | &output_projection, [INFO] [stdout] 208 | | row_selector_op.clone(), [INFO] [stdout] 209 | | &chunked_array, [INFO] [stdout] 210 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/config.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(schema: SchemaRef, data_files: Vec, ctx: Arc) -> Self { [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | schema: Some(schema), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/execution.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 27 | file_scan_config: FileScanConfig, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | metrics: ExecutionPlanMetricsSet, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | projection: Option<&Vec>, [INFO] [stdout] 30 | predicate: Option>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ctx: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> DFResult { [INFO] [stdout] 33 | let projected_schema = project_schema(&file_scan_config.file_schema, projection)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let plan_properties = PlanProperties::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | file_scan_config, [INFO] [stdout] 42 | | metrics, [INFO] [stdout] 43 | | predicate, [INFO] [stdout] 44 | | plan_properties, [INFO] [stdout] 45 | | ctx, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/execution.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) fn into_arc(self) -> Arc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Arc::new(self) as _ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/execution.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 89 | context: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> DFResult { [INFO] [stdout] 91 | let object_store = context [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let opener = VortexFileOpener { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let stream = FileStream::new(&self.file_scan_config, partition, opener, &self.metrics)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | [INFO] [stdout] 103 | Ok(Box::pin(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/opener.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 24 | fn open(&self, file_meta: FileMeta) -> DFResult { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let read_at = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut builder = VortexLayoutReaderBuilder::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(async move { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | let reader = builder.build().await?; [INFO] [stdout] 47 | | let stream = reader.map_ok(RecordBatch::from).map_err(|e| e.into()); [INFO] [stdout] 48 | | Ok(Box::pin(stream) as _) [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | .boxed()) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/opener.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 28 | let mut builder = VortexLayoutReaderBuilder::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let reader = builder.build().await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let stream = reader.map_ok(RecordBatch::from).map_err(|e| e.into()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Box::pin(stream) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/provider.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn try_new(object_store_url: ObjectStoreUrl, config: VortexTableOptions) -> DFResult { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | schema_ref: config.schema.clone().unwrap(), [INFO] [stdout] 30 | | object_store_url, [INFO] [stdout] 31 | | config, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatype.rs:120:46 [INFO] [stdout] | [INFO] [stdout] 120 | tz.map(|s| Arc::from(s.into_boxed_str())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn make_conjunction(exprs: impl AsRef<[Expr]>) -> DFResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(exprs [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | .as_ref() [INFO] [stdout] 17 | | .iter() [INFO] [stdout] 18 | | .fold(lit(true), |conj, elem| and(conj, elem.clone()))) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:18:49 [INFO] [stdout] | [INFO] [stdout] 18 | .fold(lit(true), |conj, elem| and(conj, elem.clone()))) [INFO] [stdout] | ---- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn simplify_expr(expr: &Expr, schema: SchemaRef) -> DFResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let schema = schema.to_dfschema_ref()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let props = ExecutionProps::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let context = SimplifyContext::new(&props).with_schema(schema); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let simplifier = ExprSimplifier::new(context); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | simplifier.simplify(expr.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 61 | let cached_plan_props = PlanProperties::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | filter_exprs: filter_exprs.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 61 | let cached_plan_props = PlanProperties::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | chunked_array: chunked_array.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 122 | _context: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let filter_schema = Arc::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let conjunction_expr = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(Box::pin(RowIndicesStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 141 | | chunked_array: self.chunked_array.clone(), [INFO] [stdout] 142 | | chunk_idx: 0, [INFO] [stdout] 143 | | filter_projection: self.filter_projection.clone(), [INFO] [stdout] 144 | | conjunction_expr, [INFO] [stdout] 145 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 167 | let next_chunk = this [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let vortex_struct = next_chunk [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let array = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | ExpressionEvaluator::eval(vortex_struct.into_array(), &this.conjunction_expr).unwrap(); [INFO] [stdout] 185 | let selection = array.into_canonical().unwrap().into_arrow(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let indices = Arc::new(UInt64Array::from_iter_values(selection_indices)) as ArrayRef; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let indices_batch = RecordBatch::try_new(ROW_SELECTOR_SCHEMA_REF.clone(), vec![indices])?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | [INFO] [stdout] 197 | Poll::Ready(Some(Ok(indices_batch))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:242:28 [INFO] [stdout] | [INFO] [stdout] 226 | schema_ref: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | projection: &[usize], [INFO] [stdout] 228 | row_indices: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let output_schema = Arc::new(schema_ref.project(projection).unwrap()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let plan_properties = PlanProperties::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | output_schema: output_schema.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 226 | schema_ref: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | projection: &[usize], [INFO] [stdout] 228 | row_indices: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let output_schema = Arc::new(schema_ref.project(projection).unwrap()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let plan_properties = PlanProperties::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | table: table.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:295:12 [INFO] [stdout] | [INFO] [stdout] 290 | context: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let row_indices_stream = self.input.execute(partition, context)?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | [INFO] [stdout] 295 | Ok(Box::pin(TakeRowsStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 296 | | row_indices_stream, [INFO] [stdout] 297 | | chunk_idx: 0, [INFO] [stdout] 298 | | output_projection: self.projection.clone(), [INFO] [stdout] 299 | | output_schema: self.output_schema.clone(), [INFO] [stdout] 300 | | vortex_array: self.table.clone(), [INFO] [stdout] 301 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:385:21 [INFO] [stdout] | [INFO] [stdout] 335 | let record_batch = match ready!(this.row_indices_stream.poll_next(cx)) { [INFO] [stdout] | ------------ --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | Some(result) => result?, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | let row_indices = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | let chunk = this [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | let projected_for_output = chunk.project(this.output_projection).unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | let decoded = take(&projected_for_output.into_array(), &row_indices) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | let output_batch = RecordBatch::from(decoded.as_struct()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | [INFO] [stdout] 385 | Poll::Ready(Some(Ok(output_batch))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | || dt == DataType::Boolean [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | || dt == DataType::Binary [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vortex-datafusion` (lib) due to 31 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | || dt == DataType::Utf8 [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | || dt == DataType::Binary [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | || dt == DataType::BinaryView [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn supported_data_types(dt: DataType) -> bool { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | || dt == DataType::Utf8View [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 98 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | array: Array, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let vortex_table = VortexMemTable::new(array, options); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | self.register_table(name.as_ref(), Arc::new(vortex_table)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 114 | array: Array, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let vortex_table = VortexMemTable::new(array, options); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | self.read_table(Arc::new(vortex_table)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:21 [INFO] [stdout] | [INFO] [stdout] 237 | let chunk = this [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let struct_array = chunk [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let projected_struct = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | Poll::Ready(Some(Ok(projected_struct.into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:300:12 [INFO] [stdout] | [INFO] [stdout] 297 | _context: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | Ok(Box::pin(VortexRecordBatchStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 301 | | schema_ref: self.schema().clone(), [INFO] [stdout] 302 | | idx: 0, [INFO] [stdout] 303 | | num_chunks: self.array.nchunks(), [INFO] [stdout] 304 | | chunks: self.array.clone(), [INFO] [stdout] 305 | | projection: self.scan_projection.clone(), [INFO] [stdout] 306 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 192 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | chunked_array: ChunkedArray, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let row_selector_op = Arc::new(RowSelectorExec::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Arc::new(TakeRowsExec::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 206 | | schema.clone(), [INFO] [stdout] 207 | | &output_projection, [INFO] [stdout] 208 | | row_selector_op.clone(), [INFO] [stdout] 209 | | &chunked_array, [INFO] [stdout] 210 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 230 | let names = VarBinArray::from_vec( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let term_start = PrimitiveArray::from_vec( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | / StructArray::from_fields(&[ [INFO] [stdout] 247 | | ("president", names.into_array()), [INFO] [stdout] 248 | | ("term_start", term_start.into_array()), [INFO] [stdout] 249 | | ]) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/config.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(schema: SchemaRef, data_files: Vec, ctx: Arc) -> Self { [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | schema: Some(schema), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/execution.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 27 | file_scan_config: FileScanConfig, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | metrics: ExecutionPlanMetricsSet, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | projection: Option<&Vec>, [INFO] [stdout] 30 | predicate: Option>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ctx: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> DFResult { [INFO] [stdout] 33 | let projected_schema = project_schema(&file_scan_config.file_schema, projection)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let plan_properties = PlanProperties::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | file_scan_config, [INFO] [stdout] 42 | | metrics, [INFO] [stdout] 43 | | predicate, [INFO] [stdout] 44 | | plan_properties, [INFO] [stdout] 45 | | ctx, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/execution.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) fn into_arc(self) -> Arc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Arc::new(self) as _ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/execution.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 89 | context: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> DFResult { [INFO] [stdout] 91 | let object_store = context [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let opener = VortexFileOpener { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let stream = FileStream::new(&self.file_scan_config, partition, opener, &self.metrics)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | [INFO] [stdout] 103 | Ok(Box::pin(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/opener.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 24 | fn open(&self, file_meta: FileMeta) -> DFResult { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let read_at = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut builder = VortexLayoutReaderBuilder::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(async move { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | let reader = builder.build().await?; [INFO] [stdout] 47 | | let stream = reader.map_ok(RecordBatch::from).map_err(|e| e.into()); [INFO] [stdout] 48 | | Ok(Box::pin(stream) as _) [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | .boxed()) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/opener.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 28 | let mut builder = VortexLayoutReaderBuilder::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let reader = builder.build().await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let stream = reader.map_ok(RecordBatch::from).map_err(|e| e.into()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Box::pin(stream) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistent/provider.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn try_new(object_store_url: ObjectStoreUrl, config: VortexTableOptions) -> DFResult { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | schema_ref: config.schema.clone().unwrap(), [INFO] [stdout] 30 | | object_store_url, [INFO] [stdout] 31 | | config, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatype.rs:120:46 [INFO] [stdout] | [INFO] [stdout] 120 | tz.map(|s| Arc::from(s.into_boxed_str())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn make_conjunction(exprs: impl AsRef<[Expr]>) -> DFResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(exprs [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | .as_ref() [INFO] [stdout] 17 | | .iter() [INFO] [stdout] 18 | | .fold(lit(true), |conj, elem| and(conj, elem.clone()))) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:18:49 [INFO] [stdout] | [INFO] [stdout] 18 | .fold(lit(true), |conj, elem| and(conj, elem.clone()))) [INFO] [stdout] | ---- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn simplify_expr(expr: &Expr, schema: SchemaRef) -> DFResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let schema = schema.to_dfschema_ref()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let props = ExecutionProps::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let context = SimplifyContext::new(&props).with_schema(schema); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let simplifier = ExprSimplifier::new(context); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | simplifier.simplify(expr.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 61 | let cached_plan_props = PlanProperties::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | filter_exprs: filter_exprs.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 61 | let cached_plan_props = PlanProperties::new( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | chunked_array: chunked_array.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 122 | _context: Arc, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let filter_schema = Arc::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let conjunction_expr = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(Box::pin(RowIndicesStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 141 | | chunked_array: self.chunked_array.clone(), [INFO] [stdout] 142 | | chunk_idx: 0, [INFO] [stdout] 143 | | filter_projection: self.filter_projection.clone(), [INFO] [stdout] 144 | | conjunction_expr, [INFO] [stdout] 145 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 167 | let next_chunk = this [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let vortex_struct = next_chunk [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let array = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | ExpressionEvaluator::eval(vortex_struct.into_array(), &this.conjunction_expr).unwrap(); [INFO] [stdout] 185 | let selection = array.into_canonical().unwrap().into_arrow(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let indices = Arc::new(UInt64Array::from_iter_values(selection_indices)) as ArrayRef; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let indices_batch = RecordBatch::try_new(ROW_SELECTOR_SCHEMA_REF.clone(), vec![indices])?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | [INFO] [stdout] 197 | Poll::Ready(Some(Ok(indices_batch))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:242:28 [INFO] [stdout] | [INFO] [stdout] 226 | schema_ref: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | projection: &[usize], [INFO] [stdout] 228 | row_indices: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let output_schema = Arc::new(schema_ref.project(projection).unwrap()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let plan_properties = PlanProperties::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | output_schema: output_schema.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 226 | schema_ref: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | projection: &[usize], [INFO] [stdout] 228 | row_indices: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let output_schema = Arc::new(schema_ref.project(projection).unwrap()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let plan_properties = PlanProperties::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | table: table.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:295:12 [INFO] [stdout] | [INFO] [stdout] 290 | context: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let row_indices_stream = self.input.execute(partition, context)?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | [INFO] [stdout] 295 | Ok(Box::pin(TakeRowsStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 296 | | row_indices_stream, [INFO] [stdout] 297 | | chunk_idx: 0, [INFO] [stdout] 298 | | output_projection: self.projection.clone(), [INFO] [stdout] 299 | | output_schema: self.output_schema.clone(), [INFO] [stdout] 300 | | vortex_array: self.table.clone(), [INFO] [stdout] 301 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plans.rs:385:21 [INFO] [stdout] | [INFO] [stdout] 335 | let record_batch = match ready!(this.row_indices_stream.poll_next(cx)) { [INFO] [stdout] | ------------ --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | Some(result) => result?, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | let row_indices = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | let chunk = this [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | let projected_for_output = chunk.project(this.output_projection).unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | let decoded = take(&projected_for_output.into_array(), &row_indices) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | let output_batch = RecordBatch::from(decoded.as_struct()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | [INFO] [stdout] 385 | Poll::Ready(Some(Ok(output_batch))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vortex-datafusion` (lib test) due to 32 previous errors [INFO] running `Command { std: "docker" "inspect" "f16df060f98c371f16612c3f19da942bb5ce35c25a70624ac744cfa649218b50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f16df060f98c371f16612c3f19da942bb5ce35c25a70624ac744cfa649218b50", kill_on_drop: false }` [INFO] [stdout] f16df060f98c371f16612c3f19da942bb5ce35c25a70624ac744cfa649218b50