[INFO] fetching crate vorbis_rs 0.5.4... [INFO] checking vorbis_rs-0.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vorbis_rs 0.5.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate vorbis_rs 0.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vorbis_rs 0.5.4 [INFO] finished tweaking crates.io crate vorbis_rs 0.5.4 [INFO] tweaked toml for crates.io crate vorbis_rs 0.5.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09cd7b727c28da19621e2e3db72340aa8c86e52644b59f6135251138996c6ecb [INFO] running `Command { std: "docker" "start" "-a" "09cd7b727c28da19621e2e3db72340aa8c86e52644b59f6135251138996c6ecb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09cd7b727c28da19621e2e3db72340aa8c86e52644b59f6135251138996c6ecb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09cd7b727c28da19621e2e3db72340aa8c86e52644b59f6135251138996c6ecb", kill_on_drop: false }` [INFO] [stdout] 09cd7b727c28da19621e2e3db72340aa8c86e52644b59f6135251138996c6ecb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0aedb042bc75a7888a98512839894e11fa9657cb565b564dfe41697dfde471fe [INFO] running `Command { std: "docker" "start" "-a" "0aedb042bc75a7888a98512839894e11fa9657cb565b564dfe41697dfde471fe", kill_on_drop: false }` [INFO] [stderr] Compiling ogg_next_sys v0.1.3 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling aotuv_lancer_vorbis_sys v0.1.4 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking errno v0.3.9 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking vorbis_rs v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:47:6 [INFO] [stdout] | [INFO] [stdout] 45 | sink: W [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ) -> Result { [INFO] [stdout] 47 | Ok(Self::__new( [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | sampling_frequency, [INFO] [stdout] 49 | | channels, [INFO] [stdout] 50 | | sink, [INFO] [stdout] 51 | | Self::generate_random_stream_serial()?, [INFO] [stdout] 52 | | true [INFO] [stdout] 53 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:87:10 [INFO] [stdout] | [INFO] [stdout] 80 | sink: W, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | sink: Some(sink), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 80 | sink: W, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | comments: VorbisComments::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:169:21 [INFO] [stdout] | [INFO] [stdout] 166 | tag: impl Into>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | value: impl Into> [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | ) -> Result<&mut Self, VorbisError> { [INFO] [stdout] 169 | self.comment_tags([(tag, value)]) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:256:6 [INFO] [stdout] | [INFO] [stdout] 212 | let mut sink = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let mut ogg_stream = OggStream::new(self.stream_serial)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut vorbis_info = VorbisInfo::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let mut vorbis_encoding_state = VorbisEncodingState::new(vorbis_info)?; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(VorbisEncoder { [INFO] [stdout] | ____________^ [INFO] [stdout] 257 | | ogg_stream, [INFO] [stdout] 258 | | vorbis_encoding_state, [INFO] [stdout] 259 | | sink: Some(sink), [INFO] [stdout] 260 | | minimum_page_data_size: self.minimum_page_data_size [INFO] [stdout] 261 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:459:3 [INFO] [stdout] | [INFO] [stdout] 450 | pub fn finish(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 459 | self.write_pending_blocks() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:460:14 [INFO] [stdout] | [INFO] [stdout] 460 | .map(|()| self.sink.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:47:6 [INFO] [stdout] | [INFO] [stdout] 45 | sink: W [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ) -> Result { [INFO] [stdout] 47 | Ok(Self::__new( [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | sampling_frequency, [INFO] [stdout] 49 | | channels, [INFO] [stdout] 50 | | sink, [INFO] [stdout] 51 | | Self::generate_random_stream_serial()?, [INFO] [stdout] 52 | | true [INFO] [stdout] 53 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:87:10 [INFO] [stdout] | [INFO] [stdout] 80 | sink: W, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | sink: Some(sink), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 80 | sink: W, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | comments: VorbisComments::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:169:21 [INFO] [stdout] | [INFO] [stdout] 166 | tag: impl Into>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | value: impl Into> [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | ) -> Result<&mut Self, VorbisError> { [INFO] [stdout] 169 | self.comment_tags([(tag, value)]) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:256:6 [INFO] [stdout] | [INFO] [stdout] 212 | let mut sink = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let mut ogg_stream = OggStream::new(self.stream_serial)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut vorbis_info = VorbisInfo::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let mut vorbis_encoding_state = VorbisEncodingState::new(vorbis_info)?; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(VorbisEncoder { [INFO] [stdout] | ____________^ [INFO] [stdout] 257 | | ogg_stream, [INFO] [stdout] 258 | | vorbis_encoding_state, [INFO] [stdout] 259 | | sink: Some(sink), [INFO] [stdout] 260 | | minimum_page_data_size: self.minimum_page_data_size [INFO] [stdout] 261 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:459:3 [INFO] [stdout] | [INFO] [stdout] 450 | pub fn finish(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 459 | self.write_pending_blocks() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder/encoder_impl.rs:460:14 [INFO] [stdout] | [INFO] [stdout] 460 | .map(|()| self.sink.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vorbis_rs` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vorbis_rs` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "0aedb042bc75a7888a98512839894e11fa9657cb565b564dfe41697dfde471fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0aedb042bc75a7888a98512839894e11fa9657cb565b564dfe41697dfde471fe", kill_on_drop: false }` [INFO] [stdout] 0aedb042bc75a7888a98512839894e11fa9657cb565b564dfe41697dfde471fe