[INFO] fetching crate volaris-tools 0.0.3... [INFO] checking volaris-tools-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate volaris-tools 0.0.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate volaris-tools 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate volaris-tools 0.0.3 [INFO] finished tweaking crates.io crate volaris-tools 0.0.3 [INFO] tweaked toml for crates.io crate volaris-tools 0.0.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding argon2 v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding balloon-hash v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding crypto-bigint v0.4.9 (latest: v0.5.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding password-hash v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] [stderr] Adding zstd v0.11.2+zstd.1.5.2 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v5.0.2+zstd.1.5.2 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66bafc76c45e06469f12eb9f085dec2ad726cc4a28f538dd956003fe92a5933e [INFO] running `Command { std: "docker" "start" "-a" "66bafc76c45e06469f12eb9f085dec2ad726cc4a28f538dd956003fe92a5933e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66bafc76c45e06469f12eb9f085dec2ad726cc4a28f538dd956003fe92a5933e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66bafc76c45e06469f12eb9f085dec2ad726cc4a28f538dd956003fe92a5933e", kill_on_drop: false }` [INFO] [stdout] 66bafc76c45e06469f12eb9f085dec2ad726cc4a28f538dd956003fe92a5933e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d5684eb1ef3710837dad16e346c410e6608031e1863d91e80fb2b4ff2fe2975e [INFO] running `Command { std: "docker" "start" "-a" "d5684eb1ef3710837dad16e346c410e6608031e1863d91e80fb2b4ff2fe2975e", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking argon2 v0.4.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking balloon-hash v0.3.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking deoxys v0.1.0 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking volaris-crypto v0.0.3 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking volaris-tools v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/key/add.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 30 - let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] 30 + let (header, _) = Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/key/change.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 30 - let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] 30 + let (header, _) = Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/key/delete.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 22 - let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] 22 + let (header, _) = Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/key/add.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 30 - let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] 30 + let (header, _) = Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/key/change.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 30 - let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] 30 + let (header, _) = Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/key/delete.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 22 - let (header, _) = corecrypto::header::Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] 22 + let (header, _) = Header::deserialize(&mut *req.handle.borrow_mut()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/erase_dir.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|f| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let file_path = f.path().to_path_buf(); [INFO] [stdout] 57 | let stor = stor.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | std::thread::spawn(move || -> Result<(), Error> { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 59 | | crate::erase::execute( [INFO] [stdout] 60 | | stor, [INFO] [stdout] 61 | | crate::erase::Request { [INFO] [stdout] ... | [INFO] [stdout] 67 | | Ok(()) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/erase_dir.rs:72:43 [INFO] [stdout] | [INFO] [stdout] 72 | handlers.into_iter().try_for_each(|h| h.join().unwrap())?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 51 | raw_key_old: Protected>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok((Protected::new(master_key), index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overwrite.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 40 | let mut writer = req.writer.borrow_mut(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | writer.flush().map_err(|_| Error::FlushFile) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 81 | fn create_dir_all>(&self, path: P) -> Result<(), Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | fs::create_dir_all(&path).map_err(|_| Error::CreateDir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 85 | fn create_file>(&self, path: P) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 87 | let file = fs::File::options() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Entry::File(FileData { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | path, [INFO] [stdout] 95 | | stream: RefCell::new(file), [INFO] [stdout] 96 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn write_file>(&self, path: P) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 114 | let file = fs::File::options() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Entry::File(FileData { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | path, [INFO] [stdout] 123 | | stream: RefCell::new(file), [INFO] [stdout] 124 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn remove_file(&self, file: Entry) -> Result<(), Error> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | fs::remove_file(file.path()).map_err(|_| Error::RemoveFile) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 153 | fn remove_dir_all(&self, file: Entry) -> Result<(), Error> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | fs::remove_dir_all(file.path()).map_err(|_| Error::RemoveDir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|res| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | res.map(|e| e.path().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unpack.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 126 | let stor = stor.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let full_path = full_path.clone(); [INFO] [stdout] 128 | std::thread::spawn(move || stor.create_dir_all(full_path).map_err(Error::Storage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unpack.rs:134:32 [INFO] [stdout] | [INFO] [stdout] 134 | .try_for_each(|th| th.join().unwrap())?; [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `volaris-tools` (lib) due to 13 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/erase.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 67 | let stor = Arc::new(InMemoryStorage::default()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | match execute(stor.clone(), req) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/erase_dir.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|f| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let file_path = f.path().to_path_buf(); [INFO] [stdout] 57 | let stor = stor.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | std::thread::spawn(move || -> Result<(), Error> { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 59 | | crate::erase::execute( [INFO] [stdout] 60 | | stor, [INFO] [stdout] 61 | | crate::erase::Request { [INFO] [stdout] ... | [INFO] [stdout] 67 | | Ok(()) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/erase_dir.rs:72:43 [INFO] [stdout] | [INFO] [stdout] 72 | handlers.into_iter().try_for_each(|h| h.join().unwrap())?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/erase_dir.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 86 | let stor = Arc::new(InMemoryStorage::default()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | match execute(stor.clone(), req) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 51 | raw_key_old: Protected>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok((Protected::new(master_key), index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overwrite.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 40 | let mut writer = req.writer.borrow_mut(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | writer.flush().map_err(|_| Error::FlushFile) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 81 | fn create_dir_all>(&self, path: P) -> Result<(), Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | fs::create_dir_all(&path).map_err(|_| Error::CreateDir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 85 | fn create_file>(&self, path: P) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 87 | let file = fs::File::options() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Entry::File(FileData { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | path, [INFO] [stdout] 95 | | stream: RefCell::new(file), [INFO] [stdout] 96 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn write_file>(&self, path: P) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 114 | let file = fs::File::options() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Entry::File(FileData { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | path, [INFO] [stdout] 123 | | stream: RefCell::new(file), [INFO] [stdout] 124 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn remove_file(&self, file: Entry) -> Result<(), Error> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | fs::remove_file(file.path()).map_err(|_| Error::RemoveFile) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 153 | fn remove_dir_all(&self, file: Entry) -> Result<(), Error> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | fs::remove_dir_all(file.path()).map_err(|_| Error::RemoveDir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|res| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | res.map(|e| e.path().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unpack.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 126 | let stor = stor.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let full_path = full_path.clone(); [INFO] [stdout] 128 | std::thread::spawn(move || stor.create_dir_all(full_path).map_err(Error::Storage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unpack.rs:134:32 [INFO] [stdout] | [INFO] [stdout] 134 | .try_for_each(|th| th.join().unwrap())?; [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `volaris-tools` (lib test) due to 15 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d5684eb1ef3710837dad16e346c410e6608031e1863d91e80fb2b4ff2fe2975e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5684eb1ef3710837dad16e346c410e6608031e1863d91e80fb2b4ff2fe2975e", kill_on_drop: false }` [INFO] [stdout] d5684eb1ef3710837dad16e346c410e6608031e1863d91e80fb2b4ff2fe2975e