[INFO] fetching crate volaris-crypto 0.0.3... [INFO] checking volaris-crypto-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate volaris-crypto 0.0.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate volaris-crypto 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate volaris-crypto 0.0.3 [INFO] finished tweaking crates.io crate volaris-crypto 0.0.3 [INFO] tweaked toml for crates.io crate volaris-crypto 0.0.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding argon2 v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding balloon-hash v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding crypto-bigint v0.4.9 (latest: v0.5.5) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding indicatif v0.16.2 (latest: v0.17.8) [INFO] [stderr] Adding password-hash v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] becbf5d56c9926c12594edbf07492586f1a0decb8993a6418242d5ceff497694 [INFO] running `Command { std: "docker" "start" "-a" "becbf5d56c9926c12594edbf07492586f1a0decb8993a6418242d5ceff497694", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "becbf5d56c9926c12594edbf07492586f1a0decb8993a6418242d5ceff497694", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "becbf5d56c9926c12594edbf07492586f1a0decb8993a6418242d5ceff497694", kill_on_drop: false }` [INFO] [stdout] becbf5d56c9926c12594edbf07492586f1a0decb8993a6418242d5ceff497694 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0a942c84f8bd4c5aabbd99ccee829fbf84f42a3adaa6720be2def7253a4d5fa [INFO] running `Command { std: "docker" "start" "-a" "d0a942c84f8bd4c5aabbd99ccee829fbf84f42a3adaa6720be2def7253a4d5fa", kill_on_drop: false }` [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking balloon-hash v0.3.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking argon2 v0.4.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking deoxys v0.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking volaris-crypto v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/lib.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:190:15 [INFO] [stdout] | [INFO] [stdout] 190 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:234:15 [INFO] [stdout] | [INFO] [stdout] 234 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:358:15 [INFO] [stdout] | [INFO] [stdout] 358 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:401:15 [INFO] [stdout] | [INFO] [stdout] 401 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/lib.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:190:15 [INFO] [stdout] | [INFO] [stdout] 190 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:234:15 [INFO] [stdout] | [INFO] [stdout] 234 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:358:15 [INFO] [stdout] | [INFO] [stdout] 358 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `visual` [INFO] [stdout] --> src/stream.rs:401:15 [INFO] [stdout] | [INFO] [stdout] 401 | #[cfg(feature = "visual")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `indicatif` [INFO] [stdout] = help: consider adding `visual` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 42 | raw_key: Protected>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | return Err(anyhow::anyhow!( [INFO] [stdout] | ________________________- [INFO] [stdout] 67 | | "argon2id is not supported on header versions above V3." [INFO] [stdout] 68 | | )) [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Protected::new(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 106 | raw_key: Protected>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | return Err(anyhow::anyhow!( [INFO] [stdout] | ________________________- [INFO] [stdout] 115 | | "Balloon hashing is not supported in header versions below V4." [INFO] [stdout] 116 | | )); [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Protected::new(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 172 | let key = keyslot.hash_algorithm.hash(raw_key.clone(), &keyslot.salt).ok()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | [INFO] [stdout] 174 | let cipher = Ciphers::initialize(key, &header.header_type.algorithm).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | / cipher [INFO] [stdout] 176 | | .decrypt(&keyslot.nonce, keyslot.encrypted_key.as_slice()) [INFO] [stdout] 177 | | .map(vec_to_arr) [INFO] [stdout] 178 | | .map(Protected::new) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 42 | raw_key: Protected>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | return Err(anyhow::anyhow!( [INFO] [stdout] | ________________________- [INFO] [stdout] 67 | | "argon2id is not supported on header versions above V3." [INFO] [stdout] 68 | | )) [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Protected::new(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 106 | raw_key: Protected>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | return Err(anyhow::anyhow!( [INFO] [stdout] | ________________________- [INFO] [stdout] 115 | | "Balloon hashing is not supported in header versions below V4." [INFO] [stdout] 116 | | )); [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Protected::new(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 172 | let key = keyslot.hash_algorithm.hash(raw_key.clone(), &keyslot.salt).ok()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | [INFO] [stdout] 174 | let cipher = Ciphers::initialize(key, &header.header_type.algorithm).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | / cipher [INFO] [stdout] 176 | | .decrypt(&keyslot.nonce, keyslot.encrypted_key.as_slice()) [INFO] [stdout] 177 | | .map(vec_to_arr) [INFO] [stdout] 178 | | .map(Protected::new) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `volaris-crypto` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `volaris-crypto` (lib) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d0a942c84f8bd4c5aabbd99ccee829fbf84f42a3adaa6720be2def7253a4d5fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0a942c84f8bd4c5aabbd99ccee829fbf84f42a3adaa6720be2def7253a4d5fa", kill_on_drop: false }` [INFO] [stdout] d0a942c84f8bd4c5aabbd99ccee829fbf84f42a3adaa6720be2def7253a4d5fa