[INFO] fetching crate vmtest 0.14.0... [INFO] checking vmtest-0.14.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vmtest 0.14.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate vmtest 0.14.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vmtest 0.14.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate vmtest 0.14.0 [INFO] tweaked toml for crates.io crate vmtest 0.14.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate vmtest 0.14.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6f8927c4bdca1429609a2afcc7ef5f281707d56bfd7f39ec94bf24430d7e1b4 [INFO] running `Command { std: "docker" "start" "-a" "e6f8927c4bdca1429609a2afcc7ef5f281707d56bfd7f39ec94bf24430d7e1b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6f8927c4bdca1429609a2afcc7ef5f281707d56bfd7f39ec94bf24430d7e1b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6f8927c4bdca1429609a2afcc7ef5f281707d56bfd7f39ec94bf24430d7e1b4", kill_on_drop: false }` [INFO] [stdout] e6f8927c4bdca1429609a2afcc7ef5f281707d56bfd7f39ec94bf24430d7e1b4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ecd87d9785ca605aaf0a43c7bbcd03a3780feb3db5f0d31df13eed7842568409 [INFO] running `Command { std: "docker" "start" "-a" "ecd87d9785ca605aaf0a43c7bbcd03a3780feb3db5f0d31df13eed7842568409", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Compiling thiserror v1.0.55 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling relative-path v1.9.0 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking comma v1.0.0 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling thiserror-impl v1.0.55 [INFO] [stderr] Compiling test-log v0.2.13 [INFO] [stderr] Checking rexpect v0.5.0 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking qapi-spec v0.3.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling qapi-parser v0.10.0 [INFO] [stderr] Compiling qapi-codegen v0.11.1 [INFO] [stderr] Compiling qapi-qga v0.12.0 [INFO] [stderr] Compiling qapi-qmp v0.14.0 [INFO] [stderr] Checking qapi v0.14.0 [INFO] [stderr] Checking vmtest v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `patch` is never read [INFO] [stdout] --> src/qga.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Version { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub patch: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Version` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vmtest.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 111 | fn setup_qemu(&self, idx: usize, updates: Sender) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Qemu::new(updates, &target, &self.base).context("Failed to setup QEMU") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 183 | let mut host_init = Builder::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Ok((host_init, guest_init)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:828:13 [INFO] [stdout] | [INFO] [stdout] 798 | let updates = self.updates.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 799 | let output_fn = move |line: String| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 807 | / scopeguard::defer! { [INFO] [stdout] 808 | | // Restore old timeout [INFO] [stdout] 809 | | let _ = qga.set_read_timeout(old_timeout); [INFO] [stdout] 810 | | } [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 813 | let output_stream = connect_to_uds(&self.command_sock) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 828 | Some(output_stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:1056:12 [INFO] [stdout] | [INFO] [stdout] 994 | let mut child = match self.process.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 995 | Ok(c) => c, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 996 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1007 | let mut child = scopeguard::guard(child, Self::child_cleanup); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1014 | let qmp_unix_stream = match connect_to_uds(&self.qmp_sock) { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1015 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1016 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1026 | let qmp_stream = qapi::Stream::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1034 | let mut qmp = Qmp::new(qmp_stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1038 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1046 | let qga = QgaWrapper::new(self.qga_sock.clone(), host_supports_kvm(&self.arch)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1047 | let qga = match qga { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1048 | Ok(q) => q, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1049 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1056 | Ok((child, qga, qmp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:1136:15 [INFO] [stdout] | [INFO] [stdout] 1089 | pub fn run(mut self) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1090 | // Start QEMU [INFO] [stdout] 1091 | let (mut child, qga, mut qmp) = match self.boot_vm() { [INFO] [stdout] | ----- --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1092 | Ok((c, qga, qmp)) => (c, qga, qmp), [INFO] [stdout] | - --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1093 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1136 | match qmp.execute(&qmp::quit {}) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qga.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 122 | let mut qga = Qga::from_stream(&self.stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | qga.execute(&args).context("Error running guest_exec") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qga.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 131 | let mut qga = Qga::from_stream(&self.stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | qga.execute(&qga::guest_exec_status { pid }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `patch` is never read [INFO] [stdout] --> src/qga.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Version { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub patch: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Version` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vmtest.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 111 | fn setup_qemu(&self, idx: usize, updates: Sender) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Qemu::new(updates, &target, &self.base).context("Failed to setup QEMU") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 183 | let mut host_init = Builder::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Ok((host_init, guest_init)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:828:13 [INFO] [stdout] | [INFO] [stdout] 798 | let updates = self.updates.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 799 | let output_fn = move |line: String| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 807 | / scopeguard::defer! { [INFO] [stdout] 808 | | // Restore old timeout [INFO] [stdout] 809 | | let _ = qga.set_read_timeout(old_timeout); [INFO] [stdout] 810 | | } [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 813 | let output_stream = connect_to_uds(&self.command_sock) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 828 | Some(output_stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:1056:12 [INFO] [stdout] | [INFO] [stdout] 994 | let mut child = match self.process.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 995 | Ok(c) => c, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 996 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1007 | let mut child = scopeguard::guard(child, Self::child_cleanup); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1014 | let qmp_unix_stream = match connect_to_uds(&self.qmp_sock) { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1015 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1016 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1026 | let qmp_stream = qapi::Stream::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1034 | let mut qmp = Qmp::new(qmp_stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1038 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1046 | let qga = QgaWrapper::new(self.qga_sock.clone(), host_supports_kvm(&self.arch)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1047 | let qga = match qga { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1048 | Ok(q) => q, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1049 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1056 | Ok((child, qga, qmp)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qemu.rs:1136:15 [INFO] [stdout] | [INFO] [stdout] 1089 | pub fn run(mut self) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1090 | // Start QEMU [INFO] [stdout] 1091 | let (mut child, qga, mut qmp) = match self.boot_vm() { [INFO] [stdout] | ----- --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1092 | Ok((c, qga, qmp)) => (c, qga, qmp), [INFO] [stdout] | - --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1093 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1136 | match qmp.execute(&qmp::quit {}) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vmtest` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qga.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 122 | let mut qga = Qga::from_stream(&self.stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | qga.execute(&args).context("Error running guest_exec") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/qga.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 131 | let mut qga = Qga::from_stream(&self.stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | qga.execute(&qga::guest_exec_status { pid }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vmtest` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ecd87d9785ca605aaf0a43c7bbcd03a3780feb3db5f0d31df13eed7842568409", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecd87d9785ca605aaf0a43c7bbcd03a3780feb3db5f0d31df13eed7842568409", kill_on_drop: false }` [INFO] [stdout] ecd87d9785ca605aaf0a43c7bbcd03a3780feb3db5f0d31df13eed7842568409